Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: master -> main #11730

Merged
merged 4 commits into from
Apr 24, 2022
Merged

chore: master -> main #11730

merged 4 commits into from
Apr 24, 2022

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Apr 22, 2022

Description

Update all references of master to main, including CI workflows, docs, guides, etc...I'm sure I missed some old docs, but we can update those as we find them in the future. Important part is that we got CI and actions covered.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions bot added C:Cosmovisor Issues and PR related to Cosmovisor T: ADR An issue or PR relating to an architectural decision record Type: Build T: CI labels Apr 22, 2022
@alexanderbez alexanderbez added the A:automerge Automatically merge PR once all prerequisites pass. label Apr 22, 2022
@@ -1,3 +1,3 @@
master master
main main
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will break existing links, we should look into redirecting

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain a bit? Shouldn't links still work as we just renamed the default branch?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://docs.cosmos.network/master/ the url here would change from master to main, it may invalidate urls and links in other repos

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not seem that these redirects are working tho: https://github.com/cosmos/cosmos-sdk/blob/main/docs/.vuepress/enhanceApp.js

@julienrbrt
Copy link
Member

julienrbrt commented Apr 22, 2022

This PR cannot be merged to this test failing: https://github.com/cosmos/cosmos-sdk/runs/6133701530?check_suite_focus=true
But to fix this test, we need this PR merged 😅

This is blocking some other PR btw.

@tac0turtle
Copy link
Member

@alexanderbez feel free to admin merge when you think its ready

@alexanderbez alexanderbez merged commit 2e15b54 into main Apr 24, 2022
@alexanderbez alexanderbez deleted the bez/master-to-main branch April 24, 2022 14:19
@alexanderbez
Copy link
Contributor Author

Merged! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:CLI C:Cosmovisor Issues and PR related to Cosmovisor C:x/nft C:x/upgrade T: ADR An issue or PR relating to an architectural decision record T: CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants