Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: invalid return value from keeper GetLastCompleteUpgrade - breaking change version #11800

Merged
merged 11 commits into from
May 2, 2022
Merged

fix!: invalid return value from keeper GetLastCompleteUpgrade - breaking change version #11800

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
9264647
fix!: alternative option to fix #11707
daeMOn63 Apr 27, 2022
562a852
docs: add changelog
daeMOn63 Apr 27, 2022
4e6c5e7
fix: move consensusVersion to const
daeMOn63 Apr 27, 2022
7bbfc58
fix: specify implicit slice offset
daeMOn63 Apr 27, 2022
2457acb
docs: comment magic number
daeMOn63 Apr 28, 2022
f75165c
Merge branch 'main' into xupgrade_index_done_upgrade_by_height
alexanderbez Apr 28, 2022
2672874
Merge branch 'main' into xupgrade_index_done_upgrade_by_height
alexanderbez Apr 30, 2022
52885b6
Update x/upgrade/keeper/keeper.go
alexanderbez Apr 30, 2022
ccee5c6
Update x/upgrade/keeper/keeper_test.go
alexanderbez Apr 30, 2022
1358a89
Merge branch 'main' into xupgrade_index_done_upgrade_by_height
alexanderbez Apr 30, 2022
f19e247
Merge branch 'main' into xupgrade_index_done_upgrade_by_height
alexanderbez May 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update x/upgrade/keeper/keeper.go 
Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>
  • Loading branch information
@alexanderbez @ValarDragon
alexanderbez and ValarDragon committed Apr 30, 2022
commit 52885b611f708c8d5602cc645388ce2306ba48d0
2 changes: 1 addition & 1 deletion x/upgrade/keeper/keeper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ func (k Keeper) GetLastCompletedUpgrade(ctx sdk.Context) (string, int64) {
return "", 0
}

// parseDoneKey - split height and upgrade name from the done key
// parseDoneKey - split upgrade name and height from the done key
func parseDoneKey(key []byte) (string, int64) {
// 1 byte for the DoneByte + 8 bytes height + at least 1 byte for the name
kv.AssertKeyAtLeastLength(key, 10)
Expand Down