Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR template improvement #1195

Merged
merged 1 commit into from
Jun 10, 2018
Merged

PR template improvement #1195

merged 1 commit into from
Jun 10, 2018

Conversation

rigelrozanski
Copy link
Contributor

@rigelrozanski rigelrozanski commented Jun 10, 2018

Note the header is optimized for the github edit box font
... edit >this< box to see the new comment in action

  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG.md
  • Updated Basecoin / other examples
  • Squashed related commits and prefixed with PR number per coding standards

@rigelrozanski rigelrozanski requested review from cwgoes and removed request for cwgoes June 10, 2018 03:36
@codecov
Copy link

codecov bot commented Jun 10, 2018

Codecov Report

Merging #1195 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1195   +/-   ##
========================================
  Coverage    65.23%   65.23%           
========================================
  Files           87       87           
  Lines         4415     4415           
========================================
  Hits          2880     2880           
  Misses        1356     1356           
  Partials       179      179

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@cwgoes cwgoes merged commit d309abb into develop Jun 10, 2018
@cwgoes cwgoes deleted the rigel/update-pr-template branch June 10, 2018 04:11
davekaj pushed a commit to davekaj/cosmos-sdk that referenced this pull request Jun 11, 2018
thang14 pushed a commit to thang14/cosmos-sdk that referenced this pull request Jun 12, 2018
cwgoes pushed a commit that referenced this pull request Jun 13, 2018
* update to tm v0.19.6
* update tm to 0.17.4
* update for tm v0.19.9
* update godep
* Merge PR #1195: gaiacli - Add error message for when account isn't found
* Add --gas flag to specify gas limit for a transaction
* lawl viper
* version and changelog
* add cmd/gaia/testnets folder to deprecate cosmos/testnets repo
* cmd/gaia/testnets: update status.md with recent history
* cmd/gaia/testnets: update versions, use a working seed
* readme points to testnet folder
* add fixes from billy
* fix status.md
* seed->seeds
* readme improvements
add link to official faucet, remove sequence from cmds
readme improvements
wording improvements and simplifications
add link to cosmos explorer
remove instances of candidate
add apostrophe
small fixes
improve the installing software section
fixes based on feedback
add note about querying an empty account
remove panic note
update introduction
add full cp path for copying genesis.json
update moniker warning
remove redundant sections
add error message when querying empty account
don't need a link to golang.org
link to sections, better section names
fix section link
reorganize sections
add h3s
remove & symbol
add whitespace
update h3 to h2
add note about explorer not connecting to every node
* testnets: minor readme update
* gaiadebug tool
* gaiadebug: add hack command
* fix from merge
* gaiadebug: raw-bytes command
* fix from merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants