Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(staking): migrate x/params away from x/staking #12409

Merged
merged 71 commits into from
Jul 21, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
71 commits
Select commit Hold shift + click to select a range
2ac55bf
feat(staking): migrate x/params away from x/staking
JeancarloBarrios Jun 30, 2022
43c5ed7
removing params dependency
JeancarloBarrios Jul 6, 2022
f98e690
Merge branch 'main' into JeancarloBarrios/migrate-staking-away-from-p…
JeancarloBarrios Jul 6, 2022
fc4db25
remove params dependencies
JeancarloBarrios Jul 6, 2022
4521984
remove dependencies from x/paramss
JeancarloBarrios Jul 7, 2022
1c38e9d
create legacy params file
JeancarloBarrios Jul 7, 2022
5b2766a
temporal removal and comments of params related tests
JeancarloBarrios Jul 8, 2022
beb4330
added test for msg server update params
JeancarloBarrios Jul 8, 2022
c9493a9
temporal removal of address check
JeancarloBarrios Jul 9, 2022
9bdbd4c
Merge branch 'main' into JeancarloBarrios/migrate-staking-away-from-p…
JeancarloBarrios Jul 13, 2022
db35873
merge main
JeancarloBarrios Jul 13, 2022
5902ca0
remove unused impports
JeancarloBarrios Jul 13, 2022
79ccf41
Delete debug_container.dot
JeancarloBarrios Jul 13, 2022
9154042
Update store/streaming/file/service_test.go
JeancarloBarrios Jul 13, 2022
e412ce9
modified test for them to pass
JeancarloBarrios Jul 13, 2022
8f97fc7
updated spec
JeancarloBarrios Jul 13, 2022
6496058
updated the changelog
JeancarloBarrios Jul 13, 2022
d4cbb89
Merge branch 'main' into JeancarloBarrios/migrate-staking-away-from-p…
JeancarloBarrios Jul 13, 2022
d0c05d3
remove unesesary comments
JeancarloBarrios Jul 13, 2022
7d738c8
added check for address
JeancarloBarrios Jul 13, 2022
a0260c9
failing build
JeancarloBarrios Jul 13, 2022
a4e941e
arm build failing
JeancarloBarrios Jul 13, 2022
9164811
arm build failing
JeancarloBarrios Jul 13, 2022
b6590d8
Improve test coverage
JeancarloBarrios Jul 13, 2022
675fe5f
Merge branch 'main' into JeancarloBarrios/migrate-staking-away-from-p…
JeancarloBarrios Jul 13, 2022
a4c365e
remove unesesary comment
JeancarloBarrios Jul 13, 2022
63bbd3d
Merge branch 'JeancarloBarrios/migrate-staking-away-from-params' of h…
JeancarloBarrios Jul 13, 2022
054520b
remove duplicated values
JeancarloBarrios Jul 14, 2022
c6afdce
Merge branch 'main' into JeancarloBarrios/migrate-staking-away-from-p…
JeancarloBarrios Jul 14, 2022
261831f
added key for migration
JeancarloBarrios Jul 14, 2022
9f9fee1
added key for migration
JeancarloBarrios Jul 14, 2022
bccc2e6
Merge branch 'JeancarloBarrios/migrate-staking-away-from-params' of h…
JeancarloBarrios Jul 14, 2022
a6388d9
removed redundant call
JeancarloBarrios Jul 14, 2022
5f95cf3
not asigning variable
JeancarloBarrios Jul 14, 2022
d27e30a
move migration to consensus version
JeancarloBarrios Jul 14, 2022
83fbca3
change consesus version package name;
JeancarloBarrios Jul 14, 2022
eb819d9
Merge branch 'main' into JeancarloBarrios/migrate-staking-away-from-p…
JeancarloBarrios Jul 14, 2022
3ef6541
Merge branch 'main' into JeancarloBarrios/migrate-staking-away-from-p…
alexanderbez Jul 14, 2022
9a5c9a2
temporal commit
JeancarloBarrios Jul 14, 2022
ac876b1
depinject type fix
kocubinski Jul 14, 2022
d69e8fb
fix iface impl
kocubinski Jul 14, 2022
c562582
Merge branch 'main' into JeancarloBarrios/migrate-staking-away-from-p…
JeancarloBarrios Jul 14, 2022
7836f08
complete migration
JeancarloBarrios Jul 15, 2022
bc19525
Merge branch 'JeancarloBarrios/migrate-staking-away-from-params' of h…
JeancarloBarrios Jul 15, 2022
5b0eab1
remove params from simulation
JeancarloBarrios Jul 15, 2022
01d0cd6
remove unesesary json
JeancarloBarrios Jul 15, 2022
0e92a0e
comment
JeancarloBarrios Jul 15, 2022
feddfe0
Merge branch 'main' into JeancarloBarrios/migrate-staking-away-from-p…
JeancarloBarrios Jul 15, 2022
beffda2
removing not needed functions
JeancarloBarrios Jul 17, 2022
06bb7ce
Merge branch 'main' into JeancarloBarrios/migrate-staking-away-from-p…
JeancarloBarrios Jul 17, 2022
aa285c4
Update proto/cosmos/staking/v1beta1/tx.proto
JeancarloBarrios Jul 18, 2022
d70e794
Update x/staking/types/msg.go
JeancarloBarrios Jul 18, 2022
d328c7f
remove panic option
JeancarloBarrios Jul 18, 2022
7e60a72
Merge branch 'JeancarloBarrios/migrate-staking-away-from-params' of h…
JeancarloBarrios Jul 18, 2022
71e9273
Merge branch 'main' into JeancarloBarrios/migrate-staking-away-from-p…
JeancarloBarrios Jul 18, 2022
797fd58
Merge branch 'main' into JeancarloBarrios/migrate-staking-away-from-p…
JeancarloBarrios Jul 18, 2022
17cf982
Update x/staking/keeper/params.go
JeancarloBarrios Jul 20, 2022
12eae0a
changing import name
JeancarloBarrios Jul 20, 2022
bc6bc3a
minor fixes
JeancarloBarrios Jul 20, 2022
9f36470
Merge branch 'JeancarloBarrios/migrate-staking-away-from-params' of g…
JeancarloBarrios Jul 20, 2022
3fd6dac
Merge branch 'main' into JeancarloBarrios/migrate-staking-away-from-p…
JeancarloBarrios Jul 20, 2022
8d51d8d
Update x/staking/spec/03_messages.md
JeancarloBarrios Jul 20, 2022
8832e2d
Update x/staking/migrations/v4/store.go
JeancarloBarrios Jul 20, 2022
106f902
Update x/staking/migrations/v3/store.go
JeancarloBarrios Jul 20, 2022
03bb8e4
Update x/staking/spec/01_state.md
JeancarloBarrios Jul 20, 2022
13d0bc7
increades deprecated note
JeancarloBarrios Jul 20, 2022
0abd491
Merge branch 'main' into JeancarloBarrios/migrate-staking-away-from-p…
JeancarloBarrios Jul 21, 2022
8b4f511
Merge branch 'main' into JeancarloBarrios/migrate-staking-away-from-p…
alexanderbez Jul 21, 2022
0ca3264
Add "foo" subspace in x/params CLI test (#12677)
JeancarloBarrios Jul 21, 2022
8c10351
remove hardcoding and add default for authority
JeancarloBarrios Jul 21, 2022
0c916f1
Merge branch 'main' into JeancarloBarrios/migrate-staking-away-from-p…
JeancarloBarrios Jul 21, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
removing not needed functions
  • Loading branch information
JeancarloBarrios committed Jul 17, 2022
commit beffda26522c452ff70baa51b7bac9126d501b0c
6 changes: 0 additions & 6 deletions x/staking/types/msg.go
Original file line number Diff line number Diff line change
Expand Up @@ -396,12 +396,6 @@ func (msg MsgCancelUnbondingDelegation) ValidateBasic() error {
return nil
}

// Route returns the MsgUpdateParams message route.
func (m *MsgUpdateParams) Route() string { return ModuleName }

// Type returns the MsgUpdateParams message type.
func (m *MsgUpdateParams) Type() string { return TypeMsgUpdateParams }

// GetSignBytes returns the raw bytes for a MsgUpdateParams message that
// the expected signer needs to sign.
func (m MsgUpdateParams) GetSignBytes() []byte {
Expand Down
2 changes: 0 additions & 2 deletions x/staking/types/msg_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -207,8 +207,6 @@ func TestMsgUpdateParams(t *testing.T) {
Params: types.DefaultParams(),
}

require.Contains(t, "staking", msg.Route())
require.Contains(t, types.TypeMsgUpdateParams, msg.Type())
require.Equal(t, []sdk.AccAddress{authtypes.NewModuleAddress(govtypes.ModuleName)}, msg.GetSigners())
}

Expand Down