Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: gogo/protobuf v1.3.2 #12596

Merged
merged 11 commits into from
Jul 18, 2022
Merged

chore: gogo/protobuf v1.3.2 #12596

merged 11 commits into from
Jul 18, 2022

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Jul 15, 2022

Description

This helps to prepare for #11453 by removing the ics23 dependency on gogo/protobuf v1.3.3 which does not exist.

It will have an outsized quality of life impact.

For reference the way to do this is:

  • keep the replace as-is
  • go get github.com/gogo/protobuf@v1.3.2

Affects

  • cosmovisor
  • ics23
  • sdk

Prerequisite to:

Maybe not exactly a prerequisite, more like something that will reduce the review scope of #11453 and also eliminate this problem for downstream users of the sdk.

To clarify the purpose here, the command go work sink, does not work because the upstream version 1.3.3 does not exist in gogo/protobuf


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@faddat faddat requested a review from a team as a code owner July 15, 2022 13:36
@faddat faddat changed the title ics23: gogo/protobuf v1.3.2 chore: ics23 gogo/protobuf v1.3.2 Jul 15, 2022
@faddat faddat changed the title chore: ics23 gogo/protobuf v1.3.2 chore: gogo/protobuf v1.3.2 Jul 15, 2022
@codecov
Copy link

codecov bot commented Jul 15, 2022

Codecov Report

Merging #12596 (543f933) into main (6a08830) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12596      +/-   ##
==========================================
+ Coverage   65.20%   65.22%   +0.02%     
==========================================
  Files         693      696       +3     
  Lines       71840    72047     +207     
==========================================
+ Hits        46842    46996     +154     
- Misses      22368    22403      +35     
- Partials     2630     2648      +18     
Impacted Files Coverage Δ
store/tools/ics23/iavl/convert.go 91.66% <0.00%> (ø)
store/tools/ics23/iavl/create.go 63.26% <0.00%> (ø)
store/tools/ics23/smt/create.go 65.11% <0.00%> (ø)
crypto/keys/internal/ecdsa/privkey.go 83.01% <0.00%> (+1.88%) ⬆️

github.com/cosmos/go-bip39 v1.0.0
github.com/cosmos/iavl v0.18.0
github.com/cosmos/ledger-cosmos-go v0.11.1
github.com/desertbit/timer v0.0.0-20180107155436-c41aec40b27f // indirect
github.com/gogo/gateway v1.1.0
github.com/gogo/protobuf v1.3.3
github.com/gogo/protobuf v1.3.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this downgraded on purpose?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.3.3 doesn't exist, its meant to be a replace tag to regens fork. This was working because of the replace tag.

@amaury1093 amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label Jul 18, 2022
@mergify mergify bot merged commit 7c43d52 into cosmos:main Jul 18, 2022
@faddat faddat mentioned this pull request Jul 20, 2022
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:Store
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants