Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: re-add cosmovisor in go.work to fix make test #12884

Merged
merged 4 commits into from
Aug 10, 2022

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Aug 10, 2022

Description

Ref: #12851 (comment)
Implementing point 2 of that comment. Point 1 is coming in a follow-up.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt requested a review from a team as a code owner August 10, 2022 08:00
@github-actions github-actions bot added C:CLI C:Cosmovisor Issues and PR related to Cosmovisor C:orm C:Store labels Aug 10, 2022
@julienrbrt julienrbrt marked this pull request as draft August 10, 2022 08:03
@julienrbrt julienrbrt marked this pull request as ready for review August 10, 2022 08:05
@julienrbrt julienrbrt changed the title fix: temporarily re-add cosmovisor in go.work to fix make test fix: re-add cosmovisor in go.work to fix make test Aug 10, 2022
@julienrbrt julienrbrt merged commit 1c16c11 into main Aug 10, 2022
@julienrbrt julienrbrt deleted the julien/fix-make-test-1 branch August 10, 2022 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:CLI C:Cosmovisor Issues and PR related to Cosmovisor C:orm C:Store
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants