Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: List HRP prefixes in Bech32 addresses #13064

Merged
merged 9 commits into from
Sep 5, 2022
Merged

feat: List HRP prefixes in Bech32 addresses #13064

merged 9 commits into from
Sep 5, 2022

Conversation

rnbguy
Copy link
Contributor

@rnbguy rnbguy commented Aug 27, 2022

Description

Closes: #13060

Adds a new subcommand simd debug prefixes to list prefixes used as HRP in Bech32 addresses.

$ ./build/simd debug prefixes
Bech32 Acc: cosmos
Bech32 Val: cosmosvaloper

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions bot added the C:CLI label Aug 27, 2022
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Utack, Could we get a changelog entry please.

client/debug/main.go Show resolved Hide resolved
client/debug/main.go Outdated Show resolved Hide resolved
@julienrbrt julienrbrt changed the title [Features] List HRP prefixes in Bech32 addresses feat: List HRP prefixes in Bech32 addresses Aug 28, 2022
@codecov
Copy link

codecov bot commented Aug 28, 2022

Codecov Report

Merging #13064 (1afd123) into main (4fe7797) will decrease coverage by 2.66%.
The diff coverage is 47.01%.

❗ Current head 1afd123 differs from pull request most recent head c930ee8. Consider uploading reports for the commit c930ee8 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #13064      +/-   ##
==========================================
- Coverage   55.87%   53.21%   -2.67%     
==========================================
  Files         646      645       -1     
  Lines       54895    55188     +293     
==========================================
- Hits        30675    29366    -1309     
- Misses      21762    23475    +1713     
+ Partials     2458     2347     -111     
Impacted Files Coverage Δ
baseapp/abci.go 67.01% <0.00%> (+2.59%) ⬆️
baseapp/baseapp.go 77.93% <ø> (+1.06%) ⬆️
baseapp/options.go 69.23% <ø> (+0.71%) ⬆️
client/context.go 55.37% <0.00%> (-0.91%) ⬇️
client/flags/flags.go 19.35% <0.00%> (-0.32%) ⬇️
client/rpc/status.go 66.66% <ø> (ø)
client/utils.go 34.92% <0.00%> (ø)
crypto/keys/secp256k1/secp256k1.go 88.63% <ø> (ø)
server/config/config.go 38.00% <0.00%> (-1.59%) ⬇️
server/mock/store.go 19.00% <0.00%> (-0.39%) ⬇️
... and 134 more

@tac0turtle
Copy link
Member

@rnbguy is there anything you need from us to finish this?

@rnbguy
Copy link
Contributor Author

rnbguy commented Sep 3, 2022

@marbar3778 I added a changelog entry. I am not sure about tests and code coverage. I don't find any test for other debug subcommand. If I missed it, please point me to it. Let me know if I overlooked anything else.

@alexanderbez
Copy link
Contributor

We just need to resolve conflicts and then mark this ready for review and then we can merge 👍

@tac0turtle tac0turtle marked this pull request as ready for review September 5, 2022 07:41
@tac0turtle tac0turtle requested a review from a team as a code owner September 5, 2022 07:41
@tac0turtle tac0turtle added the A:automerge Automatically merge PR once all prerequisites pass. label Sep 5, 2022
@alexanderbez alexanderbez enabled auto-merge (squash) September 5, 2022 13:46
@alexanderbez alexanderbez merged commit 8579bdd into cosmos:main Sep 5, 2022
Wryhder pushed a commit to Wryhder/cosmos-sdk that referenced this pull request Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extract bech32 prefixes from a chain binary
5 participants