Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(depinject): allow module keys to manually be created for codegen/manual wiring #13124

Merged
merged 6 commits into from
Sep 2, 2022

Conversation

aaronc
Copy link
Member

@aaronc aaronc commented Sep 1, 2022

Description

Ref #12556

This PR adds depinject.ModuleKeyContext which allows ModuleKeys to be constructed manually for use in codegen or manual wiring scenarios without depinject.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@aaronc aaronc marked this pull request as ready for review September 1, 2022 15:58
@aaronc aaronc requested a review from a team as a code owner September 1, 2022 15:59
@codecov
Copy link

codecov bot commented Sep 1, 2022

Codecov Report

Merging #13124 (41d7a2f) into main (ccdc355) will increase coverage by 0.94%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #13124      +/-   ##
==========================================
+ Coverage   53.21%   54.15%   +0.94%     
==========================================
  Files         645      666      +21     
  Lines       55193    56755    +1562     
==========================================
+ Hits        29370    30736    +1366     
- Misses      23476    23616     +140     
- Partials     2347     2403      +56     
Impacted Files Coverage Δ
depinject/config.go 89.41% <100.00%> (ø)
depinject/container.go 90.40% <100.00%> (ø)
depinject/module_key.go 100.00% <100.00%> (ø)
depinject/one_per_module.go 78.84% <0.00%> (ø)
depinject/internal/codegen/func.go 100.00% <0.00%> (ø)
depinject/module_dep.go 92.30% <0.00%> (ø)
depinject/group.go 80.00% <0.00%> (ø)
depinject/simple.go 100.00% <0.00%> (ø)
depinject/internal/codegen/type.go 73.63% <0.00%> (ø)
depinject/internal/codegen/file.go 92.59% <0.00%> (ø)
... and 16 more

@julienrbrt julienrbrt enabled auto-merge (squash) September 2, 2022 22:01
@julienrbrt julienrbrt merged commit 3ffa1d1 into main Sep 2, 2022
@julienrbrt julienrbrt deleted the aaronc/depinject-manual-module-key branch September 2, 2022 22:17
Wryhder pushed a commit to Wryhder/cosmos-sdk that referenced this pull request Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants