benchmarks: Add benchmark for block time to bank module #1332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To be added to CI at some point - #1333. |
|
Refactor per #1327 (comment) |
ValarDragon
changed the title
ValarDragon
force-pushed
the
dev/add_bench
branch
from
1ee449f
to
5ef8371
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1332 +/- ##
==========================================
+ Coverage 62.81% 63.72% +0.9%
==========================================
Files 109 109
Lines 6016 6026 +10
==========================================
+ Hits 3779 3840 +61
+ Misses 2020 1967 -53
- Partials 217 219 +2 |
ValarDragon
force-pushed
the
dev/add_bench
branch
from
5ef8371
to
22d63f7
Compare
|
Can we add a few lines, either in CHANGELOG.md or in a doc, describing how to run benchmarks with the profiler and view output? |
|
Sure. Where in the docs would this belong? |
|
|
I think this is fine as is - we can have benchmarks in the particular modules that they're benchmarking. |
adrianbrink
pushed a commit
that referenced
this pull request
Jul 2, 2018
* benchmarks: Add benchmark folder, and single benchmark for block time * Move benchmark into module * Fix merge conflict errors * Fix spelling * Add instructions to run benchmark * Update auth_app_test.go
chillyvee
pushed a commit
to chillyvee/cosmos-sdk
that referenced
this pull request
Mar 1, 2024
* Update contrib/statesync.bash Bash script. * Remove genesis download step, in favour of "--chain-id" flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1327