docs: improve keyring package docs #13835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rootulp
commented
Nov 10, 2022
| @@ -21,20 +21,20 @@ | |||
| // | |||
| // The backends: | |||
| // | |||
| // os The instance returned by this constructor uses the operating system's default | |||
There was a problem hiding this comment.
the whitespace changes look odd but they render better
| Before | After |
|---|---|
 |
 |
| @@ -1,9 +1,9 @@ | |||
| // Package keys provides common key management API. | |||
| // Package keyring provides common key management API. | |||
There was a problem hiding this comment.
this doc was originally written when the package was named keys but the package has since been renamed
Ref: #5833
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #13835 +/- ##
==========================================
- Coverage 56.75% 56.73% -0.03%
==========================================
Files 637 637
Lines 54722 54722
==========================================
- Hits 31057 31046 -11
- Misses 21151 21164 +13
+ Partials 2514 2512 -2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve Keyring docs