Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: make x/evidence a standalone module #14724

Merged
merged 16 commits into from
Jan 24, 2023
Merged

refactor: make x/evidence a standalone module #14724

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
5b2a006
add go mod
likhita-809 Jan 20, 2023
393606e
add more go mod files
likhita-809 Jan 23, 2023
596c0fa
Merge branch 'main' of https://github.com/cosmos/cosmos-sdk into likh…
likhita-809 Jan 23, 2023
6d24bf6
remove unncessary replace line in go mod
likhita-809 Jan 23, 2023
6232458
use cosmossdk.io/x/evidence
likhita-809 Jan 23, 2023
6e24cf0
revert changes from proto files
likhita-809 Jan 23, 2023
7b5e2b3
fix imports
likhita-809 Jan 23, 2023
ae2498c
address review comments
likhita-809 Jan 23, 2023
15c4b86
address more comments
likhita-809 Jan 23, 2023
d0b60d0
use cosmossdk.io/x/evidence in proto files
likhita-809 Jan 23, 2023
a842255
Merge branch 'likhita/evidence-standalone' of https://github.com/cosm…
likhita-809 Jan 23, 2023
de640ba
Merge branch 'main' into likhita/evidence-standalone
julienrbrt Jan 23, 2023
b2ec413
fix permission and few nits
likhita-809 Jan 23, 2023
a1d97e3
Merge branch 'main' of https://github.com/cosmos/cosmos-sdk into likh…
likhita-809 Jan 24, 2023
ea5bde6
fix something
likhita-809 Jan 24, 2023
c6c9de2
fix test
likhita-809 Jan 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
address review comments
  • Loading branch information
@likhita-809
likhita-809 committed Jan 23, 2023
commit ae2498c84aa16cd80d7737f703502b3257aa818f
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ Ref: https://keepachangelog.com/en/1.0.0/

### Features

* (x/evidence) [14724](https://github.com/cosmos/cosmos-sdk/pull/14724) The `x/evidence` module is extracted to have a separate go.mod file which allows it be a standalone module.
likhita-809 marked this conversation as resolved.
Show resolved Hide resolved
* (x/auth) [#14650](https://github.com/cosmos/cosmos-sdk/pull/14650) Add Textual SignModeHandler. It is however **NOT** enabled by default, and should only be used for **TESTING** purposes until `SIGN_MODE_TEXTUAL` is fully released.
* (cli) [#14655](https://github.com/cosmos/cosmos-sdk/pull/14655) Add a new command to list supported algos.
* (x/crisis) [#14588](https://github.com/cosmos/cosmos-sdk/pull/14588) Use CacheContext() in AssertInvariants()
Expand Down Expand Up @@ -164,6 +165,7 @@ Ref: https://keepachangelog.com/en/1.0.0/

### API Breaking Changes

* (x/evidence) [14724](https://github.com/cosmos/cosmos-sdk/pull/14724) Use `cosmossdk.io/x/evidence` instead of `github.com/cosmos/cosmos-sdk/x/evidence` as evidence is extracted to be a standalone module.
* (tx) [#14634](https://github.com/cosmos/cosmos-sdk/pull/14634) Move the `tx` go module to `x/tx`.
* (snapshots) [#14597](https://github.com/cosmos/cosmos-sdk/pull/14597) Move `snapshots` to `store/snapshots`, rename and bump proto package to v1.
* (crypto/keyring) [#14151](https://github.com/cosmos/cosmos-sdk/pull/14151) Move keys presentation from `crypto/keyring` to `client/keys`
Expand Down
14 changes: 14 additions & 0 deletions UPGRADING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,20 @@ The `gov` module has been updated to support the ability to cancel governance pr

By default, the new `ProposalCancelRatio` parameter is set to 0.5 during migration and `ProposalCancelDest` is set to empty string (i.e. burnt).

#### `x/evidence`

##### Extract evidence to a standalone module

The `x/evidence` module is extracted to have a separate go.mod file which allows it be a standalone module.
All the evidence imports are now renamed to use `cosmossdk.io/evidence` instead of `github.com/cosmos/cosmos-sdk/x/evidence` across the SDK.

#### `x/nft`

##### Extract nft to a standalone module

The `x/nft` module has now extracted to have a separate go.mod file which allows it be a standalone module.
likhita-809 marked this conversation as resolved.
Show resolved Hide resolved


## [v0.47.x](https://github.com/cosmos/cosmos-sdk/releases/tag/v0.47.0)

### Simulation
Expand Down
5 changes: 3 additions & 2 deletions simapp/app_v2.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,13 @@ import (
"os"
"path/filepath"

dbm "github.com/cosmos/cosmos-db"
"github.com/tendermint/tendermint/libs/log"

"cosmossdk.io/client/v2/autocli"
"cosmossdk.io/depinject"
"cosmossdk.io/x/evidence"
evidencekeeper "cosmossdk.io/x/evidence/keeper"
dbm "github.com/cosmos/cosmos-db"
"github.com/tendermint/tendermint/libs/log"

"github.com/cosmos/cosmos-sdk/baseapp"
"github.com/cosmos/cosmos-sdk/client"
Expand Down
12 changes: 11 additions & 1 deletion x/evidence/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,14 @@ Types of changes (Stanzas):
Ref: https://keepachangelog.com/en/1.0.0/
-->

# Changelog
# Changelog

## [Unreleased]

### Features

* (x/evidence) [14724](https://github.com/cosmos/cosmos-sdk/pull/14724) The `x/evidence` module is extracted to have a separate go.mod file which allows it be a standalone module.

### API Breaking Changes

* (x/evidence) [14724](https://github.com/cosmos/cosmos-sdk/pull/14724) Use `cosmossdk.io/x/evidence` instead of `github.com/cosmos/cosmos-sdk/x/evidence` as evidence is extracted to be a standalone module.
likhita-809 marked this conversation as resolved.
Show resolved Hide resolved