Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Refactor TxSearch #14758

Merged
merged 41 commits into from
Feb 24, 2023
Merged

refactor: Refactor TxSearch #14758

merged 41 commits into from
Feb 24, 2023

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Jan 24, 2023

Description

Closes: #14727

Changelog

  • Refactor QueryTxsByEvents to accept query instead of events
  • Deprecate GetTxsEventRequest.Events field
  • Introduce new GetTxsEventRequest.Query field which will be directly proxied to Tendermint's TxSearch RPC method, thus utilizing Tendermint's validation and query semantics

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions bot added the C:CLI label Jan 25, 2023
x/auth/client/cli/query.go Fixed Show fixed Hide fixed
@alexanderbez alexanderbez marked this pull request as ready for review January 26, 2023 20:29
@alexanderbez alexanderbez requested a review from a team as a code owner January 26, 2023 20:29
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK. Pending s/Tendermint/CometBFT and one minor nit in proto.

proto/cosmos/tx/v1beta1/service.proto Outdated Show resolved Hide resolved
proto/cosmos/tx/v1beta1/service.proto Show resolved Hide resolved
@tac0turtle tac0turtle enabled auto-merge (squash) February 21, 2023 14:42
@tac0turtle tac0turtle added the A:automerge Automatically merge PR once all prerequisites pass. label Feb 21, 2023
@tac0turtle
Copy link
Member

e2e tests are broken, wont be able to debug this week. Will need to come back to it next week

@alexanderbez
Copy link
Contributor Author

alexanderbez commented Feb 21, 2023

I think they just need to be updated to use Query instead of Events in the query object. Pretty straightforward. I can hop on this after I make more progress on the storage ADR.

@julienrbrt julienrbrt added the backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release label Feb 24, 2023
@julienrbrt julienrbrt removed the backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release label Feb 24, 2023
@julienrbrt julienrbrt enabled auto-merge (squash) February 24, 2023 15:48
@julienrbrt julienrbrt merged commit 4169053 into main Feb 24, 2023
@julienrbrt julienrbrt deleted the bez/14727-refactor-tx-search branch February 24, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:CLI C:x/auth C:x/gov
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GetTxsEvents query non-equals comparisons are blocked
7 participants