Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix int conversion lint #15070

Merged
merged 4 commits into from
Feb 20, 2023
Merged

chore: fix int conversion lint #15070

merged 4 commits into from
Feb 20, 2023

Conversation

tac0turtle
Copy link
Member

Description

this pr fixes a integer conversion lint issue.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@tac0turtle tac0turtle marked this pull request as ready for review February 20, 2023 11:16
@tac0turtle tac0turtle requested a review from a team as a code owner February 20, 2023 11:16
testinginprod
testinginprod approved these changes Feb 20, 2023
View reviewed changes
Copy link
Contributor

@testinginprod testinginprod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but there should be a breaking changelog entry.

@tac0turtle tac0turtle added the A:automerge Automatically merge PR once all prerequisites pass. label Feb 20, 2023
@mergify mergify bot merged commit fd34d3f into main Feb 20, 2023
@mergify mergify bot deleted the marko/conversion_uint branch February 20, 2023 12:36
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 20, 2023
View reviewed changes
crypto/keys/bcrypt/bcrypt.go
@@ -271,19 +271,19 @@
if err != nil {
return -1, err
}
err = checkCost(cost)
err = checkCost(uint32(cost))

Check failure

Code scanning / CodeQL

Incorrect conversion between integer types

Incorrect conversion of an integer with architecture-dependent bit size from [strconv.Atoi](1) to a lower bit size type uint32 without an upper bound check.
crypto/keys/bcrypt/bcrypt.go
if err != nil {
return -1, err
}
p.cost = cost
p.cost = uint32(cost)

Check failure

Code scanning / CodeQL

Incorrect conversion between integer types

Incorrect conversion of an integer with architecture-dependent bit size from [strconv.Atoi](1) to a lower bit size type uint32 without an upper bound check.
@faddat faddat mentioned this pull request Mar 28, 2023
Closed
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@testinginprod testinginprod testinginprod approved these changes

@JeancarloBarrios JeancarloBarrios Awaiting requested review from JeancarloBarrios

@samricotta samricotta Awaiting requested review from samricotta

Assignees
No one assigned
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tac0turtle @julienrbrt @testinginprod