Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Create ABCI++ Verfication Methods #15298

Merged
merged 21 commits into from
Mar 8, 2023
Merged

feat: Create ABCI++ Verfication Methods #15298

merged 21 commits into from
Mar 8, 2023

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Mar 7, 2023

Description

Closes: #15288

  • Create methods that allow indirect access to runTx which will allow applications with custom ABCI++ handlers to verify transactions.
  • Move default ABCI proposal handlers out into a separate struct, giving app devs an example of how to set/plugin custom handlers.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@alexanderbez alexanderbez marked this pull request as ready for review March 7, 2023 20:31
@alexanderbez alexanderbez requested a review from a team as a code owner March 7, 2023 20:31
baseapp/baseapp.go Outdated Show resolved Hide resolved
baseapp/baseapp.go Outdated Show resolved Hide resolved
baseapp/baseapp.go Outdated Show resolved Hide resolved
baseapp/baseapp.go Outdated Show resolved Hide resolved
@alexanderbez alexanderbez enabled auto-merge (squash) March 8, 2023 03:26
@alexanderbez
Copy link
Contributor Author

alexanderbez commented Mar 8, 2023

@tac0turtle are you chill with backporting this to v0.47.x or do you prefer to wait till 0.47.1?

@julienrbrt julienrbrt disabled auto-merge March 8, 2023 10:55
baseapp/baseapp.go Outdated Show resolved Hide resolved
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, waiting to approve for juliens comments to be resolved

@alexanderbez alexanderbez added the backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release label Mar 8, 2023
@alexanderbez alexanderbez enabled auto-merge (squash) March 8, 2023 14:48
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@alexanderbez alexanderbez merged commit 4932f11 into main Mar 8, 2023
@alexanderbez alexanderbez deleted the bez/15288 branch March 8, 2023 19:19
mergify bot pushed a commit that referenced this pull request Mar 8, 2023
(cherry picked from commit 4932f11)

# Conflicts:
#	baseapp/baseapp.go
alexanderbez added a commit that referenced this pull request Mar 8, 2023
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Aleksandr Bezobchuk <aleks.bezobchuk@gmail.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prepare/Process Proposal Tx Validator Handlers
4 participants