-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add changelog reminder #15459
ci: add changelog reminder #15459
Conversation
R4R. Updated severely outdated changelog with command like |
@julienrbrt your pull request is missing a changelog! |
math/CHANGELOG.md
Outdated
|
||
### Features | ||
|
||
* Add rand funcs to math ([#15043](https://github.com/cosmos/cosmos-sdk/issues/15043)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is inverting the format, if we go with this we should update the docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this is a generated changelog, it is not supposed to be manually edited, so I think it's fine.
There are a few improvements to be made as discussed with @chatton, I've only added the git cliff to help us when tagging, to quickly verify whether the changelog is ok or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its confusing that we have one way here and another elsewhere. Any chance we can decide on one or the other and go with it?
trying to make it consistent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This make sense, lmc how I can update the template!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
thanks |
Description
Intermediary solution for: #15415
Replaces #15452.
Adding the git cliff config, as it is still useful, for some modules after cleaning up, we should not replace the current process, but this allows us to quickly fix the severely outdated changelog (like math).
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change