feat: update store module for new iavl #15568

cool-develope · 2023-03-28T12:49:51Z

Description

Closes: #XXXX

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

confirmed the correct type prefix in the PR title
confirmed ! in the type prefix if API or client breaking change
confirmed all author checklist items have been addressed
reviewed state machine logic
reviewed API design and naming
reviewed documentation is accurate
reviewed tests and test coverage
manually tested (if applicable)

store/rootmulti/store_test.go

store/iavl/store.go

tac0turtle

before merging this we need an issue on how to do migrations

elias-orijtech

LGTM apart from nits.

store/pruning/manager.go

store/rootmulti/store_test.go

tac0turtle · 2023-04-11T10:00:47Z

build doesnt pass

tac0turtle · 2023-04-17T12:42:51Z

waiting to merge this until we have migrations tested as this merge would signify the adoption of this in the Eden release

odeke-em

Thank you for this change @cool-develope, I've added my first round of review, please take a look.

store/pruning/manager.go

…ore/new_iavl

tac0turtle · 2023-05-30T21:04:44Z

store/rootmulti/store_test.go


 	// "restart"
 	ms = newMultiStoreWithMounts(db, pruningtypes.NewCustomPruningOptions(2, 11))
-	ms.SetSnapshotInterval(3)


i think we should still keep this so we dont break pruning dependence on snapshot intervals

for now, the snapshot interval doesn't affect the pruning strategy if we don't call HandleHeightSnapshot.

tac0turtle

Looks good. Been running this on juno for a week now

tac0turtle · 2023-06-03T04:16:12Z

lets resolve the conflicts then we can merge this

baseapp/options.go

julienrbrt · 2023-06-03T06:15:05Z

store/CHANGELOG.md

+    - Remov `DeleteVersion`, `DeleteVersions`, `LazyLoadVersionForOverwriting` from `iavl` tree API.
+    - Add `DeleteVersionsTo` and `SaveChangeSet`, since it will keep versions sequentially like `fromVersion` to `toVersion`.
+    - Refactor the pruning manager to use `DeleteVersionsTo`.
+    - Remove `IAVLLazyLoading` option from baseapp.


This one should be in the main changelog ./CHANGELOG.md instead of under store/CHANGELOG.md

julienrbrt · 2023-06-03T06:16:34Z

store/iavl/tree.go

 		TraverseStateChanges(startVersion, endVersion int64, fn func(version int64, changeSet *iavl.ChangeSet) error) error
+		SaveChangeSet(changeSet *iavl.ChangeSet) (int64, error)


This comment is still unimplemented.

julienrbrt · 2023-06-03T06:18:33Z

store/pruning/manager.go

-	if err != nil {
-		return err
+	// Consider the snapshot height
+	pruneHeight := height - 1 - int64(m.opts.KeepRecent) // we should keep the current height at least


What if pruneHeight gets negative?

this will be checked in PruneStores when pruning in rootmulti

julienrbrt · 2023-06-03T06:19:42Z

store/go.mod

@@ -10,7 +10,7 @@ require (
 	github.com/cometbft/cometbft v0.38.0-alpha.2
 	github.com/cosmos/cosmos-db v1.0.0
 	github.com/cosmos/gogoproto v1.4.10
-	github.com/cosmos/iavl v0.21.0
+	github.com/cosmos/iavl v1.0.0-beta.1


nit, use v1.0.0-beta.2

julienrbrt

utACK, few nits

alexanderbez · 2023-06-05T14:34:48Z

Let's get @julienrbrt's suggestions in and we can merge. The conflicts should be trivial to resolve.

cool-develope requested a review from a team as a code owner March 28, 2023 12:49

cool-develope marked this pull request as draft March 28, 2023 12:49

github-actions bot added the C:Store label Mar 28, 2023

This comment has been minimized.

Sign in to view

kocubinski self-assigned this Mar 28, 2023

cool-develope marked this pull request as ready for review March 29, 2023 20:42

tac0turtle assigned JeancarloBarrios Mar 30, 2023

tac0turtle reviewed Mar 31, 2023

View reviewed changes

store/rootmulti/store_test.go Outdated Show resolved Hide resolved

tac0turtle assigned testinginprod Apr 6, 2023

alexanderbez approved these changes Apr 7, 2023

View reviewed changes

store/iavl/store.go Outdated Show resolved Hide resolved

julienrbrt mentioned this pull request Apr 7, 2023

build(deps): Bump github.com/cosmos/iavl from 0.21.0-beta.1 to 1.0.0-alpha.2 in /store #15745

Closed

tac0turtle previously requested changes Apr 8, 2023

View reviewed changes

cool-develope mentioned this pull request Apr 10, 2023

[Epic]: migration of the new store module #15769

Closed

elias-orijtech reviewed Apr 10, 2023

View reviewed changes

store/pruning/manager.go Show resolved Hide resolved

store/rootmulti/store_test.go Outdated Show resolved Hide resolved

cool-develope requested a review from elias-orijtech April 12, 2023 13:01

odeke-em reviewed Apr 25, 2023

View reviewed changes

store/pruning/manager.go Outdated Show resolved Hide resolved

store/pruning/manager.go Outdated Show resolved Hide resolved

tac0turtle added the S:blocked Status: Blocked label Apr 25, 2023

github-actions bot added C:CLI C:collections C:Confix Issues and PR related to Confix C:Cosmovisor Issues and PR related to Cosmovisor C:Hubl Tool: Hubl C:Keys Keybase, KMS and HSMs C:log C:orm C:Rosetta Issues and PR related to Rosetta C:Simulations C:x/auth labels Apr 26, 2023

cool-develope added 2 commits May 30, 2023 13:15

go mod tidy

0df84b7

Merge branch 'store/new_iavl' of github.com:cosmos/cosmos-sdk into st…

46c9b15

…ore/new_iavl

github-actions bot added C:Confix Issues and PR related to Confix C:Cosmovisor Issues and PR related to Cosmovisor C:Rosetta Issues and PR related to Rosetta labels May 30, 2023

go dep update

f562b91

cool-develope force-pushed the store/new_iavl branch from a187b06 to f562b91 Compare May 30, 2023 19:15

github-actions bot added C:x/circuit C:x/evidence C:x/feegrant C:x/nft C:x/upgrade labels May 30, 2023

Merge branch 'main' into store/new_iavl

add27df

tac0turtle reviewed May 30, 2023

View reviewed changes

tac0turtle approved these changes May 31, 2023

View reviewed changes

julienrbrt mentioned this pull request Jun 3, 2023

build(deps): Bump github.com/cosmos/iavl from 0.21.0 to 0.21.1 in /store #16411

Closed

julienrbrt reviewed Jun 3, 2023

View reviewed changes

julienrbrt approved these changes Jun 3, 2023

View reviewed changes

cool-develope added 3 commits June 6, 2023 12:39

suggestions

b34a13a

Merge branch 'main' into store/new_iavl

59c86db

go mod tidy

11365c0

github-actions bot added the C:Hubl Tool: Hubl label Jun 6, 2023

cool-develope added 2 commits June 6, 2023 12:55

fix the store test

58e7aa0

revert hubl and cosmovisor go.mod

c55a8ca

cool-develope added this pull request to the merge queue Jun 6, 2023

Merged via the queue into main with commit 3e18f40 Jun 6, 2023

cool-develope deleted the store/new_iavl branch June 6, 2023 19:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: update store module for new iavl #15568

feat: update store module for new iavl #15568

cool-develope commented Mar 28, 2023

This comment has been minimized.

tac0turtle left a comment

elias-orijtech left a comment

tac0turtle commented Apr 11, 2023

tac0turtle commented Apr 17, 2023 •

edited

Loading

odeke-em left a comment

tac0turtle May 30, 2023

cool-develope May 30, 2023

tac0turtle left a comment

tac0turtle commented Jun 3, 2023

julienrbrt Jun 3, 2023

julienrbrt Jun 3, 2023 •

edited

Loading

julienrbrt Jun 3, 2023

cool-develope Jun 6, 2023

julienrbrt Jun 3, 2023

julienrbrt left a comment

alexanderbez commented Jun 5, 2023

		TraverseStateChanges(startVersion, endVersion int64, fn func(version int64, changeSet *iavl.ChangeSet) error) error
		SaveChangeSet(changeSet *iavl.ChangeSet) (int64, error)

feat: update store module for new iavl #15568

feat: update store module for new iavl #15568

Conversation

cool-develope commented Mar 28, 2023

Description

Author Checklist

Reviewers Checklist

This comment has been minimized.

tac0turtle left a comment

Choose a reason for hiding this comment

elias-orijtech left a comment

Choose a reason for hiding this comment

tac0turtle commented Apr 11, 2023

tac0turtle commented Apr 17, 2023 • edited Loading

odeke-em left a comment

Choose a reason for hiding this comment

tac0turtle May 30, 2023

Choose a reason for hiding this comment

cool-develope May 30, 2023

Choose a reason for hiding this comment

tac0turtle left a comment

Choose a reason for hiding this comment

tac0turtle commented Jun 3, 2023

julienrbrt Jun 3, 2023

Choose a reason for hiding this comment

julienrbrt Jun 3, 2023 • edited Loading

Choose a reason for hiding this comment

julienrbrt Jun 3, 2023

Choose a reason for hiding this comment

cool-develope Jun 6, 2023

Choose a reason for hiding this comment

julienrbrt Jun 3, 2023

Choose a reason for hiding this comment

julienrbrt left a comment

Choose a reason for hiding this comment

alexanderbez commented Jun 5, 2023

tac0turtle commented Apr 17, 2023 •

edited

Loading

julienrbrt Jun 3, 2023 •

edited

Loading