Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update ADR-064 #15771

Merged
merged 9 commits into from
Apr 11, 2023
Merged

docs: update ADR-064 #15771

merged 9 commits into from
Apr 11, 2023

Conversation

alexanderbez
Copy link
Contributor

Description

As I've started Vote Extension implementation, I realized there is much simpler approach to vote extension state persistence, so I've documented this in the ADR.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@alexanderbez alexanderbez marked this pull request as ready for review April 10, 2023 14:18
@alexanderbez alexanderbez requested a review from a team as a code owner April 10, 2023 14:18
Copy link
Contributor

@samricotta samricotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small change but other than that looks good

docs/architecture/adr-064-abci-2.0.md Outdated Show resolved Hide resolved
Co-authored-by: samricotta <37125168+samricotta@users.noreply.github.com>
@alexanderbez alexanderbez merged commit 882b4ef into main Apr 11, 2023
@alexanderbez alexanderbez deleted the bez/adr-064-updates branch April 11, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants