Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: lint all modules even if one module fails #15819

Merged
merged 4 commits into from
Apr 12, 2023
Merged

ci: lint all modules even if one module fails #15819

merged 4 commits into from
Apr 12, 2023

Commits on Apr 12, 2023

  1. ci: lint all modules even if one module fails 

    The previous implementation stopped linting when it encountered its
first module that failed the linter.

Now, use a more idiomatic find|xargs pattern, which will run every
module and exit non-zero if any module fails to lint. This will speed up
the feedback cycle on CI in the event that multiple modules fail
linting.

Also change the script extension to .bash to make it clear to consumers
that this script requires bash, not sh; and make the script executable
so that CI can execute it directly instead of calling sh $script.
    @mark-rushakoff
    mark-rushakoff committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    7f87a7a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into mr/ci-lint-script-all-modules

    @mark-rushakoff
    mark-rushakoff committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    4ec80b9 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into mr/ci-lint-script-all-modules

    @mark-rushakoff
    mark-rushakoff committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    3a599c4 View commit details
    Browse the repository at this point in the history

  4. ci: add timestamp to lint announcement line 

    This makes it simpler to tell, at a glance, how long each package takes
to lint.
    @mark-rushakoff
    mark-rushakoff committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    224007f View commit details
    Browse the repository at this point in the history