Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make abci handshake graceful interruptible #16206

Merged
merged 1 commit into from
Jun 27, 2023
Merged

feat: make abci handshake graceful interruptible #16206

merged 1 commit into from
Jun 27, 2023

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented May 18, 2023 •
edited
Loading

Description

long running abci handshake can be used to profile block execution, but we need to make graceful shutdown works with it.

Closes: #16202

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

yihuang
yihuang commented May 18, 2023
View reviewed changes
go.mod Outdated Show resolved Hide resolved
yihuang
yihuang commented May 18, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Jun 18, 2023
@yihuang yihuang force-pushed the shutdown-handshake branch 2 times, most recently from 6402281 to a95b028 Compare June 21, 2023 09:02
@yihuang yihuang marked this pull request as ready for review June 21, 2023 09:03
@yihuang yihuang requested a review from a team as a code owner June 21, 2023 09:03
yihuang
yihuang commented Jun 21, 2023
View reviewed changes
go.mod Outdated
@@ -169,6 +169,7 @@ require (
replace (
// use cosmos fork of keyring
github.com/99designs/keyring => github.com/cosmos/keyring v1.2.0
github.com/cometbft/cometbft => github.com/yihuang/cometbft v0.38.0-alpha.1.0.20230621081303-4a1c1df1c182
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cometbft/cometbft#1011

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would honestly prefer to not pin against a commit hash and instead keep this PR open (and blocked) until merged and released in CometBFT. Otherwise LGTM!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

converted to draft again ;D

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's merged in cometbft, do we need to wait for a tag?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, personally I would prefer for them to include it in their next RC 🙏

@yihuang yihuang marked this pull request as draft June 21, 2023 15:22
@github-actions github-actions bot removed the Stale label Jun 22, 2023
@tac0turtle tac0turtle added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Jun 23, 2023
@tac0turtle
Copy link
Member

if we rebase this to main, we dont have to use the commit and can merge this. Thank you for being patient with us

@yihuang
feat: make abci handshake graceful interruptable
7234bb3 
long running abci handshake can be used to profile block execution,
but we need to make graceful shutdown works with it.
@yihuang yihuang marked this pull request as ready for review June 27, 2023 00:16
@yihuang
Copy link
Collaborator Author

yihuang commented Jun 27, 2023

if we rebase this to main, we dont have to use the commit and can merge this. Thank you for being patient with us

done

alexanderbez
alexanderbez approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alexanderbez alexanderbez added this pull request to the merge queue Jun 27, 2023
Merged via the queue into cosmos:main with commit 0a7bb06 Jun 27, 2023
45 of 47 checks passed
mergify bot pushed a commit that referenced this pull request Jun 27, 2023
@yihuang @mergify
feat: make abci handshake graceful interruptible (#16206)
44aaa60 
(cherry picked from commit 0a7bb06)
@mergify mergify bot mentioned this pull request Jun 27, 2023
Merged
@yihuang yihuang deleted the shutdown-handshake branch June 27, 2023 03:01
julienrbrt pushed a commit that referenced this pull request Jun 27, 2023
@mergify @yihuang
feat: make abci handshake graceful interruptible (backport #16206) (#…
a3d6632 
…16710)

Co-authored-by: yihuang <huang@crypto.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderbez alexanderbez alexanderbez approved these changes

@aaronc aaronc Awaiting requested review from aaronc

@JeancarloBarrios JeancarloBarrios Awaiting requested review from JeancarloBarrios

Assignees
No one assigned
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: abci handshake not gracefully shutdown
3 participants
@yihuang @tac0turtle @alexanderbez