ready-for-review: Gov modules enums marshalJSON to String #1627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sunnya97
commented
Jul 11, 2018
•
sunnya97
commented
- Updated all relevant documentation in docs
- Updated all code comments where relevant
- Wrote tests
- Updated CHANGELOG.md
- Updated Gaia/Examples
- Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
- Added appropriate labels to PR (ex. wip, ready-for-review, docs)
sunnya97
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1627 +/- ##
=========================================
Coverage ? 63.52%
=========================================
Files ? 122
Lines ? 6804
Branches ? 0
=========================================
Hits ? 4322
Misses ? 2235
Partials ? 247 |
cwgoes
approved these changes
Jul 12, 2018
| @@ -443,7 +443,7 @@ func TestSubmitProposal(t *testing.T) { | |||
|
|
|||
| // query proposal | |||
| proposal := getProposal(t, port, proposalID) | |||
| require.Equal(t, "Test", proposal.Title) | |||
| require.Equal(t, "Test", proposal.GetTitle()) | |||
There was a problem hiding this comment.
Do you want to check the string or check that the enum is correct? If you check the latter, the string format can change later without breaking these tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.