-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: custom get signers #16340
Merged
Merged
feat: custom get signers #16340
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
b20a1df
feat: get signers extension interface
aaronc badd826
WIP on defining custom get signers
aaronc 00eefcf
add DefineCustomGetSigners
aaronc d8290fe
make vulncheck fix
kocubinski 7a6bc71
add a custom signers test
kocubinski a275687
Merge branch 'main' of github.com:cosmos/cosmos-sdk into kocubinski/1…
kocubinski eefa8ae
Merge branch 'main' of github.com:cosmos/cosmos-sdk into kocubinski/1…
kocubinski ccdb3c0
remove replace
kocubinski bbfe4aa
still need replace for new annotation
kocubinski d8022de
no custom signers annotation
kocubinski a44534a
Merge branch 'main' of github.com:cosmos/cosmos-sdk into kocubinski/1…
kocubinski a1db0df
go mod tidy
kocubinski 3cac445
rm unused import
kocubinski c088db2
specify CustomGetSignersFuncs as inputs
kocubinski ee6fa69
fix x/tx test
kocubinski ea17470
need x/tx replace in x/nft/go.mod
kocubinski 5dce52b
works, but not how I want it to
kocubinski 49a9013
simplify and use invoker
kocubinski 2f4772e
remove signingContext validation from ProvideApp
kocubinski c6af01c
Merge branch 'main' into kocubinski/16112-custom-signers
kocubinski b01d359
changelog
kocubinski 49d6ccd
Merge branch 'kocubinski/16112-custom-signers' of github.com:cosmos/c…
kocubinski 66aedff
lint fixg
kocubinski 9e7a2bb
seems better
kocubinski de3816c
add comments
kocubinski eb72031
refactor moving files
kocubinski 9138f2c
adjust depinject test to fail during startup
kocubinski 410935f
fix comment
kocubinski bdbace3
Merge branch 'main' of github.com:cosmos/cosmos-sdk into kocubinski/1…
kocubinski 0d6f08f
disallow custom signer with proto annotation in Validate
kocubinski 6955df2
Merge branch 'main' of github.com:cosmos/cosmos-sdk into kocubinski/1…
kocubinski 5445754
fix validate logic
kocubinski e3dd1c3
linting fix
kocubinski 3947ced
Merge branch 'main' of github.com:cosmos/cosmos-sdk into kocubinski/1…
kocubinski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
adjust depinject test to fail during startup
- Loading branch information
commit 9138f2c88ddd39ebcf10d14f6f49197ed8c6911f
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, it will be useful if this could be displayed in the docs ref: #16294