-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add MigrationModuleManager to handle migration of upgrade module before other modules #16583
Merged
+127
−10
Merged
Changes from 1 commit
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
1e55c09
add WithConsensusParamsGetter for manager
mmsqe 5d513a3
test WithConsensusParamsGetter
mmsqe 3fcd4d6
test continuously call BeginBlock
mmsqe 34d47d1
add doc
mmsqe c21cff7
rm module name check
mmsqe ea9e96a
add change log
mmsqe 721fb8b
Update CHANGELOG.md
mmsqe 3158f6a
fix interface
mmsqe e54fc1a
fix lint
mmsqe 81038ec
Apply suggestions from code review
mmsqe 36a3944
Merge remote-tracking branch 'origin/main' into fix_cp
mmsqe 5e43e65
cleanup doc
mmsqe 9c3a25b
fix resolve
mmsqe 5bca160
Merge remote-tracking branch 'origin/main' into fix_cp
mmsqe 9f6994d
fix lint
mmsqe 591d7cf
add ck
mmsqe e3f80d6
Revert "add ck"
mmsqe 26e9624
add ConsensusParamsGetter interface
mmsqe 6e50d86
Merge remote-tracking branch 'origin/main' into fix_cp
mmsqe 42fc450
fix doc
mmsqe 59f4bef
Merge remote-tracking branch 'origin/main' into fix_cp
mmsqe 120cdae
handle upgrade 1st
mmsqe 74746c9
Update x/upgrade/module.go
mmsqe 7c812be
Merge remote-tracking branch 'origin/main' into fix_cp
mmsqe bbf4eef
fix doc
mmsqe ca99e59
replace WithConsensusParamsGetter with MigrationModuleManager
mmsqe 86bc9c0
fix test
mmsqe 1a1b3ce
Apply suggestions from code review
mmsqe 5400774
check nil
mmsqe 2b56da6
update doc
mmsqe 95c6ed9
add test
mmsqe 08a9279
Merge remote-tracking branch 'origin/main' into fix_cp
mmsqe 6ceebbf
update doc
mmsqe 71ea378
Apply suggestions from code review
mmsqe ff7f08d
Merge branch 'main' into fix_cp
julienrbrt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Apply suggestions from code review
- Loading branch information
commit 1a1b3cea9adc7c927b74a918da16ac8332e16ce8
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it going to be mandatory to set this? If so, we should add a nil check and return an error if not set or skip.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, it's not mandatory, added a check