chore: remove x/gov dependencies in x/distr #16587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sdk into ap/remove-distr-gov-deps
tac0turtle
reviewed
Jun 16, 2023
tac0turtle
reviewed
Jun 16, 2023
…dk into ap/remove-distr-gov-deps
tac0turtle
approved these changes
Jun 19, 2023
| @@ -32,6 +33,10 @@ func RegisterInterfaces(registry codectypes.InterfaceRegistry) { | |||
| (*Content)(nil), | |||
| &TextProposal{}, | |||
| ) | |||
| registry.RegisterImplementations( | |||
There was a problem hiding this comment.
are we fine with introducing this dependency?
There was a problem hiding this comment.
Gov already depends on distribution so it isn't a new dependency introduction.
julienrbrt
approved these changes
Jun 19, 2023
| @@ -17,4 +17,5 @@ var ( | |||
| ErrNoValidatorExists = errors.Register(ModuleName, 12, "validator does not exist") | |||
| ErrNoDelegationExists = errors.Register(ModuleName, 13, "delegation does not exist") | |||
| ErrInvalidProposalContent = errors.Register(ModuleName, 14, "invalid proposal content") | |||
| ErrInvalidSigner = errors.Register(ModuleName, 15, "expected authority account as only signer for proposal message") | |||
There was a problem hiding this comment.
Some existing ErrInvalidSigner have a different message, could we standardize them?
ruthishvitwit
added a commit
to ruthishvitwit/cosmos-sdk
that referenced
this pull request
Jul 5, 2023
Co-authored-by: Matt Kocubinski <mkocubinski@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #16469
ref: #13025
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change