Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(distribution)!: use collections for ValidatorHistoricalRewards state #16607

Merged
merged 25 commits into from
Jun 22, 2023
Merged

refactor(distribution)!: use collections for ValidatorHistoricalRewards state #16607

merged 25 commits into from
Jun 22, 2023

Conversation

testinginprod
Copy link
Contributor

@testinginprod testinginprod commented Jun 19, 2023 •
edited
Loading

Description

Closes: #16608

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@testinginprod testinginprod marked this pull request as ready for review June 19, 2023 13:56
@testinginprod testinginprod requested a review from a team as a code owner June 19, 2023 13:56
unknown unknown added 3 commits June 20, 2023 15:50
julienrbrt
julienrbrt approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

tests/go.mod Show resolved Hide resolved
x/distribution/types/keys.go Outdated Show resolved Hide resolved
@testinginprod testinginprod added this pull request to the merge queue Jun 22, 2023
Merged via the queue into main with commit 43d345d Jun 22, 2023
49 checks passed
@testinginprod testinginprod deleted the tip/distribution/coll_historical_rewards branch June 22, 2023 08:49
julienrbrt
julienrbrt reviewed Jun 22, 2023
View reviewed changes
x/evidence/go.sum
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looked weird, so I go mod tidy in this PR: #16616.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Goland EAP does weird things with go.sum I always revert them, this time I forgot. Sorry 🙏

@coderabbitai coderabbitai bot mentioned this pull request Apr 22, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@kocubinski kocubinski Awaiting requested review from kocubinski

Assignees
No one assigned
Labels
C:Simulations C:x/distribution distribution module related C:x/evidence
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor(distribution): use collections for ValidatorHistoricalRewards state
2 participants
@testinginprod @julienrbrt