Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(auth): make address codec pluggable #16621

Merged
merged 12 commits into from
Jun 28, 2023
Merged

feat(auth): make address codec pluggable #16621

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
db3f43c
codec pluggability
tac0turtle Jun 20, 2023
24a98c1
fix tests
tac0turtle Jun 20, 2023
bd243f0
address comment
tac0turtle Jun 20, 2023
1906515
address comment
tac0turtle Jun 20, 2023
b990cb7
fix tests
tac0turtle Jun 22, 2023
3b61500
fix lint
tac0turtle Jun 22, 2023
275192f
Merge branch 'main' into marko/auth_codec
tac0turtle Jun 27, 2023
1f40a62
fix build
tac0turtle Jun 27, 2023
0847ae4
refactor: address codec factory (#16726)
kocubinski Jun 27, 2023
a1fe9f1
fix linting
tac0turtle Jun 28, 2023
966b2d3
add changelog entry
tac0turtle Jun 28, 2023
0ad8e29
Merge branch 'main' into marko/auth_codec
tac0turtle Jun 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
address comment
  • Loading branch information
@tac0turtle
tac0turtle committed Jun 20, 2023
commit 1906515449c2bc73cc2cf4a42c62a76076782136
4 changes: 4 additions & 0 deletions x/auth/keeper/grpc_query.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,10 @@ func (s queryServer) Bech32Prefix(ctx context.Context, req *types.Bech32PrefixRe
return nil, err
}

if bech32Prefix == "" {
return &types.Bech32PrefixResponse{Bech32Prefix: "bech32 is not used on this chain"}, nil
}

return &types.Bech32PrefixResponse{Bech32Prefix: bech32Prefix}, nil
}

Expand Down
Loading