Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replace amino cosmos_dec_bytes annoation by scalar cosmos.Dec and add missing annotations #17000

Merged
merged 3 commits into from
Jul 14, 2023
Merged

chore: replace amino cosmos_dec_bytes annoation by scalar cosmos.Dec and add missing annotations #17000

merged 3 commits into from
Jul 14, 2023

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Jul 14, 2023 •
edited
Loading

Description

Context: #16985 (comment)

Introducing the new annotation cosmos_dec_bytes wasn't needed. This cleans it up.
Added as well the scalar cosmos.Dec annotation where it was missing (gogoproto.customtype specified but no scalar annotations).
I'll need these for #16985 when I figure out to marshal them properly.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt requested a review from a team as a code owner July 14, 2023 12:08
@julienrbrt julienrbrt changed the title chore: replace amino cosmos_dec_bytes annoation by scalarcosmos.Dec chore: replace amino cosmos_dec_bytes annoation by scalar cosmos.Dec Jul 14, 2023
julienrbrt
julienrbrt commented Jul 14, 2023
View reviewed changes
tests/go.mod
@@ -216,3 +216,6 @@ replace (
// TODO Remove it: https://github.com/cosmos/cosmos-sdk/issues/10409
github.com/gin-gonic/gin => github.com/gin-gonic/gin v1.9.1
)

// TODO to be removed after API tag
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll be tagging a new api after this PR.

@julienrbrt julienrbrt mentioned this pull request Jul 14, 2023
Merged
19 tasks
@julienrbrt julienrbrt changed the title chore: replace amino cosmos_dec_bytes annoation by scalar cosmos.Dec chore: replace amino cosmos_dec_bytes annoation by scalar cosmos.Dec and add missing annotations Jul 14, 2023
@julienrbrt julienrbrt added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Jul 14, 2023
alexanderbez
alexanderbez approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@julienrbrt julienrbrt added this pull request to the merge queue Jul 14, 2023
Merged via the queue into main with commit 7ed04f7 Jul 14, 2023
53 checks passed
@julienrbrt julienrbrt deleted the julien/remove-uncessary-annotation branch July 14, 2023 18:12
mergify bot pushed a commit that referenced this pull request Jul 14, 2023
@julienrbrt @mergify
chore: replace amino cosmos_dec_bytes annoation by scalar `cosmos.D…
c0c5f95 
…ec` and add missing annotations (#17000)

(cherry picked from commit 7ed04f7)

# Conflicts:
#	tests/go.sum
@mergify mergify bot mentioned this pull request Jul 14, 2023
Merged
julienrbrt added a commit that referenced this pull request Jul 14, 2023
@mergify @julienrbrt
chore: replace amino cosmos_dec_bytes annoation by scalar `cosmos.D…
562723c 
…ec` and add missing annotations (backport #17000) (#17002)

Co-authored-by: Julien Robert <julien@rbrt.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderbez alexanderbez alexanderbez approved these changes

@samricotta samricotta Awaiting requested review from samricotta

Assignees
No one assigned
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:x/gov C:x/mint C:x/slashing C:x/staking C:x/tx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julienrbrt @alexanderbez