Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: reword upgrading.md and verify match with repo #17262

Merged
merged 7 commits into from
Aug 7, 2023

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Aug 2, 2023

Description

While upgrading chain-minimal to v0.50.0-beta I am checking the UPGRADING.md and verifying what is missing.
Additionally, I am verifying we have applied properly our own UPGRADING.md thorough the codebase.

ref: cosmosregistry/chain-minimal#72
closes: #16487


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Aug 2, 2023
UPGRADING.md Show resolved Hide resolved
@julienrbrt julienrbrt marked this pull request as ready for review August 2, 2023 12:24
@julienrbrt julienrbrt requested a review from a team as a code owner August 2, 2023 12:24
@julienrbrt
Copy link
Member Author

@egaxhaj, I have noticed that ADR-38 isn't really matching the current implementation (#14207) (especially the baseapp implementation https://docs.cosmos.network/main/architecture/adr-038-state-listening#baseapp-registration).
Would you be up for updating it?

@julienrbrt julienrbrt changed the title chore: reword UPGRADING.md and verify match with repo refactor: reword upgrading.md and verify match with repo Aug 2, 2023
@julienrbrt julienrbrt added this pull request to the merge queue Aug 7, 2023
Merged via the queue into main with commit bdb7387 Aug 7, 2023
48 checks passed
@julienrbrt julienrbrt deleted the julien/refactor-upgrading-md branch August 7, 2023 15:56
mergify bot pushed a commit that referenced this pull request Aug 7, 2023
(cherry picked from commit bdb7387)

# Conflicts:
#	CHANGELOG.md
#	UPGRADING.md
#	x/genutil/client/cli/commands.go
julienrbrt added a commit that referenced this pull request Aug 7, 2023
@julienrbrt julienrbrt mentioned this pull request Aug 10, 2023
52 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:CLI C:x/consensus C:x/genutil genutil module issues Type: ADR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

notes for docs from upgrading ibc
3 participants