Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(log): custom marshaller produce invalid data #17532

Merged
merged 7 commits into from
Aug 25, 2023

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Aug 24, 2023

Description

The custom marshaller for Stringer (case fmt.Stringer) introduced at #17205 (comment) produces invalid results for some log event.

Step to reproduce

$ simd start --log_level="*:info"
...
zerolog: could not write event: failed to unmarshal event: invalid character '\n' in string literal
zerolog: could not write event: failed to unmarshal event: invalid character '\n' in string literal
zerolog: could not write event: failed to unmarshal event: invalid character '\n' in string literal
zerolog: could not write event: failed to unmarshal event: invalid character '\n' in string literal
zerolog: could not write event: failed to unmarshal event: invalid character '\n' in string literal
zerolog: could not write event: failed to unmarshal event: invalid character '\n' in string literal
zerolog: could not write event: failed to unmarshal event: invalid character '\n' in string litera
...

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions bot added C:Hubl Tool: Hubl C:log labels Aug 24, 2023
@julienrbrt julienrbrt added the backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release label Aug 25, 2023
@julienrbrt julienrbrt marked this pull request as ready for review August 25, 2023 10:34
@julienrbrt julienrbrt requested review from a team as code owners August 25, 2023 10:34
@github-actions github-actions bot removed the C:Hubl Tool: Hubl label Aug 25, 2023
@@ -22,6 +22,10 @@ Each entry must include the Github issue reference in the following format:

## [Unreleased]

## [v1.2.1](https://github.com/cosmos/cosmos-sdk/releases/tag/log/v1.2.1) - 2023-08-25
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tagging v1.2.1 once this is merged.

@julienrbrt julienrbrt added this pull request to the merge queue Aug 25, 2023
Merged via the queue into main with commit 03fb7da Aug 25, 2023
47 of 50 checks passed
@julienrbrt julienrbrt deleted the julien/custom-marshal-log branch August 25, 2023 13:18
mergify bot pushed a commit that referenced this pull request Aug 25, 2023
(cherry picked from commit 03fb7da)

# Conflicts:
#	log/CHANGELOG.md
#	log/logger.go
julienrbrt added a commit that referenced this pull request Aug 25, 2023
Co-authored-by: Julien Robert <julien@rbrt.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.50.x PR scheduled for inclusion in the v0.50's next stable release C:log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants