Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: comet_info to struct #17689

Merged
merged 3 commits into from
Sep 12, 2023
Merged

refactor!: comet_info to struct #17689

merged 3 commits into from
Sep 12, 2023

Conversation

tac0turtle
Copy link
Member

@tac0turtle tac0turtle commented Sep 12, 2023

Description

this pr pulls out core changes to a separate pr and makes the entire comet core a struct


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • run make lint and make test
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@tac0turtle tac0turtle marked this pull request as ready for review September 12, 2023 09:53
@tac0turtle tac0turtle requested a review from a team as a code owner September 12, 2023 09:53
Copy link
Contributor

@testinginprod testinginprod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I generally agree with the direction, Comet is a specialised service (works only when consensus engine is Comet) so we don't need more abstractions, there's always going to be one Comet service implementation.

@julienrbrt julienrbrt changed the title refactor: comet_info to struct refactor!: comet_info to struct Sep 12, 2023
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a breaking change changelog to core?

@tac0turtle tac0turtle added this pull request to the merge queue Sep 12, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 12, 2023
@tac0turtle tac0turtle added this pull request to the merge queue Sep 12, 2023
Merged via the queue into main with commit 71dc28a Sep 12, 2023
48 of 49 checks passed
@tac0turtle tac0turtle deleted the marko/cometInfo_struct_ branch September 12, 2023 10:57
@coderabbitai coderabbitai bot mentioned this pull request May 3, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants