-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix typo #18545
chore: fix typo #18545
Conversation
WalkthroughWalkthroughThe changes across various files in the Cosmos SDK primarily involve comment updates to deprecate the use of 'tips' in transaction protocols, the addition of version information to NFT-related RPC methods, and reorganization of import statements in Go source files. The reorganization includes removing redundant imports and adding specific paths for certain packages, likely for improved clarity and maintainability of the codebase. Changes
TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- proto/cosmos/tx/v1beta1/tx.proto (1 hunks)
Files skipped from review due to trivial changes (1)
- proto/cosmos/tx/v1beta1/tx.proto
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pre-approving, pending julien's comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as julien's comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to filter (9)
- api/cosmos/nft/v1beta1/query_grpc.pb.go
- testutil/testdata/query.pb.go
- testutil/testdata/testdata.pb.go
- testutil/testdata/testpb/query_grpc.pb.go
- testutil/testdata/testpb/tx_grpc.pb.go
- testutil/testdata/tx.pb.go
- testutil/testdata/unknonwnproto.pb.go
- types/tx/tx.pb.go
- x/nft/query.pb.go
Files selected for processing (7)
- api/cosmos/nft/v1beta1/query.pulsar.go (10 hunks)
- api/cosmos/tx/v1beta1/tx.pulsar.go (1 hunks)
- proto/cosmos/tx/v1beta1/tx.proto (1 hunks)
- testutil/testdata/testpb/query.pulsar.go (1 hunks)
- testutil/testdata/testpb/testdata.pulsar.go (1 hunks)
- testutil/testdata/testpb/tx.pulsar.go (1 hunks)
- testutil/testdata/testpb/unknonwnproto.pulsar.go (1 hunks)
Files skipped from review due to trivial changes (5)
- api/cosmos/nft/v1beta1/query.pulsar.go
- api/cosmos/tx/v1beta1/tx.pulsar.go
- proto/cosmos/tx/v1beta1/tx.proto
- testutil/testdata/testpb/query.pulsar.go
- testutil/testdata/testpb/testdata.pulsar.go
Additional comments: 2
testutil/testdata/testpb/tx.pulsar.go (1)
- 4-15: The import statements have been reorganized, and unused imports have been removed. Verify that the removal of imports for
io
,reflect
, andsync
does not affect any other parts of the code that may have been using these packages. Also, ensure that the addition ofgithub.com/cosmos/cosmos-proto/runtime
is necessary and used elsewhere in the code.testutil/testdata/testpb/unknonwnproto.pulsar.go (1)
- 5-18:
The reorganization of import statements follows best practices for clarity and maintainability.
Summary by CodeRabbit
Documentation
Refactor
Bug Fixes