Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(server): in-place testnet creator #19280

Merged
merged 16 commits into from
Feb 12, 2024
Merged

feat(server): in-place testnet creator #19280

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
6518cc1
upstream testnetify
czarcas7ic Jan 29, 2024
684ca39
remove leaking resource
czarcas7ic Jan 29, 2024
37e66ae
spelling changes
czarcas7ic Jan 29, 2024
cc49b1f
lint
czarcas7ic Jan 29, 2024
b295d92
gci imports
czarcas7ic Jan 29, 2024
a9f0a01
add changelog entry
czarcas7ic Jan 29, 2024
f0bcce0
lint
czarcas7ic Jan 29, 2024
087a29f
Merge branch 'main' into adam/testnetify-upstream
czarcas7ic Jan 29, 2024
bad2345
add upgrade handler trigger flag
czarcas7ic Feb 1, 2024
56f6542
Merge branch 'main' into adam/testnetify-upstream
czarcas7ic Feb 1, 2024
4e191a1
adds a skip-confirmation flag
czarcas7ic Feb 7, 2024
ec35474
Merge branch 'main' into adam/testnetify-upstream
czarcas7ic Feb 7, 2024
7d0e17e
fix halt height edge case
czarcas7ic Feb 9, 2024
66355b3
remove nolint dogsled
czarcas7ic Feb 9, 2024
25bee82
modify app genesis, store, then continue prev logic
czarcas7ic Feb 9, 2024
0c0b744
Merge branch 'main' into adam/testnetify-upstream
czarcas7ic Feb 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
gci imports
  • Loading branch information
@czarcas7ic
czarcas7ic committed Jan 29, 2024
commit b295d92de7fc9967ea7326640c821a385bc3dc4a
19 changes: 8 additions & 11 deletions server/start.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,8 @@
"strings"
"time"

"github.com/hashicorp/go-metrics"
"github.com/spf13/cobra"
"github.com/spf13/pflag"
"golang.org/x/sync/errgroup"
"google.golang.org/grpc"
"google.golang.org/grpc/credentials/insecure"

"cosmossdk.io/log"
pruningtypes "cosmossdk.io/store/pruning/types"
"github.com/cometbft/cometbft/abci/server"
cmtcmd "github.com/cometbft/cometbft/cmd/cometbft/commands"
cmtcfg "github.com/cometbft/cometbft/config"
Expand All @@ -34,10 +29,6 @@
"github.com/cometbft/cometbft/store"
cmttypes "github.com/cometbft/cometbft/types"
dbm "github.com/cosmos/cosmos-db"

"cosmossdk.io/log"
pruningtypes "cosmossdk.io/store/pruning/types"

"github.com/cosmos/cosmos-sdk/client"
"github.com/cosmos/cosmos-sdk/codec"
"github.com/cosmos/cosmos-sdk/server/api"
Expand All @@ -49,6 +40,12 @@
"github.com/cosmos/cosmos-sdk/types/mempool"
"github.com/cosmos/cosmos-sdk/version"
genutiltypes "github.com/cosmos/cosmos-sdk/x/genutil/types"
"github.com/hashicorp/go-metrics"
"github.com/spf13/cobra"
"github.com/spf13/pflag"
"golang.org/x/sync/errgroup"
"google.golang.org/grpc"
"google.golang.org/grpc/credentials/insecure"
)

const (
Expand Down Expand Up @@ -776,7 +773,7 @@
Height: state.LastBlockHeight,
Round: 0,
BlockID: state.LastBlockID,
Timestamp: time.Now(),

Check warning

Code scanning / CodeQL

Calling the system time Warning

Calling the system time may be a possible source of non-determinism
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, this is the only validator in the set, set setting the timestamp to local time is a non issue.

ValidatorAddress: validatorAddress,
ValidatorIndex: 0,
Signature: []byte{},
Expand Down
Loading