fix: nested multisig signatures using CLI #20438
Conversation
WalkthroughThe recent updates primarily address the handling and signing of nested multisig accounts in the Cosmos SDK. Key improvements include adding functions for marshaling and unmarshaling Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
This comment has been minimized.
This comment has been minimized.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review Details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files selected for processing (4)
- crypto/keys/multisig/multisig.go (1 hunks)
- x/auth/client/cli/tx_multisign.go (3 hunks)
- x/auth/client/cli/tx_sign.go (5 hunks)
- x/auth/client/tx.go (1 hunks)
Additional Context Used
Path-based Instructions (4)
crypto/keys/multisig/multisig.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/auth/client/tx.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/auth/client/cli/tx_multisign.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.x/auth/client/cli/tx_sign.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
Additional comments not posted (5)
crypto/keys/multisig/multisig.go (1)
151-154: Ensure that theMarshalmethod is defined and accessible within the context whereMarshalAminois used.x/auth/client/cli/tx_multisign.go (2)
60-60: The addition of theflagSkipSignatureVerificationflag is appropriate for enabling users to skip signature verification when necessary.
Line range hint
113-167: The modifications to handle the skipping of signature verification based on theflagSkipSignatureVerificationare implemented correctly.x/auth/client/cli/tx_sign.go (2)
278-304: The implementation ofisMultisigSignerfunction is correct and effectively handles the checking of signers in nested multisig structures.
229-262: The modifications to support multisig signing, including error handling and signature verification, are implemented correctly.
crypto/keys/multisig/multisig.go
Outdated
| // UnmarshalAmino overrides amino binary marshaling. | ||
| func (m *LegacyAminoPubKey) UnmarshalAmino(bz []byte) error { | ||
| return m.Unmarshal(bz) | ||
| } |
There was a problem hiding this comment.
Tip
Codebase Verification
The Unmarshal method is not defined in the LegacyAminoPubKey struct, nor does it embed any other structs or interfaces that provide this method. This will cause the UnmarshalAmino method to fail at runtime.
LegacyAminoPubKeystruct definition:crypto/keys/multisig/keys.pb.go:31api/cosmos/crypto/multisig/keys.pulsar.go:576
Please ensure that the Unmarshal method is implemented for the LegacyAminoPubKey struct.
Analysis chain
Ensure that the Unmarshal method is defined and accessible within the context where UnmarshalAmino is used.
Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify the existence of the `Unmarshal` method used in `UnmarshalAmino`.
# Test: Search for the `Unmarshal` method definition. Expect: At least one definition.
ast-grep --lang go --pattern $'func (m *LegacyAminoPubKey) Unmarshal(bz []byte) error { $$$ }'
Length of output: 95
Script:
#!/bin/bash
# Description: Verify the existence of the `Unmarshal` method used in `UnmarshalAmino`.
# Test 1: Search for any `Unmarshal` method definitions in the entire codebase.
ast-grep --lang go --pattern $'func ($_ $_) Unmarshal(bz []byte) error { $$$ }'
# Test 2: Inspect the `LegacyAminoPubKey` struct for any embedded structs or implemented interfaces.
ast-grep --lang go --pattern $'type LegacyAminoPubKey struct { $$$ }'
Length of output: 1733
| @@ -109,6 +110,10 @@ func makeMultiSignCmd() func(cmd *cobra.Command, args []string) (err error) { | |||
| return err | |||
| } | |||
|
|
|||
| // avoid signature verification if the sender of the tx is different than | |||
| // the multisig key (useful for nested multisigs). | |||
| skipSigVerify, _ := cmd.Flags().GetBool(flagSkipSignatureVerification) | |||
There was a problem hiding this comment.
We should describe this flag somewhere in the docs.
crypto/keys/multisig/multisig.go
Outdated
| @@ -169,6 +169,9 @@ func packPubKeys(pubKeys []cryptotypes.PubKey) ([]*types.Any, error) { | |||
| return nil, err | |||
| } | |||
| anyPubKeys[i] = any | |||
|
|
|||
| // sets the compat.aminoBz value | |||
| anyPubKeys[i].UnmarshalAmino(pubKeys[i].Bytes()) | |||
There was a problem hiding this comment.
This was the necessary fix to allow nested anys
There was a problem hiding this comment.
Actionable comments posted: 2
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files selected for processing (2)
- client/keys/output_test.go (1 hunks)
- crypto/keys/multisig/multisig.go (1 hunks)
Additional context used
Path-based instructions (2)
client/keys/output_test.go (2)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
Pattern
**/*_test.go: "Assess the unit test code assessing sufficient code coverage for the changes associated in the pull request"crypto/keys/multisig/multisig.go (1)
Pattern
**/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.
golangci-lint
crypto/keys/multisig/multisig.go
174-174: Error return value of
(*github.com/cosmos/gogoproto/types/any.Any).UnmarshalAminois not checked (errcheck)
GitHub Check: golangci-lint
crypto/keys/multisig/multisig.go
[failure] 174-174:
Error return value of(*github.com/cosmos/gogoproto/types/any.Any).UnmarshalAminois not checked (errcheck)
| // TestBech32KeysOutputNestedMsig tests that the output of a nested multisig key is correct | ||
| func TestBech32KeysOutputNestedMsig(t *testing.T) { | ||
| sk := secp256k1.PrivKey{Key: []byte{154, 49, 3, 117, 55, 232, 249, 20, 205, 216, 102, 7, 136, 72, 177, 2, 131, 202, 234, 81, 31, 208, 46, 244, 179, 192, 167, 163, 142, 117, 246, 13}} | ||
| tmpKey := sk.PubKey() | ||
| nestedMultiSig := kmultisig.NewLegacyAminoPubKey(1, []types.PubKey{tmpKey}) | ||
| multisigPk := kmultisig.NewLegacyAminoPubKey(2, []types.PubKey{tmpKey, nestedMultiSig}) | ||
| k, err := keyring.NewMultiRecord("multisig", multisigPk) | ||
| require.NotNil(t, k) | ||
| require.NoError(t, err) | ||
|
|
||
| pubKey, err := k.GetPubKey() | ||
| require.NoError(t, err) | ||
|
|
||
| accAddr := sdk.AccAddress(pubKey.Address()) | ||
| expectedOutput, err := NewKeyOutput(k.Name, k.GetType(), accAddr, multisigPk, addresscodec.NewBech32Codec("cosmos")) | ||
| require.NoError(t, err) | ||
|
|
||
| out, err := MkAccKeyOutput(k, addresscodec.NewBech32Codec("cosmos")) | ||
| require.NoError(t, err) | ||
|
|
||
| require.Equal(t, expectedOutput, out) | ||
| require.Equal(t, "{Name:multisig Type:multi Address:cosmos1nffp6v2j7wva4y4975exlrv8x5vh39axxt3swz PubKey:{\"@type\":\"/cosmos.crypto.multisig.LegacyAminoPubKey\",\"threshold\":2,\"public_keys\":[{\"@type\":\"/cosmos.crypto.secp256k1.PubKey\",\"key\":\"AurroA7jvfPd1AadmmOvWM2rJSwipXfRf8yD6pLbA2DJ\"},{\"@type\":\"/cosmos.crypto.multisig.LegacyAminoPubKey\",\"threshold\":1,\"public_keys\":[{\"@type\":\"/cosmos.crypto.secp256k1.PubKey\",\"key\":\"AurroA7jvfPd1AadmmOvWM2rJSwipXfRf8yD6pLbA2DJ\"}]}]} Mnemonic:}", fmt.Sprintf("%+v", out)) | ||
| } |
There was a problem hiding this comment.
The test TestBech32KeysOutputNestedMsig appears comprehensive and correctly tests the output of a nested multisig key. However, consider adding more assertions to verify the structure of the nested multisig key in more detail, such as checking individual public keys within the nested structure.
crypto/keys/multisig/multisig.go
Outdated
| @@ -169,6 +169,9 @@ | |||
| return nil, err | |||
| } | |||
| anyPubKeys[i] = any | |||
|
|
|||
| // sets the compat.aminoBz value | |||
| anyPubKeys[i].UnmarshalAmino(pubKeys[i].Bytes()) | |||
There was a problem hiding this comment.
The error return value of UnmarshalAmino is not checked. It's important to handle potential errors to avoid runtime panics or unexpected behavior.
- anyPubKeys[i].UnmarshalAmino(pubKeys[i].Bytes())
+ if err := anyPubKeys[i].UnmarshalAmino(pubKeys[i].Bytes()); err != nil {
+ return nil, err
+ }Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| anyPubKeys[i].UnmarshalAmino(pubKeys[i].Bytes()) | |
| if err := anyPubKeys[i].UnmarshalAmino(pubKeys[i].Bytes()); err != nil { | |
| return nil, err | |
| } |
Tools
golangci-lint
174-174: Error return value of
(*github.com/cosmos/gogoproto/types/any.Any).UnmarshalAminois not checked (errcheck)
GitHub Check: golangci-lint
[failure] 174-174:
Error return value of(*github.com/cosmos/gogoproto/types/any.Any).UnmarshalAminois not checked (errcheck)
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…/fix-nested-ms-main
| @@ -57,6 +57,7 @@ The SIGN_MODE_DIRECT sign mode is not supported.' | |||
| Args: cobra.MinimumNArgs(3), | |||
| } | |||
|
|
|||
| cmd.Flags().Bool(flagSkipSignatureVerification, false, "Skip signature verification") | |||
There was a problem hiding this comment.
can we add this to some docs somewhere? easy to get lost in the immense amount of code
There was a problem hiding this comment.
Added docs and changelog 💪
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files selected for processing (2)
- x/auth/README.md (1 hunks)
- x/tx/CHANGELOG.md (1 hunks)
Additional context used
Path-based instructions (2)
x/tx/CHANGELOG.md (1)
Pattern
**/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"x/auth/README.md (1)
Pattern
**/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
LanguageTool
x/tx/CHANGELOG.md
[grammar] ~157-~157: When ‘32-bit’ is used as a modifier, it is usually spelled with a hyphen. (BIT_HYPHEN)
Context: ...mos-sdk/pull/15849) Fix int64 usage for 32 bit platforms. ## v0.5.1 ### Features * ...x/auth/README.md
[uncategorized] ~40-~40: Possible missing comma found. (AI_HYDRA_LEO_MISSING_COMMA)
Context: ...s to perform actions on behalf of other accounts and enables a granter to grant authoriz...
[style] ~92-~92: Consider a shorter alternative to avoid wordiness. (IN_ORDER_TO_PREMIUM)
Context: ...nt struct conforming to the interface - in order to write the account to the store, the acc...
[style] ~148-~148: The phrase ‘have the ability to’ might be wordy. Consider using “can”. (HAS_THE_ABILITY_TO)
Context: ...verTx`, as CometBFT proposers presently have the ability to include in their proposed block transac...
[uncategorized] ~154-~154: Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION)
Context: ...lowing order: *SetUpContextDecorator: Sets theGasMeterin theContextan...
[uncategorized] ~156-~156: Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION)
Context: ...ed. *RejectExtensionOptionsDecorator: Rejects all extension options which can...
[uncategorized] ~158-~158: Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION)
Context: ...f transactions. *MempoolFeeDecorator: Checks if thetxfee is above local m...
[uncategorized] ~160-~160: Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION)
Context: ...gCheckTx. *ValidateBasicDecorator: Callstx.ValidateBasicand returns an...
[uncategorized] ~162-~162: Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION)
Context: ...nil error. *TxTimeoutHeightDecorator: Check for atxheight timeout. * `Va...
[uncategorized] ~164-~164: Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION)
Context: ...ight timeout. *ValidateMemoDecorator: Validatestxmemo with application pa...
[uncategorized] ~166-~166: Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION)
Context: ...il error. *ConsumeGasTxSizeDecorator: Consumes gas proportional to thetxs...
[uncategorized] ~168-~168: Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION)
Context: ...tion parameters. *DeductFeeDecorator: Deducts theFeeAmountfrom first sign...
[uncategorized] ~170-~170: Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION)
Context: ...granter account. *SetPubKeyDecorator: Sets the pubkey from atx's signers t...
[uncategorized] ~172-~172: Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION)
Context: ... context. *ValidateSigCountDecorator: Validates the number of signatures in `...
[uncategorized] ~174-~174: Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION)
Context: ...-parameters. *SigGasConsumeDecorator: Consumes parameter-defined amount of ga...
[uncategorized] ~176-~176: Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION)
Context: ...ecorator. *SigVerificationDecorator`: Verifies all signatures are valid. This...
[uncategorized] ~178-~178: Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION)
Context: ...orator. *IncrementSequenceDecorator`: Increments the account sequence for eac...
[style] ~186-~186: Although a hyphen is possible, it is not necessary in a compound modifier in which the first word is an adverb that ends in ‘ly’. (HYPHENATED_LY_ADVERB_ADJECTIVE)
Context: ... ### Account Keeper Presently only one fully-permissioned account keeper is exposed, which has th...
[uncategorized] ~252-~252: Did you mean “its” (the possessive pronoun)? (ITS_PREMIUM)
Context: ... allow users to query for an account by it's address. ```bash simd query auth accou...
[style] ~403-~403: Consider using a more formal alternative. (MORE_INFO)
Context: ... Use directly the--helpflag to get more information about thetxcommand. ```bash simd t...
[uncategorized] ~436-~436: Possible missing preposition found. (AI_HYDRA_LEO_MISSING_OF)
Context: ...igned.json ``` The result is multiples signed transactions. For combining the signed ...
[grammar] ~436-~436: Please verify that the plural noun “transactions” is in agreement with the quantifier “one”. Did you mean to use the singular form? (ONE_PLURAL)
Context: ... combining the signed transactions into one transactions, use the--appendflag. More informa...
[uncategorized] ~507-~507: Did you mean “its” (the possessive pronoun)? (ITS_PREMIUM)
Context: ... allow users to query for an account by it's address. ```bash cosmos.auth.v1beta1.Q...
[uncategorized] ~690-~690: Did you mean “its” (the possessive pronoun)? (ITS_PREMIUM)
Context: ... allow users to query for an account by it's address. ```bash /cosmos/auth/v1beta1/...
Markdownlint
x/tx/CHANGELOG.md
142-142: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
143-143: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
150-150: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
151-151: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
152-152: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
153-153: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentationx/auth/README.md
21-21: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
23-23: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
26-26: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
29-29: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
30-30: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
31-31: Expected: 2; Actual: 4 (MD007, ul-indent)
Unordered list indentation
432-432: Expected: 0 or 2; Actual: 1 (MD009, no-trailing-spaces)
Trailing spaces
71-71: Column: 20 (MD010, no-hard-tabs)
Hard tabs
103-103: Column: 1 (MD010, no-hard-tabs)
Hard tabs
105-105: Column: 1 (MD010, no-hard-tabs)
Hard tabs
106-106: Column: 1 (MD010, no-hard-tabs)
Hard tabs
108-108: Column: 1 (MD010, no-hard-tabs)
Hard tabs
109-109: Column: 1 (MD010, no-hard-tabs)
Hard tabs
111-111: Column: 1 (MD010, no-hard-tabs)
Hard tabs
112-112: Column: 1 (MD010, no-hard-tabs)
Hard tabs
114-114: Column: 1 (MD010, no-hard-tabs)
Hard tabs
115-115: Column: 1 (MD010, no-hard-tabs)
Hard tabs
117-117: Column: 1 (MD010, no-hard-tabs)
Hard tabs
118-118: Column: 1 (MD010, no-hard-tabs)
Hard tabs
192-192: Column: 1 (MD010, no-hard-tabs)
Hard tabs
193-193: Column: 1 (MD010, no-hard-tabs)
Hard tabs
195-195: Column: 1 (MD010, no-hard-tabs)
Hard tabs
196-196: Column: 1 (MD010, no-hard-tabs)
Hard tabs
198-198: Column: 1 (MD010, no-hard-tabs)
Hard tabs
199-199: Column: 1 (MD010, no-hard-tabs)
Hard tabs
201-201: Column: 1 (MD010, no-hard-tabs)
Hard tabs
202-202: Column: 1 (MD010, no-hard-tabs)
Hard tabs
204-204: Column: 1 (MD010, no-hard-tabs)
Hard tabs
205-205: Column: 1 (MD010, no-hard-tabs)
Hard tabs
207-207: Column: 1 (MD010, no-hard-tabs)
Hard tabs
208-208: Column: 1 (MD010, no-hard-tabs)
Hard tabs
210-210: Column: 1 (MD010, no-hard-tabs)
Hard tabs
211-211: Column: 1 (MD010, no-hard-tabs)
Hard tabs
213-213: Column: 1 (MD010, no-hard-tabs)
Hard tabs
214-214: Column: 1 (MD010, no-hard-tabs)
Hard tabs
216-216: Column: 1 (MD010, no-hard-tabs)
Hard tabs
217-217: Column: 1 (MD010, no-hard-tabs)
Hard tabs
219-219: Column: 1 (MD010, no-hard-tabs)
Hard tabs
220-220: Column: 1 (MD010, no-hard-tabs)
Hard tabs
500-500: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
Additional comments not posted (2)
x/tx/CHANGELOG.md (1)
38-38: The changelog entry is clear and concise, correctly summarizing the addition of the--skip-signature-verificationflag.x/auth/README.md (1)
450-465: The documentation clearly explains the process and necessity of using the--skip-signature-verificationflag for nested multisig transactions, including detailed CLI command examples.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Files selected for processing (1)
- crypto/keys/multisig/multisig.go (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- crypto/keys/multisig/multisig.go
| @@ -33,6 +33,10 @@ Since v0.13.0, x/tx follows Cosmos SDK semver: https://github.com/cosmos/cosmos- | |||
|
|
|||
| ## [Unreleased] | |||
|
|
|||
| ### Improvements | |||
There was a problem hiding this comment.
changelog is misplaced, this is a x/auth thing
|
@Mergifyio backport release/v0.50.x |
✅ Backports have been created
|
(cherry picked from commit b9ca318) # Conflicts: # x/auth/client/tx.go # x/tx/CHANGELOG.md
* main: feat(tx): port simappv2 changes (#20648) build(deps): Bump github.com/spf13/cobra from 1.8.0 to 1.8.1 (#20682) chore(proto): fix comments (#20679) (serverv2/cometbft) Commands support both json and yaml output (#20670) fix(x/staking,x/auth): regenerate mock to fix test (#20684) docs: ADR 074: Msg v2 (#20618) fix: nested multisig signatures using CLI (#20438) chore: fix spelling errors (#20674) fix: align Dockerfile for build-push-action (#20672) fix: avoid build fail when make localnet-build-env (#20671) build(deps): Bump bufbuild/buf-setup-action from 1.32.2 to 1.33.0 (#20669) chore: make function comment match function names (#20666) chore(consensus): add cometInfo to consensus (#20615) chore: fix typos (#20662) fix: Properly parse json in the wait-tx command. (#20631) fix(sims): check before sending RotateConsPubKey (#20659) test(types/address): add unit tests for the file types/address.go (#20237)
* build(deps): Bump github.com/cosmos/gogoproto from 1.4.12 to 1.5.0 (cosmos#20567) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * refactor(x/authz,x/feegrant): provide updated keeper in depinject (cosmos#20590) * docs: Update high level overview and introduction (backport cosmos#20535) (cosmos#20627) Co-authored-by: samricotta <37125168+samricotta@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * fix: Properly parse json in the wait-tx command. (backport cosmos#20631) (cosmos#20660) Co-authored-by: Daniel Wedul <github@wedul.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * docs: remove Ineffective code block (backport cosmos#20703) (cosmos#20711) * feat(client): Add flag & reading mnemonic from file (backport cosmos#20690) (cosmos#20712) Co-authored-by: Hieu Vu <72878483+hieuvubk@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> * fix: nested multisig signatures using CLI (backport cosmos#20438) (cosmos#20692) Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Facundo <facundomedica@gmail.com> * feat(client/v2): get keyring from context (backport cosmos#19646) (cosmos#20727) Co-authored-by: Julien Robert <julien@rbrt.fr> * docs(x/group): orm codespace comment (backport cosmos#20749) (cosmos#20751) * feat: parse home flag earlier (backport cosmos#20771) (cosmos#20777) Co-authored-by: Julien Robert <julien@rbrt.fr> * build(deps): Bump github.com/cometbft/cometbft from 0.38.7 to 0.38.8 (cosmos#20805) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * build(deps): Bump github.com/cometbft/cometbft from 0.38.8 to 0.38.9 (cosmos#20836) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * fix(simulation): fix the problem of `validator set is empty after InitGenesis` in simulation test (backport cosmos#18196) (cosmos#20897) Co-authored-by: Chenqun Lu <luchenqun@qq.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * fix(simulation): Fix all problems `make test-sim-custom-genesis-fast` for simulation test. (backport cosmos#17911) (cosmos#20909) Co-authored-by: Chenqun Lu <luchenqun@qq.com> Co-authored-by: Julien Robert <julien@rbrt.fr> * chore: prepare v0.50.8 (cosmos#20910) --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Julien Robert <julien@rbrt.fr> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: samricotta <37125168+samricotta@users.noreply.github.com> Co-authored-by: marbar3778 <marbar3778@yahoo.com> Co-authored-by: Daniel Wedul <github@wedul.com> Co-authored-by: Hieu Vu <72878483+hieuvubk@users.noreply.github.com> Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com> Co-authored-by: Facundo <facundomedica@gmail.com> Co-authored-by: Chenqun Lu <luchenqun@qq.com>
Description
Closes: #20355 and #20382
This PR enables the CLI to sign nested multisig txs, by modifying how the signer check is done and adding a flag to disable signature verification. Also #20404 was included here.
It was tested with 4 common accounts (alice, bob, carol and dave) forming 3 multisigs: ms1 (alice, bob), ms2 (bob, carol) and ms3 (bob, dave, ms1, ms2). Then a tx from ms3 is created and signed by all the participants.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
Summary by CodeRabbit
New Features
--skip-signature-verificationflag for multisig transactions, allowing users to skip signature verification.Bug Fixes
packPubKeysfunction to correctly unmarshal public keys.Tests
Documentation
--skip-signature-verificationflag.