-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
R4R: Allow --from to be a name or an address #2073
Merged
Merged
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
ae91972
Allow --from to be a name or an address
mslipper cd1cb15
Post-rebase fixes
mslipper b904fd5
Updates from code review
mslipper ac4bc2a
Updates from code review
mslipper 81df6f4
Updates from code review
mslipper 9611469
Merge remote-tracking branch 'upstream/develop' into issue-1735
mslipper 1ee14d5
Fix merge artifacts
mslipper a24beae
Merge remote-tracking branch 'upstream/develop' into issue-1735
mslipper e026164
Fix merge conflicts
mslipper 77f958f
Fix integration tests
mslipper 3a6ac88
Add back GetFromName() check broken during merge
mslipper d89664b
Merge remote-tracking branch 'upstream/develop' into issue-1735
mslipper d4ad0ff
Merge remote-tracking branch 'upstream/develop' into issue-1735
mslipper ed7d43c
Code review updates
mslipper ac3325c
Fix failing test
mslipper 0799aa8
Updates from code review
mslipper File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Updates from code review
- Loading branch information
commit ac4bc2aaabf794f571113abad4628b22e00dc4c9
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where did this come from? I don't think we should be returning pointers to contexts. Is this from the original simulation PR @alessio ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nvm, I don't see this on
develop
. I don't thinklookupTxCtx
is appropriate here. SeeprepareTxContext
here. I think it should be analogous to that.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was trying to reduce the cyclomatic complexity of the function above - I can revert.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ohhh no, we should definitely reduce cyclomatic complexity! We just should:
That's all :-)