Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: replace the cosmos-db.DB interface with core/store interface #21450

Merged
merged 8 commits into from
Aug 30, 2024
Merged

feat: replace the cosmos-db.DB interface with core/store interface #21450

merged 8 commits into from
Aug 30, 2024

Conversation

cool-develope
Copy link
Contributor

@cool-develope cool-develope commented Aug 29, 2024 •
edited by coderabbitai bot
Loading

Description

It is part of removing the cosmos-db dependency. It has replaced all dbm.DB usage with a core/store interface.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

  • New Features

    • Enhanced database handling capabilities by integrating support for batch operations through the new corestore.KVStoreWithBatch interface.

  • Bug Fixes

    • Improved performance and functionality related to state management and database interactions.

  • Chores

    • Upgraded dependencies to the latest version of the Cosmos DB library for improved features and bug fixes.

@cool-develope cool-develope requested a review from a team as a code owner August 29, 2024 02:00
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 29, 2024 •
edited
Loading

Warning

Rate limit exceeded

@cool-develope has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 3 minutes and 50 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 9f1b36b and 2388c23.

Walkthrough

Walkthrough

The changes involve a significant update to the database interface across multiple files in the codebase, transitioning from dbm.DB to corestore.KVStoreWithBatch. This modification affects constructors, methods, and test cases, ensuring that the application utilizes a more efficient and capable database structure that supports batch operations. Additionally, the dependency on the github.com/cosmos/cosmos-db package has been updated to a newer version across various modules.

Changes

File(s) Change Summary
baseapp/..., client/..., simapp/... Changed parameter and return types from dbm.DB to corestore.KVStoreWithBatch in various functions and methods.
client/v2/go.mod, go.mod, simapp/go.mod, x/... Updated dependency version for github.com/cosmos/cosmos-db from v1.0.2 to v1.0.3-0.20240829004618-717cba019b33.
docs/... Updated documentation to reflect changes in function signatures and parameter types from dbm.DB to corestore.KVStoreWithBatch.
orm/..., server/... Modified struct fields and method signatures to use corestore.KVStoreWithBatch instead of dbm.DB.

Sequence Diagram(s)

sequenceDiagram
    participant A as Application
    participant DB as Database (old: dbm.DB)
    participant NewDB as Database (new: corestore.KVStoreWithBatch)

    A->>DB: Initialize with dbm.DB
    DB-->>A: Return DB instance

    A->>DB: Perform database operations
    DB-->>A: Return results

    A->>NewDB: Initialize with corestore.KVStoreWithBatch
    NewDB-->>A: Return new DB instance

    A->>NewDB: Perform database operations
    NewDB-->>A: Return results
Loading

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Aug 29, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

Outside diff range, codebase verification and nitpick comments (8)
server/types/app.go (1)

87-87: Update AppExporter Signature in x/genutil/v2/types.go.

The AppExporter type in x/genutil/v2/types.go does not match the updated signature with corestore.KVStoreWithBatch. Please ensure that all occurrences are updated accordingly.

  • File: x/genutil/v2/types.go
    • Action: Update the AppExporter type signature to include db corestore.KVStoreWithBatch.
Analysis chain

Type Signature Update: AppExporter.

The AppExporter type signature has been updated to use corestore.KVStoreWithBatch instead of dbm.DB. Ensure that all implementations of AppExporter are updated to match this new signature.

Run the following script to verify the function usage:

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify all implementations of `AppExporter` match the new signature.

# Test: Search for the function usage. Expect: Only occurrences of the new signature.
rg --type go -A 5 $'AppExporter'

Length of output: 7336

store/iavl/tree.go (1)

37-37: Update Iterator Method Implementations to Return corestore.Iterator.

The Iterator method's return type has been updated to corestore.Iterator, but there are still instances where it returns idb.Iterator. Please update these implementations to match the new signature.

  • store/v2/db/wrapper.go: The Iterator method still returns idb.Iterator.
Analysis chain

Type Signature Update: Iterator Method.

The Iterator method's return type has been updated to corestore.Iterator instead of idb.Iterator. Ensure that all implementations of this method are updated to match this new signature.

Run the following script to verify the method usage:

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify all implementations of the `Iterator` method match the new signature.

# Test: Search for the method usage. Expect: Only occurrences of the new signature.
rg --type go -A 5 $'Iterator'

Length of output: 379079

testutil/sims/simulation_helpers.go (1)

113-113: Type Mismatch Detected in PrintStats Function Call

The PrintStats function expects a parameter of type *dbm.GoLevelDB, but it is being called with a corestore.KVStoreWithBatch type in simapp/sim_bench_test.go. This mismatch could lead to runtime errors if not addressed.

  • File: simapp/sim_bench_test.go
  • Line: simtestutil.PrintStats(db)

Please ensure that the types are compatible or adjust the function call accordingly.

Analysis chain

LGTM! But verify the function usage in the codebase.

The function is correctly implemented. However, ensure that all function calls to PrintStats match the new parameter type.

The code changes are approved.

Run the following script to verify the function usage:

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify all function calls to `PrintStats` match the new parameter type.

# Test: Search for the function usage. Expect: Only occurrences of the new parameter type.
rg --type go -A 5 $'PrintStats'

Length of output: 948

Script:

#!/bin/bash
# Description: Verify the type of `db` in `sim_bench_test.go` to ensure it matches `*dbm.GoLevelDB`.

# Test: Search for the declaration and assignment of `db` in `sim_bench_test.go`.
rg --type go -A 5 'db := ' simapp/sim_bench_test.go

Length of output: 53

Script:

#!/bin/bash
# Description: Search for all occurrences of `db` in `sim_bench_test.go` to determine its type.

# Test: Search for all occurrences of `db` in `sim_bench_test.go`.
rg --type go 'db' simapp/sim_bench_test.go

Length of output: 371

Script:

#!/bin/bash
# Description: Search for the definition of `SetupSimulation` to determine the return type of `db`.

# Test: Search for the function definition of `SetupSimulation`.
rg --type go 'func SetupSimulation'

Length of output: 228

simapp/app_di.go (1)

116-116: Type Mismatch in NewSimApp Function Calls

The db argument in the calls to NewSimApp is not of the correct type. The function signature requires corestore.KVStoreWithBatch, but the current implementation uses dbm.NewMemDB(), which does not match the expected type. Please update the calls to ensure compatibility with the new function signature.

  • Files with Incorrect db Type:
    • simapp/app_test.go
    • simapp/test_helpers.go
    • tests/e2e/genutil/export_test.go
    • tests/integration/store/rootmulti/rollback_test.go
Analysis chain

LGTM! But verify the function usage in the codebase.

The function is correctly updated to use the new corestore.KVStoreWithBatch type. However, ensure that all function calls to NewSimApp match the new signature.

The code changes are approved.

Run the following script to verify the function usage:

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify all function calls to `NewSimApp` match the new signature.

# Test: Search for the function usage. Expect: Only occurrences of the new signature.
rg --type go -A 5 $'NewSimApp'

Length of output: 11294

Script:

#!/bin/bash
# Description: Verify the type of the `db` argument in each call to `NewSimApp`.

# Find all instances of `NewSimApp` and check the type of the `db` argument.
rg --type go -A 5 'NewSimApp' | grep -E 'NewSimApp\('

Length of output: 2038

Script:

#!/bin/bash
# Description: Verify the type of `db` in files where `NewSimApp` is called.

# Search for the declaration or assignment of `db` in relevant files.
rg --type go 'db\s*[:=]' tests/integration/store/rootmulti/rollback_test.go tests/e2e/genutil/export_test.go simapp/app_test.go simapp/test_helpers.go simapp/simd/cmd/commands.go simapp/simd/cmd/root.go

Length of output: 541

store/types/store.go (1)

182-182: Update Method Usage to Match New Signature

The method MountStoreWithDB has been updated to use corestore.KVStoreWithBatch, but several instances in the codebase still use the old signature with db. Please update the following files to ensure consistency with the new method signature:

  • x/upgrade/types/storeloader_test.go
  • x/params/types/subspace_test.go
  • x/group/keeper/invariants_test.go
  • testutil/sims/simulation_helpers_test.go
  • testutil/context.go
  • testutil/integration/router.go
  • store/rootmulti/proof_test.go
  • store/rootmulti/snapshot_test.go
  • store/rootmulti/store_test.go
  • server/mock/store_test.go
  • baseapp/baseapp.go
  • baseapp/baseapp_test.go
Analysis chain

LGTM! But verify the method usage in the codebase.

The method signature has been correctly updated to use corestore.KVStoreWithBatch. However, ensure that all method calls to MountStoreWithDB match the new signature.

The code changes are approved.

Run the following script to verify the method usage:

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify all method calls to `MountStoreWithDB` match the new signature.

# Test: Search for the method usage. Expect: Only occurrences of the new signature.
rg --type go -A 5 $'MountStoreWithDB'

Length of output: 14141

store/cachekv/store_test.go (3)

539-539: Function usage mismatch in assertIterateDomainCheck calls

The function assertIterateDomainCheck has been updated to include corestore.KVStoreWithBatch in its signature. However, the calls to this function in store/cachekv/store_test.go do not match the updated signature, as they are missing the mem argument. Please update these calls to include the necessary argument.

  • File: store/cachekv/store_test.go
  • Lines with issues: Calls to assertIterateDomainCheck without the mem argument.
Analysis chain

LGTM! But verify the function usage in the codebase.

The function signature has been correctly updated to use corestore.KVStoreWithBatch. However, ensure that all function calls to assertIterateDomainCheck match the new signature.

The code changes are approved.

Run the following script to verify the function usage:

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify all function calls to `assertIterateDomainCheck` match the new signature.

# Test: Search for the function usage. Expect: Only occurrences of the new signature.
rg --type go -A 5 $'assertIterateDomainCheck'

Length of output: 1729

573-573: Update function calls to match the new signature

The function assertIterateDomainCompare has been updated to accept corestore.KVStoreWithBatch as the third parameter. However, the test cases in store/cachekv/store_test.go still pass truth initialized with dbm.NewMemDB(), which may not be compatible with the new expected type. Please update the test cases to ensure they align with the new function signature.

  • File: store/cachekv/store_test.go
  • Lines: Calls to assertIterateDomainCompare passing truth as an argument.
Analysis chain

LGTM! But verify the function usage in the codebase.

The function signature has been correctly updated to use corestore.KVStoreWithBatch. However, ensure that all function calls to assertIterateDomainCompare match the new signature.

The code changes are approved.

Run the following script to verify the function usage:

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify all function calls to `assertIterateDomainCompare` match the new signature.

# Test: Search for the function usage. Expect: Only occurrences of the new signature.
rg --type go -A 5 $'assertIterateDomainCompare'

Length of output: 1337

610-610: Type Mismatch in deleteRange Function Calls

The deleteRange function expects the third argument to be of type corestore.KVStoreWithBatch, but the variable truth is initialized with dbm.NewMemDB(), which likely does not implement corestore.KVStoreWithBatch. This discrepancy needs to be addressed to ensure the function is used correctly.

  • File: store/cachekv/store_test.go
  • Lines with truth initialization: Look for truth := dbm.NewMemDB()

Please update the initialization of truth to match the expected type.

Analysis chain

LGTM! But verify the function usage in the codebase.

The function signature has been correctly updated to use corestore.KVStoreWithBatch. However, ensure that all function calls to deleteRange match the new signature.

The code changes are approved.

Run the following script to verify the function usage:

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify all function calls to `deleteRange` match the new signature.

# Test: Search for the function usage. Expect: Only occurrences of the new signature.
rg --type go -A 5 $'deleteRange'

Length of output: 1932

Script:

#!/bin/bash
# Description: Find the declaration of `truth` in `store/cachekv/store_test.go` to verify its type.

# Search for the declaration of `truth` to confirm its type.
rg --type go 'truth\s*:=' store/cachekv/store_test.go

Length of output: 130

Review details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 89ec787 and 4950027.

Files ignored due to path filters (35)
  • client/v2/go.sum is excluded by !**/*.sum
  • go.sum is excluded by !**/*.sum
  • orm/go.sum is excluded by !**/*.sum
  • runtime/v2/go.sum is excluded by !**/*.sum
  • server/v2/cometbft/go.sum is excluded by !**/*.sum
  • server/v2/go.sum is excluded by !**/*.sum
  • simapp/go.sum is excluded by !**/*.sum
  • simapp/v2/go.sum is excluded by !**/*.sum
  • store/go.sum is excluded by !**/*.sum
  • tests/go.sum is excluded by !**/*.sum
  • tests/systemtests/go.sum is excluded by !**/*.sum
  • tools/confix/go.sum is excluded by !**/*.sum
  • tools/cosmovisor/go.sum is excluded by !**/*.sum
  • tools/hubl/go.sum is excluded by !**/*.sum
  • x/accounts/defaults/lockup/go.sum is excluded by !**/*.sum
  • x/accounts/defaults/multisig/go.sum is excluded by !**/*.sum
  • x/accounts/go.sum is excluded by !**/*.sum
  • x/auth/go.sum is excluded by !**/*.sum
  • x/authz/go.sum is excluded by !**/*.sum
  • x/bank/go.sum is excluded by !**/*.sum
  • x/circuit/go.sum is excluded by !**/*.sum
  • x/consensus/go.sum is excluded by !**/*.sum
  • x/distribution/go.sum is excluded by !**/*.sum
  • x/epochs/go.sum is excluded by !**/*.sum
  • x/evidence/go.sum is excluded by !**/*.sum
  • x/feegrant/go.sum is excluded by !**/*.sum
  • x/gov/go.sum is excluded by !**/*.sum
  • x/group/go.sum is excluded by !**/*.sum
  • x/mint/go.sum is excluded by !**/*.sum
  • x/nft/go.sum is excluded by !**/*.sum
  • x/params/go.sum is excluded by !**/*.sum
  • x/protocolpool/go.sum is excluded by !**/*.sum
  • x/slashing/go.sum is excluded by !**/*.sum
  • x/staking/go.sum is excluded by !**/*.sum
  • x/upgrade/go.sum is excluded by !**/*.sum
Files selected for processing (78)
  • baseapp/baseapp.go (3 hunks)
  • baseapp/baseapp_test.go (3 hunks)
  • baseapp/options.go (2 hunks)
  • client/pruning/main.go (2 hunks)
  • client/snapshot/restore.go (2 hunks)
  • client/v2/go.mod (1 hunks)
  • docs/architecture/adr-038-state-listening.md (1 hunks)
  • docs/learn/advanced/00-baseapp.md (1 hunks)
  • docs/learn/advanced/04-store.md (1 hunks)
  • go.mod (1 hunks)
  • orm/go.mod (1 hunks)
  • orm/internal/testkv/db.go (3 hunks)
  • orm/model/ormdb/module_test.go (2 hunks)
  • runtime/builder.go (2 hunks)
  • runtime/v2/go.mod (1 hunks)
  • server/README.md (1 hunks)
  • server/mock/store.go (2 hunks)
  • server/start.go (3 hunks)
  • server/types/app.go (3 hunks)
  • server/util.go (2 hunks)
  • server/v2/cometbft/go.mod (1 hunks)
  • server/v2/go.mod (1 hunks)
  • simapp/app.go (1 hunks)
  • simapp/app_di.go (1 hunks)
  • simapp/go.mod (1 hunks)
  • simapp/gomod2nix.toml (16 hunks)
  • simapp/sim_test.go (1 hunks)
  • simapp/simd/cmd/commands.go (2 hunks)
  • simapp/v2/go.mod (1 hunks)
  • store/cache/cache_test.go (5 hunks)
  • store/cachekv/store_test.go (7 hunks)
  • store/cachemulti/store.go (2 hunks)
  • store/dbadapter/store.go (2 hunks)
  • store/go.mod (1 hunks)
  • store/iavl/store.go (2 hunks)
  • store/iavl/store_test.go (11 hunks)
  • store/iavl/tree.go (2 hunks)
  • store/iavl/tree_test.go (1 hunks)
  • store/prefix/store_test.go (2 hunks)
  • store/pruning/manager.go (6 hunks)
  • store/rootmulti/dbadapter.go (1 hunks)
  • store/rootmulti/snapshot_test.go (4 hunks)
  • store/rootmulti/store.go (8 hunks)
  • store/rootmulti/store_test.go (12 hunks)
  • store/store.go (1 hunks)
  • store/types/store.go (2 hunks)
  • tests/e2e/genutil/export_test.go (1 hunks)
  • tests/go.mod (1 hunks)
  • tests/systemtests/go.mod (1 hunks)
  • testutil/sims/app_helpers.go (2 hunks)
  • testutil/sims/simulation_helpers.go (3 hunks)
  • testutils/sims/runner.go (6 hunks)
  • tools/confix/go.mod (1 hunks)
  • tools/cosmovisor/go.mod (1 hunks)
  • tools/hubl/go.mod (1 hunks)
  • x/accounts/defaults/lockup/go.mod (1 hunks)
  • x/accounts/defaults/multisig/go.mod (1 hunks)
  • x/accounts/go.mod (1 hunks)
  • x/auth/go.mod (1 hunks)
  • x/authz/go.mod (1 hunks)
  • x/bank/go.mod (1 hunks)
  • x/circuit/go.mod (1 hunks)
  • x/consensus/go.mod (1 hunks)
  • x/distribution/go.mod (1 hunks)
  • x/epochs/go.mod (1 hunks)
  • x/evidence/go.mod (1 hunks)
  • x/feegrant/go.mod (1 hunks)
  • x/genutil/client/cli/export_test.go (2 hunks)
  • x/gov/go.mod (1 hunks)
  • x/group/go.mod (1 hunks)
  • x/mint/go.mod (1 hunks)
  • x/nft/go.mod (1 hunks)
  • x/params/go.mod (1 hunks)
  • x/protocolpool/go.mod (1 hunks)
  • x/slashing/go.mod (1 hunks)
  • x/staking/go.mod (1 hunks)
  • x/upgrade/go.mod (1 hunks)
  • x/upgrade/types/storeloader_test.go (2 hunks)
Files skipped from review due to trivial changes (2)
  • store/cache/cache_test.go
  • store/prefix/store_test.go
Additional context used
Path-based instructions (42)
store/store.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

store/iavl/tree_test.go (2)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

Pattern **/*_test.go: "Assess the unit test code assessing sufficient code coverage for the changes associated in the pull request"

store/rootmulti/dbadapter.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

client/snapshot/restore.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

store/dbadapter/store.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

orm/internal/testkv/db.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

server/types/app.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

store/iavl/tree.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

runtime/builder.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

server/README.md (1)

Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"

client/pruning/main.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

x/upgrade/types/storeloader_test.go (2)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

Pattern **/*_test.go: "Assess the unit test code assessing sufficient code coverage for the changes associated in the pull request"

simapp/simd/cmd/commands.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

store/cachemulti/store.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

server/mock/store.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

store/pruning/manager.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

tests/e2e/genutil/export_test.go (3)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

Pattern tests/**/*: "Assess the integration and e2e test code assessing sufficient code coverage for the changes associated in the pull request"

Pattern **/*_test.go: "Assess the unit test code assessing sufficient code coverage for the changes associated in the pull request"

testutil/sims/simulation_helpers.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

tests/systemtests/go.mod (1)

Pattern tests/**/*: "Assess the integration and e2e test code assessing sufficient code coverage for the changes associated in the pull request"

testutils/sims/runner.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

x/genutil/client/cli/export_test.go (2)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

Pattern **/*_test.go: "Assess the unit test code assessing sufficient code coverage for the changes associated in the pull request"

simapp/sim_test.go (2)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

Pattern **/*_test.go: "Assess the unit test code assessing sufficient code coverage for the changes associated in the pull request"

store/rootmulti/snapshot_test.go (2)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

Pattern **/*_test.go: "Assess the unit test code assessing sufficient code coverage for the changes associated in the pull request"

testutil/sims/app_helpers.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

baseapp/options.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

orm/model/ormdb/module_test.go (2)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

Pattern **/*_test.go: "Assess the unit test code assessing sufficient code coverage for the changes associated in the pull request"

simapp/app_di.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

tests/go.mod (1)

Pattern tests/**/*: "Assess the integration and e2e test code assessing sufficient code coverage for the changes associated in the pull request"

store/iavl/store.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

docs/learn/advanced/04-store.md (1)

Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"

store/types/store.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

store/cachekv/store_test.go (2)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

Pattern **/*_test.go: "Assess the unit test code assessing sufficient code coverage for the changes associated in the pull request"

server/util.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

store/iavl/store_test.go (2)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

Pattern **/*_test.go: "Assess the unit test code assessing sufficient code coverage for the changes associated in the pull request"

docs/architecture/adr-038-state-listening.md (1)

Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"

baseapp/baseapp_test.go (2)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

Pattern **/*_test.go: "Assess the unit test code assessing sufficient code coverage for the changes associated in the pull request"

store/rootmulti/store_test.go (2)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

Pattern **/*_test.go: "Assess the unit test code assessing sufficient code coverage for the changes associated in the pull request"

simapp/app.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

server/start.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

store/rootmulti/store.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

baseapp/baseapp.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

docs/learn/advanced/00-baseapp.md (1)

Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"

GitHub Check: tests (03)
store/iavl/store.go

[failure] 54-54:
cannot use db (variable of type store.KVStoreWithBatch) as "github.com/cosmos/iavl/db".DB value in argument to iavl.NewMutableTree: store.KVStoreWithBatch does not implement "github.com/cosmos/iavl/db".DB (wrong type for method Iterator)

GitHub Check: tests (02)
store/iavl/store.go

[failure] 54-54:
cannot use db (variable of type store.KVStoreWithBatch) as "github.com/cosmos/iavl/db".DB value in argument to iavl.NewMutableTree: store.KVStoreWithBatch does not implement "github.com/cosmos/iavl/db".DB (wrong type for method Iterator)

GitHub Check: tests (01)
store/iavl/store.go

[failure] 54-54:
cannot use db (variable of type store.KVStoreWithBatch) as "github.com/cosmos/iavl/db".DB value in argument to iavl.NewMutableTree: store.KVStoreWithBatch does not implement "github.com/cosmos/iavl/db".DB (wrong type for method Iterator)

GitHub Check: tests (00)
store/iavl/store.go

[failure] 54-54:
cannot use db (variable of type store.KVStoreWithBatch) as "github.com/cosmos/iavl/db".DB value in argument to iavl.NewMutableTree: store.KVStoreWithBatch does not implement "github.com/cosmos/iavl/db".DB (wrong type for method Iterator)

Additional comments not posted (154)
store/store.go (2)

4-4: LGTM!

The import statement is correctly updated to include corestore.

The code changes are approved.

11-12: LGTM! But verify the function usage in the codebase.

The function is correctly updated to use the new interface. However, ensure that all function calls to NewCommitMultiStore match the new signature.

The code changes are approved.

Run the following script to verify the function usage:

Verification successful

Verification Successful: Function Usage Matches New Signature

All instances of NewCommitMultiStore in the codebase correctly use the updated function signature with corestore.KVStoreWithBatch, types.Logger, and metrics.StoreMetrics. No discrepancies were found.

  • Verified files include:
    • x/group/keeper/invariants_test.go
    • x/params/types/subspace_test.go
    • testutil/integration/router.go
    • testutil/context.go
    • baseapp/baseapp.go
    • baseapp/regression_test.go
Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify all function calls to `NewCommitMultiStore` match the new signature.

# Test: Search for the function usage. Expect: Only occurrences of the new signature.
rg --type go -A 5 $'NewCommitMultiStore'

Length of output: 4292

store/iavl/tree_test.go (1)

15-15: LGTM!

The function is correctly updated to simplify the instantiation of ImmutableTree. The overall functionality of the test remains intact.

The code changes are approved.

store/rootmulti/dbadapter.go (2)

20-20: LGTM!

The comment is correctly updated to reflect the new interface.

The code changes are approved.

21-22: LGTM!

The type declaration is correctly updated to implement the new interface.

The code changes are approved.

client/snapshot/restore.go (2)

10-10: LGTM!

The import statement for corestore is correctly added.

The code changes are approved.

53-55: LGTM! But verify the return type compatibility.

The function is correctly updated to return the new type. However, ensure that the dbm.NewDB function returns a compatible type.

The code changes are approved.

Run the following script to verify the return type compatibility:

Verification successful

Return type compatibility verified.

The dbm.NewDB function returns corestore.KVStoreWithBatch, confirming compatibility with the updated return type in the openDB function.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify that the `dbm.NewDB` function returns a compatible type.

# Test: Search for the `dbm.NewDB` function definition. Expect: The return type should be compatible with `corestore.KVStoreWithBatch`.
rg --type go -A 5 $'func NewDB'

Length of output: 354

store/dbadapter/store.go (2)

6-6: LGTM!

The import statement for corestore is correctly added.

The code changes are approved.

12-14: LGTM! But verify the method compatibility.

The struct is correctly updated to use the new type. However, ensure that all methods of the Store struct are compatible with the new type.

The code changes are approved.

Run the following script to verify the method compatibility:

orm/internal/testkv/db.go (2)

3-3: LGTM!

The import statement for store is correctly added.

The code changes are approved.

8-8: LGTM! But verify the method compatibility.

The struct is correctly updated to use the new type. However, ensure that all methods of the TestStore struct are compatible with the new type.

The code changes are approved.

Run the following script to verify the method compatibility:

Verification successful

No methods found for TestStore struct.

The TestStore struct is defined in orm/internal/testkv/db.go, but no methods were found associated with it. Therefore, there are no compatibility issues to verify with the new type store.KVStoreWithBatch. The update to the struct is correct.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify that all methods of the `TestStore` struct are compatible with the new type.

# Test: Search for the methods of the `TestStore` struct. Expect: The methods should be compatible with `store.KVStoreWithBatch`.
rg --type go -A 5 $'func (ts TestStore)'

Length of output: 41

Script:

#!/bin/bash
# Search for the definition of the `TestStore` struct to understand its context.
rg --type go 'type TestStore struct'

# Search for any methods associated with `TestStore` to verify compatibility with `store.KVStoreWithBatch`.
rg --type go 'func (ts TestStore)'

Length of output: 125

orm/go.mod (1)

10-10: Dependency Update: Verify Compatibility and Changes.

The github.com/cosmos/cosmos-db package version has been updated from v1.0.2 to v1.0.3-0.20240829004618-717cba019b33. Ensure that this version is compatible with the rest of the codebase and review the changelog for any breaking changes or new features.

Check the changelog and compatibility of the new version.

server/types/app.go (2)

11-11: Import Addition: Ensure Correct Usage.

The corestore package from cosmossdk.io/core/store has been imported. Ensure that this package is correctly used and integrated within the file.

Check the usage of the corestore package in the file.

68-68: Type Signature Update: AppCreator.

The AppCreator type signature has been updated to use corestore.KVStoreWithBatch instead of dbm.DB. Ensure that all implementations of AppCreator are updated to match this new signature.

Run the following script to verify the function usage:

store/iavl/tree.go (1)

7-8: Import Addition: Ensure Correct Usage.

The corestore package from cosmossdk.io/core/store has been imported. Ensure that this package is correctly used and integrated within the file.

Check the usage of the corestore package in the file.

runtime/builder.go (1)

37-37: LGTM!

The change in the db parameter type from dbm.DB to corestore.KVStoreWithBatch is appropriate for the new interface. The method correctly initializes and configures the BaseApp instance.

The code changes are approved.

store/go.mod (3)

6-6: LGTM!

The addition of the cosmossdk.io/core dependency is appropriate to support the new corestore.KVStoreWithBatch interface.

The code changes are approved.

12-12: LGTM!

The version update for github.com/cosmos/cosmos-db from v1.0.2 to v1.0.3-0.20240829004618-717cba019b33 is appropriate and likely includes necessary bug fixes or new features.

The code changes are approved.

15-15: LGTM!

The version update for github.com/cosmos/iavl from v1.2.1-0.20240725141113-7adc688cf179 to v1.0.0-beta.1.0.20240813194616-eb5078efcf9e is appropriate and likely includes necessary bug fixes or new features.

The code changes are approved.

server/README.md (1)

77-77: LGTM!

The change in the db parameter type from dbm.DB to corestore.KVStoreWithBatch is appropriate for the new interface. The function correctly initializes and returns a new SimApp instance.

The code changes are approved.

client/pruning/main.go (2)

12-12: LGTM!

The import statement for corestore is correctly added.

The code changes are approved.

111-113: LGTM! But verify the function usage in the codebase.

The function is correctly implemented. However, ensure that all function calls to openDB match the new return type.

The code changes are approved.

Run the following script to verify the function usage:

Verification successful

Function usage is compatible with the new return type.

The openDB function's return type corestore.KVStoreWithBatch is correctly handled in the codebase. The db variable is used consistently with this type in the relevant files.

  • client/pruning/main.go
  • client/snapshot/export.go
  • client/snapshot/restore.go
Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify all function calls to `openDB` match the new return type.

# Test: Search for the function usage. Expect: Only occurrences of the new return type.
rg --type go -A 5 $'openDB'

Length of output: 1926

Script:

#!/bin/bash
# Description: Verify the usage of the `db` variable to ensure compatibility with `corestore.KVStoreWithBatch`.

# Search for the usage of the `db` variable in the relevant files.
rg --type go -A 5 'db,' client/snapshot/restore.go client/snapshot/export.go client/pruning/main.go

Length of output: 1885

x/upgrade/types/storeloader_test.go (2)

Line range hint 23-36: LGTM! But verify the function usage in the codebase.

The function is correctly implemented. However, ensure that all function calls to initStore match the new parameter type.

The code changes are approved.

Run the following script to verify the function usage:

Verification successful

Function Usage Verified: Consistent Parameter Type

The initStore function is consistently used with the new parameter type corestore.KVStoreWithBatch across the codebase. No issues were found with the function calls.

  • Verified in x/upgrade/types/storeloader_test.go
  • Verified in baseapp/baseapp_test.go
Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify all function calls to `initStore` match the new parameter type.

# Test: Search for the function usage. Expect: Only occurrences of the new parameter type.
rg --type go -A 5 $'initStore'

Length of output: 1931

Line range hint 41-55: LGTM! But verify the function usage in the codebase.

The function is correctly implemented. However, ensure that all function calls to checkStore match the new parameter type.

The code changes are approved.

Run the following script to verify the function usage:

Verification successful

Verification Successful: Function Usage Matches New Parameter Type

The checkStore function is correctly used with the new parameter type corestore.KVStoreWithBatch in all relevant instances across the codebase. The instances in store/rootmulti/store_test.go are different functions and do not impact this verification.

  • x/upgrade/types/storeloader_test.go
  • baseapp/baseapp_test.go
Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify all function calls to `checkStore` match the new parameter type.

# Test: Search for the function usage. Expect: Only occurrences of the new parameter type.
rg --type go -A 5 $'checkStore'

Length of output: 5803

simapp/simd/cmd/commands.go (2)

Line range hint 119-125: LGTM! But verify the function usage in the codebase.

The function is correctly implemented. However, ensure that all function calls to newApp match the new parameter type.

The code changes are approved.

Run the following script to verify the function usage:

Line range hint 134-153: LGTM! But verify the function usage in the codebase.

The function is correctly implemented. However, ensure that all function calls to appExport match the new parameter type.

The code changes are approved.

Run the following script to verify the function usage:

runtime/v2/go.mod (1)

44-44: Verify the compatibility of the new dependency version.

The dependency github.com/cosmos/cosmos-db has been updated from v1.0.2 to v1.0.3-0.20240829004618-717cba019b33. Ensure that the new version is compatible with the rest of the codebase and does not introduce any breaking changes.

Run the following script to check for any breaking changes or compatibility issues:

server/v2/go.mod (1)

58-58: Verify the compatibility of the new dependency version.

The dependency github.com/cosmos/cosmos-db has been updated from v1.0.2 to v1.0.3-0.20240829004618-717cba019b33. Ensure that the new version is compatible with the rest of the codebase and does not introduce any breaking changes.

Run the following script to check for any breaking changes or compatibility issues:

store/cachemulti/store.go (1)

7-7: Verify the compatibility of the new parameter type.

The type of the first parameter in the NewStore function has been changed from dbm.DB to corestore.KVStoreWithBatch. Ensure that the new type is compatible with the rest of the function and does not introduce any issues.

Run the following script to check for any compatibility issues:

Also applies to: 68-68

Verification successful

Parameter Type Change is Compatible

The NewStore function in store/cachemulti/store.go adapts the corestore.KVStoreWithBatch parameter into a dbadapter.Store, indicating that the change in parameter type is compatible with the function's implementation. No direct operations are performed on the new type, suggesting that the change should not introduce issues.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify compatibility of the new parameter type.

# Test: Check for any compatibility issues with the new parameter type.
rg --type go -A 5 $'NewStore'

Length of output: 76919

Script:

#!/bin/bash
# Retrieve the implementation of the NewStore function in store/cachemulti/store.go
ast-grep --lang go --pattern $'func NewStore(db corestore.KVStoreWithBatch, $$$) $_' store/cachemulti/store.go

Length of output: 568

server/mock/store.go (2)

8-8: LGTM!

The import statement for corestore is correctly added.

The code changes are approved.

93-94: Consider utilizing the db parameter.

The MountStoreWithDB method updates the type of the db parameter to corestore.KVStoreWithBatch, but the db parameter is not utilized within the method. Ensure that this is intentional or consider using the db parameter.

Verify if the db parameter should be utilized within the method.

store/pruning/manager.go (6)

9-9: LGTM!

The import statement for corestore is correctly added.

The code changes are approved.

18-18: LGTM!

The type of the db field in the Manager struct is correctly updated to corestore.KVStoreWithBatch.

The code changes are approved.

48-51: LGTM!

The type of the db parameter in the NewManager method is correctly updated to corestore.KVStoreWithBatch.

The code changes are approved.

91-91: Verify the performance and consistency guarantees of the Set method.

The SetSync method call on the database has been replaced with a Set method call. Ensure that the Set method provides the same or better performance and consistency guarantees as the SetSync method.

Verify the performance and consistency guarantees of the Set method.

Line range hint 139-144: LGTM!

The type of the db parameter in the LoadSnapshotHeights method is correctly updated to corestore.KVStoreWithBatch.

The code changes are approved.

158-158: LGTM!

The type of the db parameter in the loadPruningSnapshotHeights function is correctly updated to corestore.KVStoreWithBatch.

The code changes are approved.

tests/e2e/genutil/export_test.go (1)

207-207: LGTM!

The type of the second parameter in the function passed to the genutilcli.ExportCmd method is correctly updated to corestore.KVStoreWithBatch.

The code changes are approved.

testutil/sims/simulation_helpers.go (2)

12-12: LGTM!

The import statement for corestore is correct.

The code changes are approved.

28-28: LGTM! But verify the function usage in the codebase.

The function is correctly implemented. However, ensure that all function calls to SetupSimulation match the new return type.

The code changes are approved.

Run the following script to verify the function usage:

Verification successful

Function Usage Verified: No Issues Found

The SetupSimulation function is used correctly in the codebase, matching the new return type. No further action is needed.

  • simapp/sim_bench_test.go: The function call correctly assigns the return values to variables corresponding to the new return types.
Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify all function calls to `SetupSimulation` match the new return type.

# Test: Search for the function usage. Expect: Only occurrences of the new return type.
rg --type go -A 5 $'SetupSimulation'

Length of output: 1263

tools/confix/go.mod (1)

44-44: LGTM!

The dependency update to github.com/cosmos/cosmos-db is correct and aligns with the changes in the codebase.

The code changes are approved.

tools/hubl/go.mod (1)

47-47: LGTM!

The dependency update to github.com/cosmos/cosmos-db is correct and aligns with the changes in the codebase.

The code changes are approved.

tests/systemtests/go.mod (1)

61-61: Verify the compatibility of the updated dependency.

The version of github.com/cosmos/cosmos-db has been updated from v1.0.2 to v1.0.3-0.20240829004618-717cba019b33. Ensure that the new version is compatible with the rest of the codebase and does not introduce any breaking changes.

Run the following script to check for any breaking changes or compatibility issues:

testutils/sims/runner.go (5)

12-12: LGTM!

The import statement for corestore is necessary for the changes made to the db parameter type.

The code changes are approved.

63-63: LGTM!

The db parameter type has been correctly updated from dbm.DB to corestore.KVStoreWithBatch.

The code changes are approved.

89-89: LGTM!

The db parameter type has been correctly updated from dbm.DB to corestore.KVStoreWithBatch.

The code changes are approved.

157-157: LGTM!

The DB field type has been correctly updated from dbm.DB to corestore.KVStoreWithBatch.

The code changes are approved.

172-172: LGTM!

The db parameter type has been correctly updated from dbm.DB to corestore.KVStoreWithBatch.

The code changes are approved.

x/accounts/defaults/lockup/go.mod (1)

48-48: Verify the compatibility of the updated dependency.

The version of github.com/cosmos/cosmos-db has been updated from v1.0.2 to v1.0.3-0.20240829004618-717cba019b33. Ensure that the new version is compatible with the rest of the codebase and does not introduce any breaking changes.

Run the following script to check for any breaking changes or compatibility issues:

server/v2/cometbft/go.mod (1)

74-74: LGTM! But verify the compatibility of the new version.

The dependency version for github.com/cosmos/cosmos-db has been updated. Ensure that the new version does not introduce breaking changes or incompatibilities.

The code changes are approved.

Run the following script to verify the compatibility of the new version:

x/consensus/go.mod (1)

52-52: LGTM! But verify the compatibility of the new version.

The dependency version for github.com/cosmos/cosmos-db has been updated. Ensure that the new version does not introduce breaking changes or incompatibilities.

The code changes are approved.

Run the following script to verify the compatibility of the new version:

x/auth/go.mod (1)

60-60: LGTM! But verify the compatibility of the new version.

The dependency version for github.com/cosmos/cosmos-db has been updated. Ensure that the new version does not introduce breaking changes or incompatibilities.

The code changes are approved.

Run the following script to verify the compatibility of the new version:

x/staking/go.mod (1)

54-54: LGTM! But verify the compatibility of the new version.

The dependency version has been updated from v1.0.2 to v1.0.3-0.20240829004618-717cba019b33. Ensure that the new version is compatible with the existing codebase.

The code changes are approved.

Run the following script to verify the compatibility of the new version:

x/bank/go.mod (1)

54-54: LGTM! But verify the compatibility of the new version.

The dependency version has been updated from v1.0.2 to v1.0.3-0.20240829004618-717cba019b33. Ensure that the new version is compatible with the existing codebase.

The code changes are approved.

Run the following script to verify the compatibility of the new version:

x/nft/go.mod (1)

53-53: LGTM! But verify the compatibility of the new version.

The dependency version has been updated from v1.0.2 to v1.0.3-0.20240829004618-717cba019b33. Ensure that the new version is compatible with the existing codebase.

The code changes are approved.

Run the following script to verify the compatibility of the new version:

x/evidence/go.mod (1)

56-56: LGTM! But verify the impact of the updated dependency version.

The version of github.com/cosmos/cosmos-db has been updated from v1.0.2 to v1.0.3-0.20240829004618-717cba019b33. Ensure that this update does not introduce any breaking changes or negatively impact the codebase.

The code changes are approved.

Run the following script to verify the impact of the updated dependency version:

x/protocolpool/go.mod (1)

56-56: LGTM! But verify the impact of the updated dependency version.

The version of github.com/cosmos/cosmos-db has been updated from v1.0.2 to v1.0.3-0.20240829004618-717cba019b33. Ensure that this update does not introduce any breaking changes or negatively impact the codebase.

The code changes are approved.

Run the following script to verify the impact of the updated dependency version:

x/epochs/go.mod (1)

50-50: LGTM! But verify the impact of the updated dependency version.

The version of github.com/cosmos/cosmos-db has been updated from v1.0.2 to v1.0.3-0.20240829004618-717cba019b33. Ensure that this update does not introduce any breaking changes or negatively impact the codebase.

The code changes are approved.

Run the following script to verify the impact of the updated dependency version:

x/slashing/go.mod (1)

57-57: Dependency Update Approved.

The version of github.com/cosmos/cosmos-db has been updated to v1.0.3-0.20240829004618-717cba019b33. Ensure that the new version is compatible with the rest of the codebase.

x/circuit/go.mod (1)

52-52: Dependency Update Approved.

The version of github.com/cosmos/cosmos-db has been updated to v1.0.3-0.20240829004618-717cba019b33. Ensure that the new version is compatible with the rest of the codebase.

x/authz/go.mod (1)

53-53: Dependency Update Approved.

The version of github.com/cosmos/cosmos-db has been updated to v1.0.3-0.20240829004618-717cba019b33. Ensure that the new version is compatible with the rest of the codebase.

x/mint/go.mod (1)

52-52: LGTM! Verify the release notes or changelog for the updated dependency.

The dependency version has been updated from v1.0.2 to v1.0.3-0.20240829004618-717cba019b33. Ensure to review the release notes or changelog for any important changes.

The code changes are approved.

x/distribution/go.mod (1)

64-64: LGTM! Verify the release notes or changelog for the updated dependency.

The dependency version has been updated from v1.0.2 to v1.0.3-0.20240829004618-717cba019b33. Ensure to review the release notes or changelog for any important changes.

The code changes are approved.

x/gov/go.mod (1)

61-61: LGTM! Verify the release notes or changelog for the updated dependency.

The dependency version has been updated from v1.0.2 to v1.0.3-0.20240829004618-717cba019b33. Ensure to review the release notes or changelog for any important changes.

The code changes are approved.

x/params/go.mod (1)

15-15: LGTM! But verify the dependency compatibility.

The version of github.com/cosmos/cosmos-db has been updated from v1.0.2 to v1.0.3-0.20240829004618-717cba019b33. Ensure that the new version is compatible with the existing codebase.

The code changes are approved.

Run the following script to verify the dependency compatibility:

tools/cosmovisor/go.mod (1)

51-51: LGTM! But verify the dependency compatibility.

The version of github.com/cosmos/cosmos-db has been updated from v1.0.2 to v1.0.3-0.20240829004618-717cba019b33. Ensure that the new version is compatible with the existing codebase.

The code changes are approved.

Run the following script to verify the dependency compatibility:

x/feegrant/go.mod (1)

60-60: LGTM! But verify the dependency compatibility.

The version of github.com/cosmos/cosmos-db has been updated from v1.0.2 to v1.0.3-0.20240829004618-717cba019b33. Ensure that the new version is compatible with the existing codebase.

The code changes are approved.

Run the following script to verify the dependency compatibility:

x/genutil/client/cli/export_test.go (2)

20-20: LGTM!

The import statement for corestore is correctly added.

The code changes are approved.

158-158: LGTM!

The db parameter type has been correctly updated to corestore.KVStoreWithBatch.

The code changes are approved.

simapp/sim_test.go (1)

172-172: LGTM!

The db parameter type has been correctly updated to corestore.KVStoreWithBatch.

The code changes are approved.

x/accounts/defaults/multisig/go.mod (1)

51-51: LGTM!

The version of the github.com/cosmos/cosmos-db package has been correctly updated.

The code changes are approved.

client/v2/go.mod (1)

53-53: LGTM! Verify compatibility with the new version.

The dependency version for github.com/cosmos/cosmos-db has been updated. Ensure that the new version is compatible with the rest of the codebase.

The code changes are approved.

Run the following script to verify compatibility:

x/accounts/go.mod (1)

55-55: LGTM! Verify compatibility with the new version.

The dependency version for github.com/cosmos/cosmos-db has been updated. Ensure that the new version is compatible with the rest of the codebase.

The code changes are approved.

Run the following script to verify compatibility:

go.mod (1)

26-26: LGTM! Verify compatibility with the new version.

The dependency version for github.com/cosmos/cosmos-db has been updated. Ensure that the new version is compatible with the rest of the codebase.

The code changes are approved.

Run the following script to verify compatibility:

x/group/go.mod (1)

24-24: Verify the changes in the updated dependency.

The version of github.com/cosmos/cosmos-db has been updated from v1.0.2 to v1.0.3-0.20240829004618-717cba019b33. Ensure that the changes in the updated version do not introduce any breaking changes or modify existing behavior unexpectedly.

Run the following script to check the changelog or release notes for the updated dependency version:

store/rootmulti/snapshot_test.go (3)

Line range hint 27-64: LGTM!

The function newMultiStoreWithGeneratedData has been updated to use corestore.KVStoreWithBatch instead of dbm.DB. This change likely enhances the functionality related to batch operations on the key-value store.

The code changes are approved.

Line range hint 65-76: LGTM!

The function newMultiStoreWithMixedMounts has been updated to use corestore.KVStoreWithBatch instead of dbm.DB. This change likely enhances the functionality related to batch operations on the key-value store.

The code changes are approved.

Line range hint 77-99: LGTM!

The function newMultiStoreWithMixedMountsAndBasicData has been updated to use corestore.KVStoreWithBatch instead of dbm.DB. This change likely enhances the functionality related to batch operations on the key-value store.

The code changes are approved.

testutil/sims/app_helpers.go (1)

88-88: LGTM!

The DB field in the StartupConfig struct has been updated to use corestore.KVStoreWithBatch instead of dbm.DB. This change likely enhances the functionality related to batch operations on the key-value store.

The code changes are approved.

x/upgrade/go.mod (1)

18-18: LGTM! Verify the changelog or release notes.

The dependency github.com/cosmos/cosmos-db has been updated to a newer version. Ensure to review the changelog or release notes for any significant changes.

baseapp/options.go (1)

180-183: LGTM! Verify the method usage in the codebase.

The SetDB method has been correctly updated to use corestore.KVStoreWithBatch. Ensure that all calls to this method are updated accordingly.

Run the following script to verify the method usage:

orm/model/ormdb/module_test.go (1)

21-21: LGTM! Verify the test coverage for the new functionality.

The db field in the testStoreService struct has been correctly updated to use corestore.KVStoreWithBatch. Ensure that the tests cover the new functionality.

Run the following script to verify the test coverage:

Also applies to: 361-361

tests/go.mod (1)

22-22: Dependency version update approved.

The github.com/cosmos/cosmos-db dependency version has been updated from v1.0.2 to v1.0.3-0.20240829004618-717cba019b33.

The code changes are approved.

simapp/go.mod (1)

38-38: LGTM!

The dependency update from v1.0.2 to v1.0.3-0.20240829004618-717cba019b33 is appropriate. The comment correctly indicates that this version is not actively used as it is always replaced by the latest Cosmos SDK version.

The code changes are approved.

docs/learn/advanced/04-store.md (2)

144-144: LGTM!

The documentation correctly reflects the update from dbm.DB to corestore.KVStoreWithBatch.

The code changes are approved.

150-150: LGTM!

The documentation correctly reflects the update from dbm.DB to corestore.KVStoreWithBatch.

The code changes are approved.

simapp/v2/go.mod (1)

35-35: LGTM!

The dependency update from v1.0.2 to v1.0.3-0.20240829004618-717cba019b33 is appropriate. The comment correctly indicates that this version is not actively used as it is always replaced by the latest Cosmos SDK version.

The code changes are approved.

store/cachekv/store_test.go (3)

495-495: LGTM! But verify the function usage in the codebase.

The function signature has been correctly updated to use corestore.KVStoreWithBatch. However, ensure that all function calls to doRandomOp match the new signature.

The code changes are approved.

Run the following script to verify the function usage:

Verification successful

Function usage is consistent with the updated signature.

The function doRandomOp is used consistently with its updated signature within the store/cachekv/store_test.go file. No discrepancies were found in the usage of the function.

  • Verified usage in store/cachekv/store_test.go.
Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify all function calls to `doRandomOp` match the new signature.

# Test: Search for the function usage. Expect: Only occurrences of the new signature.
rg --type go -A 5 $'doRandomOp'

Length of output: 675

469-469: LGTM! But verify the function usage in the codebase.

The function signature has been correctly updated to use corestore.KVStoreWithBatch. However, ensure that all function calls to doOp match the new signature.

The code changes are approved.

Run the following script to verify the function usage:

Verification successful

Function usage is consistent with the updated signature.

The calls to doOp in store/cachekv/store_test.go correctly match the new function signature using corestore.KVStoreWithBatch. No issues were found with the function usage.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify all function calls to `doOp` match the new signature.

# Test: Search for the function usage. Expect: Only occurrences of the new signature.
rg --type go -A 5 $'doOp'

Length of output: 1554

601-601: LGTM! But verify the function usage in the codebase.

The function signature has been correctly updated to use corestore.KVStoreWithBatch. However, ensure that all function calls to setRange match the new signature.

The code changes are approved.

Run the following script to verify the function usage:

Verification successful

Function usage verified successfully.

All calls to setRange in the codebase match the updated signature using corestore.KVStoreWithBatch. No inconsistencies were found.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify all function calls to `setRange` match the new signature.

# Test: Search for the function usage. Expect: Only occurrences of the new signature.
rg --type go -A 5 $'setRange'

Length of output: 2512

server/util.go (1)

477-477: LGTM! But verify the function usage in the codebase.

The function signature has been correctly updated to return corestore.KVStoreWithBatch. However, ensure that all function calls to OpenDB match the new signature.

The code changes are approved.

Run the following script to verify the function usage:

Verification successful

Function usage is consistent with the new signature.

The OpenDB function is used correctly across the codebase with the updated return type corestore.KVStoreWithBatch. The function calls handle the returned error and utilize the db variable appropriately.

  • Files with verified usage:
    • x/genutil/client/cli/export.go
    • server/rollback.go
    • server/start.go
    • server/module_hash.go
    • server/constructors_test.go
    • server/cmt_cmds.go
Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify all function calls to `OpenDB` match the new signature.

# Test: Search for the function usage. Expect: Only occurrences of the new signature.
rg --type go -A 5 $'OpenDB'

Length of output: 2644

store/iavl/store_test.go (10)

15-15: LGTM!

The import statement for corestore is correct and aligns with the changes described in the PR summary.

The code changes are approved.

39-39: LGTM!

The function signature update to accept corestore.KVStoreWithBatch instead of dbm.DB is correct and aligns with the changes described in the PR summary.

The code changes are approved.

289-289: LGTM!

The function correctly initializes the database using dbm.NewMemDB() and performs the necessary tests.

The code changes are approved.

323-323: LGTM!

The function correctly initializes the database using dbm.NewMemDB() and performs the necessary tests.

The code changes are approved.

386-386: LGTM!

The function correctly initializes the database using dbm.NewMemDB() and performs the necessary tests.

The code changes are approved.

453-453: LGTM!

The function correctly initializes the database using dbm.NewMemDB() and performs the necessary tests.

The code changes are approved.

471-471: LGTM!

The function correctly initializes the database using dbm.NewMemDB() and performs the necessary tests.

The code changes are approved.

583-583: LGTM!

The function correctly initializes the database using dbm.NewMemDB() and performs the necessary benchmarks.

The code changes are approved.

619-619: LGTM!

The function correctly initializes the database using dbm.NewMemDB() and performs the necessary tests.

The code changes are approved.

Also applies to: 628-628

676-676: LGTM!

The function correctly initializes the database using dbm.NewMemDB() and performs the necessary tests.

The code changes are approved.

simapp/gomod2nix.toml (21)

5-6: LGTM!

The version and hash update for buf.build/gen/go/cometbft/cometbft/protocolbuffers/go is appropriate.

The code changes are approved.

8-9: LGTM!

The version and hash update for buf.build/gen/go/cosmos/gogo-proto/protocolbuffers/go is appropriate.

The code changes are approved.

11-12: LGTM!

The version and hash update for cloud.google.com/go is appropriate.

The code changes are approved.

14-15: LGTM!

The version and hash update for cloud.google.com/go/auth is appropriate.

The code changes are approved.

17-18: LGTM!

The version and hash update for cloud.google.com/go/auth/oauth2adapt is appropriate.

The code changes are approved.

20-21: LGTM!

The version and hash update for cloud.google.com/go/compute/metadata is appropriate.

The code changes are approved.

23-24: LGTM!

The version and hash update for cloud.google.com/go/iam is appropriate.

The code changes are approved.

26-27: LGTM!

The version and hash update for cloud.google.com/go/storage is appropriate.

The code changes are approved.

29-30: LGTM!

The addition of cosmossdk.io/depinject with the specified version and hash is appropriate.

The code changes are approved.

35-36: LGTM!

The version and hash update for cosmossdk.io/log is appropriate.

The code changes are approved.

41-42: LGTM!

The addition of cosmossdk.io/schema with the specified version and hash is appropriate.

The code changes are approved.

63-64: LGTM!

The version and hash update for github.com/aws/aws-sdk-go is appropriate.

The code changes are approved.

75-75: LGTM!

The version and hash update for github.com/bgentry/speakeasy is appropriate.

The code changes are approved.

120-121: LGTM!

The version and hash update for github.com/cosmos/cosmos-db is appropriate.

The code changes are approved.

126-127: LGTM!

The version and hash update for github.com/cosmos/crypto is appropriate.

The code changes are approved.

135-136: LGTM!

The version and hash update for github.com/cosmos/gogoproto is appropriate.

The code changes are approved.

138-139: LGTM!

The version and hash update for github.com/cosmos/iavl is appropriate.

The code changes are approved.

243-244: LGTM!

The version and hash update for github.com/google/s2a-go is appropriate.

The code changes are approved.

252-253: LGTM!

The version and hash update for github.com/googleapis/gax-go/v2 is appropriate.

The code changes are approved.

261-262: LGTM!

The version and hash update for github.com/gorilla/websocket is appropriate.

The code changes are approved.

276-277: LGTM!

The version and hash update for github.com/hashicorp/go-getter is appropriate.

The code changes are approved.

docs/architecture/adr-038-state-listening.md (1)

621-621: LGTM!

The function signature update aligns with the PR objective to replace dbm.DB with corestore.KVStoreWithBatch.

The code changes are approved.

baseapp/baseapp_test.go (2)

300-300: LGTM!

The function signature update aligns with the PR objective to replace dbm.DB with corestore.KVStoreWithBatch.

The code changes are approved.

321-321: LGTM!

The function signature update aligns with the PR objective to replace dbm.DB with corestore.KVStoreWithBatch.

The code changes are approved.

store/rootmulti/store_test.go (12)

13-13: LGTM!

The import statement for corestore is correctly added.

The code changes are approved.

31-31: LGTM!

The type of db has been correctly changed to corestore.KVStoreWithBatch.

The code changes are approved.

64-64: LGTM!

The type of db has been correctly changed to corestore.KVStoreWithBatch.

The code changes are approved.

72-72: LGTM!

The type of db has been correctly changed to corestore.KVStoreWithBatch.

The code changes are approved.

125-125: LGTM!

The type of db has been correctly changed to corestore.KVStoreWithBatch.

The code changes are approved.

155-155: LGTM!

The type of db has been correctly changed to corestore.KVStoreWithBatch.

The code changes are approved.

208-208: LGTM!

The type of db has been correctly changed to corestore.KVStoreWithBatch.

The code changes are approved.

672-672: LGTM!

The type of db has been correctly changed to corestore.KVStoreWithBatch.

The code changes are approved.

792-792: LGTM!

The type of db has been correctly changed to corestore.KVStoreWithBatch.

The code changes are approved.

836-836: LGTM!

The type of db has been correctly changed to corestore.KVStoreWithBatch.

The code changes are approved.

Also applies to: 847-847

933-933: LGTM!

The type of db has been correctly changed to corestore.KVStoreWithBatch.

The code changes are approved.

973-973: LGTM!

The type of db has been correctly changed to corestore.KVStoreWithBatch.

The code changes are approved.

simapp/app.go (1)

199-199: LGTM!

The type of db has been correctly changed to corestore.KVStoreWithBatch.

The code changes are approved.

server/start.go (3)

39-39: LGTM!

The import statement for corestore is correctly added.

The code changes are approved.

757-757: LGTM! But verify the function usage in the codebase.

The function signature change is correctly implemented. However, ensure that all instances of testnetify match the new parameter type.

The code changes are approved.

Run the following script to verify the function usage:

Verification successful

Function usage verified successfully.

The testnetify function is used consistently with the new parameter type corestore.KVStoreWithBatch in the codebase. No discrepancies found.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify all instances of `testnetify` match the new parameter type.

# Test: Search for the function usage. Expect: Only occurrences of the new parameter type.
rg --type go -A 5 $'testnetify'

Length of output: 996

121-121: LGTM! But verify the struct usage in the codebase.

The function type change is correctly implemented. However, ensure that all instances of StartCmdOptions are updated to match the new DBOpener function type.

The code changes are approved.

Run the following script to verify the struct usage:

store/rootmulti/store.go (9)

19-19: LGTM!

The import section correctly includes the new corestore package.

The code changes are approved.

59-59: LGTM!

The Store struct correctly uses the new corestore.KVStoreWithBatch type.

The code changes are approved.

88-88: LGTM!

The function correctly initializes the Store struct with the new corestore.KVStoreWithBatch type.

The code changes are approved.

141-141: LGTM!

The function correctly mounts the store with the new corestore.KVStoreWithBatch type.

The code changes are approved.

1017-1023: LGTM!

The function correctly loads the commit store with the new corestore.KVStoreWithBatch type.

The code changes are approved.

1145-1145: LGTM!

The function correctly flushes metadata with the new corestore.KVStoreWithBatch type.

The code changes are approved.

1168-1168: LGTM!

The storeParams struct correctly uses the new corestore.KVStoreWithBatch type.

The code changes are approved.

1173-1173: LGTM!

The function correctly initializes the storeParams struct with the new corestore.KVStoreWithBatch type.

The code changes are approved.

1182-1182: LGTM!

The function correctly retrieves the latest version with the new corestore.KVStoreWithBatch type.

The code changes are approved.

baseapp/baseapp.go (3)

20-20: LGTM!

The import statement for corestore has been correctly added.

The code changes are approved.

68-68: LGTM!

The db field has been correctly updated to corestore.KVStoreWithBatch.

The code changes are approved.

197-197: LGTM!

The db parameter in the NewBaseApp constructor has been correctly updated to corestore.KVStoreWithBatch.

The code changes are approved.

docs/learn/advanced/00-baseapp.md (1)

111-111: LGTM!

The function signature change is correctly reflected in the documentation.

The code changes are approved.

store/iavl/store.go
@@ -43,16 +42,16 @@
// LoadStore returns an IAVL Store as a CommitKVStore. Internally, it will load the
// store's version (id) from the provided DB. An error is returned if the version
// fails to load, or if called with a positive version on an empty tree.
func LoadStore(db dbm.DB, logger types.Logger, key types.StoreKey, id types.CommitID, cacheSize int, disableFastNode bool, metrics metrics.StoreMetrics) (types.CommitKVStore, error) {
func LoadStore(db corestore.KVStoreWithBatch, logger types.Logger, key types.StoreKey, id types.CommitID, cacheSize int, disableFastNode bool, metrics metrics.StoreMetrics) (types.CommitKVStore, error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flag the type mismatch issue in LoadStoreWithInitialVersion.

The db parameter type change from dbm.DB to corestore.KVStoreWithBatch causes a type mismatch issue in the LoadStoreWithInitialVersion function.

Apply this diff to fix the type mismatch issue:

-func LoadStore(db corestore.KVStoreWithBatch, logger types.Logger, key types.StoreKey, id types.CommitID, cacheSize int, disableFastNode bool, metrics metrics.StoreMetrics) (types.CommitKVStore, error) {
+func LoadStore(db dbm.DB, logger types.Logger, key types.StoreKey, id types.CommitID, cacheSize int, disableFastNode bool, metrics metrics.StoreMetrics) (types.CommitKVStore, error) {
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
func LoadStore(db corestore.KVStoreWithBatch, logger types.Logger, key types.StoreKey, id types.CommitID, cacheSize int, disableFastNode bool, metrics metrics.StoreMetrics) (types.CommitKVStore, error) {
func LoadStore(db dbm.DB, logger types.Logger, key types.StoreKey, id types.CommitID, cacheSize int, disableFastNode bool, metrics metrics.StoreMetrics) (types.CommitKVStore, error) {

store/iavl/store.go
Comment on lines +53 to +54
func LoadStoreWithInitialVersion(db corestore.KVStoreWithBatch, logger types.Logger, key types.StoreKey, id types.CommitID, initialVersion uint64, cacheSize int, disableFastNode bool, metrics metrics.StoreMetrics) (types.CommitKVStore, error) {
tree := iavl.NewMutableTree(db, cacheSize, disableFastNode, logger, iavl.InitialVersionOption(initialVersion), iavl.AsyncPruningOption(true))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flag the type mismatch issue in LoadStoreWithInitialVersion.

The db parameter type change from dbm.DB to corestore.KVStoreWithBatch causes a type mismatch issue in the LoadStoreWithInitialVersion function.

Apply this diff to fix the type mismatch issue:

-func LoadStoreWithInitialVersion(db corestore.KVStoreWithBatch, logger types.Logger, key types.StoreKey, id types.CommitID, initialVersion uint64, cacheSize int, disableFastNode bool, metrics metrics.StoreMetrics) (types.CommitKVStore, error) {
+func LoadStoreWithInitialVersion(db dbm.DB, logger types.Logger, key types.StoreKey, id types.CommitID, initialVersion uint64, cacheSize int, disableFastNode bool, metrics metrics.StoreMetrics) (types.CommitKVStore, error) {
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
func LoadStoreWithInitialVersion(db corestore.KVStoreWithBatch, logger types.Logger, key types.StoreKey, id types.CommitID, initialVersion uint64, cacheSize int, disableFastNode bool, metrics metrics.StoreMetrics) (types.CommitKVStore, error) {
tree := iavl.NewMutableTree(db, cacheSize, disableFastNode, logger, iavl.InitialVersionOption(initialVersion), iavl.AsyncPruningOption(true))
func LoadStoreWithInitialVersion(db dbm.DB, logger types.Logger, key types.StoreKey, id types.CommitID, initialVersion uint64, cacheSize int, disableFastNode bool, metrics metrics.StoreMetrics) (types.CommitKVStore, error) {
tree := iavl.NewMutableTree(db, cacheSize, disableFastNode, logger, iavl.InitialVersionOption(initialVersion), iavl.AsyncPruningOption(true))
Tools
GitHub Check: tests (03)

[failure] 54-54:
cannot use db (variable of type store.KVStoreWithBatch) as "github.com/cosmos/iavl/db".DB value in argument to iavl.NewMutableTree: store.KVStoreWithBatch does not implement "github.com/cosmos/iavl/db".DB (wrong type for method Iterator)

GitHub Check: tests (02)

[failure] 54-54:
cannot use db (variable of type store.KVStoreWithBatch) as "github.com/cosmos/iavl/db".DB value in argument to iavl.NewMutableTree: store.KVStoreWithBatch does not implement "github.com/cosmos/iavl/db".DB (wrong type for method Iterator)

GitHub Check: tests (01)

[failure] 54-54:
cannot use db (variable of type store.KVStoreWithBatch) as "github.com/cosmos/iavl/db".DB value in argument to iavl.NewMutableTree: store.KVStoreWithBatch does not implement "github.com/cosmos/iavl/db".DB (wrong type for method Iterator)

GitHub Check: tests (00)

[failure] 54-54:
cannot use db (variable of type store.KVStoreWithBatch) as "github.com/cosmos/iavl/db".DB value in argument to iavl.NewMutableTree: store.KVStoreWithBatch does not implement "github.com/cosmos/iavl/db".DB (wrong type for method Iterator)

tac0turtle
tac0turtle approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice cleanup!! excited to see this cleanup.

@julienrbrt julienrbrt added the backport/v0.52.x PR scheduled for inclusion in the v0.52's next stable release label Aug 29, 2024
@tac0turtle
Copy link
Member

build is failing, once fixed it can be merged

coderabbitai[bot]
coderabbitai bot reviewed Aug 30, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Outside diff range, codebase verification and nitpick comments (1)
x/epochs/go.mod (1)

184-184: Issue with replacement directive: cosmossdk.io/store path does not exist.

The local path ../../store specified in the go.mod replacement directive does not exist. Please verify the path configuration or ensure that the necessary directory is created to avoid build issues.

  • Check if the path is correctly specified relative to the go.mod file.
  • Ensure that the store directory is present and accessible.
Analysis chain

Approve the replacement directive for cosmossdk.io/store.

The replacement to the local path ../../store is noted. Please verify that the path is correctly set up and accessible within the project's structure.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the accessibility and setup of the local store path.

# Test: Check if the directory exists and is properly configured.
if [ -d "../../store" ]; then
  echo "Store directory exists."
else
  echo "Store directory does not exist."
fi

Length of output: 97

Review details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 4950027 and 9f1b36b.

Files ignored due to path filters (26)
  • client/v2/go.sum is excluded by !**/*.sum
  • simapp/go.sum is excluded by !**/*.sum
  • simapp/v2/go.sum is excluded by !**/*.sum
  • store/v2/go.sum is excluded by !**/*.sum
  • tests/go.sum is excluded by !**/*.sum
  • x/accounts/defaults/lockup/go.sum is excluded by !**/*.sum
  • x/accounts/defaults/multisig/go.sum is excluded by !**/*.sum
  • x/accounts/go.sum is excluded by !**/*.sum
  • x/auth/go.sum is excluded by !**/*.sum
  • x/authz/go.sum is excluded by !**/*.sum
  • x/bank/go.sum is excluded by !**/*.sum
  • x/circuit/go.sum is excluded by !**/*.sum
  • x/consensus/go.sum is excluded by !**/*.sum
  • x/distribution/go.sum is excluded by !**/*.sum
  • x/epochs/go.sum is excluded by !**/*.sum
  • x/evidence/go.sum is excluded by !**/*.sum
  • x/feegrant/go.sum is excluded by !**/*.sum
  • x/gov/go.sum is excluded by !**/*.sum
  • x/group/go.sum is excluded by !**/*.sum
  • x/mint/go.sum is excluded by !**/*.sum
  • x/nft/go.sum is excluded by !**/*.sum
  • x/params/go.sum is excluded by !**/*.sum
  • x/protocolpool/go.sum is excluded by !**/*.sum
  • x/slashing/go.sum is excluded by !**/*.sum
  • x/staking/go.sum is excluded by !**/*.sum
  • x/upgrade/go.sum is excluded by !**/*.sum
Files selected for processing (31)
  • client/v2/go.mod (2 hunks)
  • simapp/app_di.go (2 hunks)
  • simapp/go.mod (2 hunks)
  • simapp/simd/cmd/commands.go (3 hunks)
  • simapp/v2/go.mod (2 hunks)
  • store/pruning/manager_test.go (1 hunks)
  • store/v2/commitment/iavl/tree.go (2 hunks)
  • store/v2/go.mod (3 hunks)
  • tests/go.mod (2 hunks)
  • x/accounts/defaults/lockup/go.mod (2 hunks)
  • x/accounts/defaults/multisig/go.mod (2 hunks)
  • x/accounts/go.mod (2 hunks)
  • x/auth/go.mod (2 hunks)
  • x/authz/go.mod (2 hunks)
  • x/bank/go.mod (2 hunks)
  • x/circuit/go.mod (2 hunks)
  • x/consensus/go.mod (2 hunks)
  • x/distribution/go.mod (2 hunks)
  • x/epochs/go.mod (2 hunks)
  • x/evidence/go.mod (2 hunks)
  • x/feegrant/go.mod (2 hunks)
  • x/gov/go.mod (2 hunks)
  • x/group/go.mod (2 hunks)
  • x/mint/go.mod (2 hunks)
  • x/nft/go.mod (2 hunks)
  • x/params/go.mod (2 hunks)
  • x/protocolpool/go.mod (2 hunks)
  • x/slashing/go.mod (2 hunks)
  • x/staking/go.mod (2 hunks)
  • x/upgrade/go.mod (2 hunks)
  • x/upgrade/types/storeloader_test.go (3 hunks)
Files skipped from review due to trivial changes (5)
  • simapp/go.mod
  • simapp/v2/go.mod
  • tests/go.mod
  • x/auth/go.mod
  • x/gov/go.mod
Files skipped from review as they are similar to previous changes (5)
  • simapp/app_di.go
  • simapp/simd/cmd/commands.go
  • x/accounts/defaults/lockup/go.mod
  • x/accounts/defaults/multisig/go.mod
  • x/upgrade/types/storeloader_test.go
Additional context used
Path-based instructions (2)
store/v2/commitment/iavl/tree.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

store/pruning/manager_test.go (2)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

Pattern **/*_test.go: "Assess the unit test code assessing sufficient code coverage for the changes associated in the pull request"

Additional comments not posted (41)
store/v2/go.mod (3)

13-13: Question the downgrade of github.com/cosmos/iavl.

The downgrade from a more recent version to v1.0.0-beta.1.0.20240813194616-eb5078efcf9e could potentially reintroduce bugs or remove features that were available in the newer version. Please ensure that this change does not adversely affect the application's functionality and provide justification for this downgrade.

13-13: Approve the removal of github.com/cosmos/cosmos-db.

The removal of this dependency aligns with the PR's objective to replace cosmos-db with core/store. This change is consistent with the intended architectural improvements.

60-60: Approve the update of golang.org/x/exp.

Updating to v0.0.0-20231006140011-7918f672742d likely provides access to new features or important bug fixes. This change is beneficial for keeping the dependencies up-to-date and potentially improving stability or performance.

x/staking/go.mod (2)

180-180: Replace directive for github.com/cosmos/iavl approved with caution.

The directive to use v1.0.0-beta.1.0.20240813194616-eb5078efcf9e is approved. However, please be cautious as beta versions might introduce instability. Ensure thorough testing and compatibility checks with other parts of the system.

54-54: Updated dependency version for github.com/cosmos/cosmos-db approved.

The update to v1.0.3-0.20240829004618-717cba019b33 is noted. Please ensure compatibility with other modules and check for any breaking changes that might affect the x/staking module.

x/evidence/go.mod (2)

56-56: Dependency Version Updated: github.com/cosmos/cosmos-db

The version of github.com/cosmos/cosmos-db has been updated to v1.0.3-0.20240829004618-717cba019b33. This change is part of the PR's objective to refine the codebase by updating dependencies. Ensure that this new version is compatible with other modules and does not introduce breaking changes.

175-175: New Replace Directive Added: github.com/cosmos/iavl

A new replace directive has been added for github.com/cosmos/iavl, pointing to v1.0.0-beta.1.0.20240813194616-eb5078efcf9e. Verify that this version is intended and that the path is correctly set up to avoid potential build or runtime issues.

x/protocolpool/go.mod (2)

56-56: Dependency Version Updated: github.com/cosmos/cosmos-db

The version of github.com/cosmos/cosmos-db has been updated to v1.0.3-0.20240829004618-717cba019b33 in this module as well. Consistency across modules is good practice, ensuring that all parts of the system are using the same versions of dependencies.

175-175: New Replace Directive Added: github.com/cosmos/iavl

As with the previous file, a new replace directive for github.com/cosmos/iavl has been added. It's crucial to ensure that this version is correctly targeted and that the path is valid to prevent issues during development or deployment.

store/pruning/manager_test.go (1)

205-205: Method Call Updated in Test Function

The method call on dbMock has been changed from SetSync to Set. This change should be reflected in the mock expectations and the test's logic to ensure it still accurately tests the intended behavior. Confirm that the Set method provides the necessary functionality and that the error handling in the test aligns with the expected outcomes.

x/epochs/go.mod (2)

177-177: Approve the replacement directive for github.com/cosmos/iavl.

The replacement to v1.0.0-beta.1.0.20240813194616-eb5078efcf9e is noted. Ensure that this beta version aligns with the project's stability and feature requirements.

50-50: Approve the version update for github.com/cosmos/cosmos-db.

The update from v1.0.2 to v1.0.3-0.20240829004618-717cba019b33 is noted. Please ensure compatibility and stability with the rest of the project.

x/circuit/go.mod (2)

52-52: Approved: Dependency update for github.com/cosmos/cosmos-db.

The update to version v1.0.3-0.20240829004618-717cba019b33 is noted. Given that this includes a specific build, it's crucial to ensure thorough testing to validate the stability and compatibility of this update with the module.

182-182: Approved: Replacement directive for cosmossdk.io/store.

Replacing cosmossdk.io/store with a local path ../../store aligns with the PR's objectives to refine the codebase and enhance its architecture by integrating more closely with local developments. Ensure that the local path is correctly set up and accessible in all environments where this module will be used.

x/params/go.mod (2)

175-175: Updated replace directive for github.com/cosmos/iavl.

The replace directive points to a specific beta version. Verify that this version does not conflict with other dependencies and is suitable for the project's current development stage.

Run the following script to verify the impact of this beta version on the project:

Verification successful

Consistent use of beta version for github.com/cosmos/iavl.

The beta version is being used across multiple modules in the project, as indicated by the replace directives in various go.mod files. Ensure that this version is suitable for the current development stage and monitor for any potential issues as development progresses.

  • Files with replace directive:
    • x/authz/go.mod
    • x/evidence/go.mod
    • x/upgrade/go.mod
    • x/staking/go.mod
    • x/slashing/go.mod
    • x/mint/go.mod
    • x/nft/go.mod
    • x/protocolpool/go.mod
    • x/params/go.mod
    • x/distribution/go.mod
    • x/feegrant/go.mod
    • x/group/go.mod
    • x/gov/go.mod
    • x/epochs/go.mod
    • x/circuit/go.mod
    • x/bank/go.mod
    • x/consensus/go.mod
    • x/accounts/go.mod
    • x/auth/go.mod
    • x/accounts/defaults/lockup/go.mod
    • x/accounts/defaults/multisig/go.mod
    • tests/go.mod
    • store/go.mod
    • store/v2/go.mod
    • simapp/go.mod
    • simapp/v2/go.mod
    • client/v2/go.mod
Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the impact of the beta version on the project.

# Test: Search for any known issues or conflicts with other dependencies.
rg --type markdown -A 5 $'github.com/cosmos/iavl v1.0.0-beta.1.0.20240813194616-eb5078efcf9e'

Length of output: 94

Script:

#!/bin/bash
# Description: Search the entire codebase for references to the specific beta version of the package.

# Search for the specific beta version in all files to identify any potential issues or conflicts.
rg 'github.com/cosmos/iavl v1.0.0-beta.1.0.20240813194616-eb5078efcf9e' -A 5

Length of output: 31558

15-15: Updated dependency version for github.com/cosmos/cosmos-db.

The dependency version has been updated to a pre-release version. Ensure that this version is stable and compatible with the project's requirements.

Run the following script to verify the stability and compatibility of the new version:

x/accounts/go.mod (2)

55-55: Approved: Update to github.com/cosmos/cosmos-db version.

The update from v1.0.2 to v1.0.3-0.20240829004618-717cba019b33 is noted and aligns with the PR's objectives. Please ensure to review the release notes of the new version to understand any changes that might impact the application.

178-178: Approved: Replace directive for github.com/cosmos/iavl.

The addition of the replace directive to use github.com/cosmos/iavl v1.0.0-beta.1.0.20240813194616-eb5078efcf9e is noted. Please verify that this specific version is necessary for the application's requirements and check for any potential issues due to it being a pre-release version.

x/group/go.mod (1)

24-24: Approved: Update to github.com/cosmos/cosmos-db version.

The update from v1.0.2 to v1.0.3-0.20240829004618-717cba019b33 is noted and aligns with the PR's objectives. Please ensure to review the release notes of the new version to understand any changes that might impact the application.

x/upgrade/go.mod (1)

18-18: Approved: Update to github.com/cosmos/cosmos-db version.

The update from v1.0.2 to v1.0.3-0.20240829004618-717cba019b33 is noted and aligns with the PR's objectives. Please ensure to review the release notes of the new version to understand any changes that might impact the application.

store/v2/commitment/iavl/tree.go (1)

27-27: Simplify database handling by removing unnecessary abstraction.

The change to directly use the db parameter in the instantiation of MutableTree aligns with the architectural goals of reducing complexity and potentially enhancing performance. Ensure that the db parameter fully supports the interface expected by iavl.NewMutableTree.

Run the following script to verify the compatibility of db with iavl.NewMutableTree:

#!/bin/bash
# Description: Verify the compatibility of `db` with `iavl.NewMutableTree`.

# Test: Search for the function usage. Expect: Only occurrences of the new signature.
rg --type go -A 5 $'iavl.NewMutableTree'
x/consensus/go.mod (3)

52-52: Update to a newer version of github.com/cosmos/cosmos-db.

The update to v1.0.3-0.20240829004618-717cba019b33 likely includes important bug fixes or features. Ensure compatibility with other project components.

Run the following script to verify the compatibility of the new version with the project:

#!/bin/bash
# Description: Verify the compatibility of the new `cosmos-db` version with the project.

# Test: Search for the dependency usage. Expect: Only occurrences of the new version.
rg --type go -A 5 $'github.com/cosmos/cosmos-db'

173-173: Point to a specific beta version of github.com/cosmos/iavl.

The replace directive to v1.0.0-beta.1.0.20240813194616-eb5078efcf9e indicates a need for specific features or fixes. Verify that this version is compatible with other project components.

Run the following script to verify the compatibility of the new iavl version with the project:

#!/bin/bash
# Description: Verify the compatibility of the new `iavl` version with the project.

# Test: Search for the dependency usage. Expect: Only occurrences of the new version.
rg --type go -A 5 $'github.com/cosmos/iavl'

179-179: Redirect cosmossdk.io/store to a local path.

The replace directive to ../../store suggests a move to manage this dependency locally, which could be for easier development or testing. Ensure that this local path is correctly set up and accessible.

Run the following script to verify the setup of the local path for cosmossdk.io/store:

#!/bin/bash
# Description: Verify the setup of the local path for `cosmossdk.io/store`.

# Test: Check the local path setup. Expect: Path should be accessible and correctly set up.
ls -la ../../store
x/bank/go.mod (3)

54-54: Update to a newer version of github.com/cosmos/cosmos-db.

The update to v1.0.3-0.20240829004618-717cba019b33 likely includes important bug fixes or features. Ensure compatibility with other project components.

Run the following script to verify the compatibility of the new version with the project:

#!/bin/bash
# Description: Verify the compatibility of the new `cosmos-db` version with the project.

# Test: Search for the dependency usage. Expect: Only occurrences of the new version.
rg --type go -A 5 $'github.com/cosmos/cosmos-db'

178-178: Point to a specific beta version of github.com/cosmos/iavl.

The replace directive to v1.0.0-beta.1.0.20240813194616-eb5078efcf9e indicates a need for specific features or fixes. Verify that this version is compatible with other project components.

Run the following script to verify the compatibility of the new iavl version with the project:

#!/bin/bash
# Description: Verify the compatibility of the new `iavl` version with the project.

# Test: Search for the dependency usage. Expect: Only occurrences of the new version.
rg --type go -A 5 $'github.com/cosmos/iavl'

186-186: Redirect cosmossdk.io/store to a local path.

The replace directive to ../../store suggests a move to manage this dependency locally, which could be for easier development or testing. Ensure that this local path is correctly set up and accessible.

Run the following script to verify the setup of the local path for cosmossdk.io/store:

#!/bin/bash
# Description: Verify the setup of the local path for `cosmossdk.io/store`.

# Test: Check the local path setup. Expect: Path should be accessible and correctly set up.
ls -la ../../store
x/nft/go.mod (2)

53-53: Approve the dependency update but verify compatibility.

The update to github.com/cosmos/cosmos-db to a specific commit version is noted. It's important to ensure that this update is compatible with the rest of the project and does not introduce any breaking changes.

174-174: Approve the replace directive but exercise caution due to beta status.

The replace directive for github.com/cosmos/iavl points to a beta version. While this may include necessary fixes or features, it's important to be cautious with beta versions in production environments.

x/mint/go.mod (2)

52-52: ```shell
#!/bin/bash

Search for changelog or release notes related to cosmos-db in the repository.

rg "cosmos-db" --glob "CHANGELOG" --glob "RELEASE" -i -A 5


---

`179-179`: ```shell
#!/bin/bash
# Search for issues or pull requests related to the specific version of iavl in the GitHub repository.
gh issue list --repo cosmos/iavl --search "v1.0.0-beta.1.0.20240813194616-eb5078efcf9e"
gh pr list --repo cosmos/iavl --search "v1.0.0-beta.1.0.20240813194616-eb5078efcf9e"

#!/bin/bash
# Search for any documentation or changelog entries related to the specific version in the codebase.
rg "v1.0.0-beta.1.0.20240813194616-eb5078efcf9e" --glob "*CHANGELOG*" --glob "*.md"
client/v2/go.mod (2)

53-53: ```shell
#!/bin/bash

Description: Perform a deeper clone and search for the commit hash in all branches.

Test: Clone the repository with more depth and search for the commit hash.

gh repo clone cosmos/cosmos-db
cd cosmos-db
git fetch --all
git log --all --oneline | grep "717cba019b33"


---

`180-180`: **New replace directive for `github.com/cosmos/iavl`.**

The addition of a replace directive pointing to `v1.0.0-beta.1.0.20240813194616-eb5078efcf9e` suggests a specific beta version is required, likely for compatibility or testing purposes with the new `core/store` interface. It's crucial to verify that this version does not introduce any breaking changes or instability in the environment where it's used.

</blockquote></details>
<details>
<summary>x/authz/go.mod (2)</summary><blockquote>

`53-53`: **Updated dependency version for `github.com/cosmos/cosmos-db`.**

The update from `v1.0.2` to `v1.0.3-0.20240829004618-717cba019b33` is noted. Ensure that this new version is compatible with other dependencies and does not introduce breaking changes. It's crucial to verify through integration testing that the update integrates well with the existing codebase.

```shell
#!/bin/bash
# Description: Check for any reported issues with the new version of cosmos-db in the project's issue tracker.
gh issue list --search "github.com/cosmos/cosmos-db v1.0.3-0.20240829004618-717cba019b33 in:title"

179-179: New replace directive for github.com/cosmos/iavl.

The addition of a replace directive pointing to v1.0.0-beta.1.0.20240813194616-eb5078efcf9e for github.com/cosmos/iavl is appropriate for pinning to a specific version. This is often necessary to avoid issues with newer versions that might not be fully compatible or stable. Confirm that this version has been tested and is stable for use in production environments.

#!/bin/bash
# Description: Check for any reported issues with the specific version of iavl in the project's issue tracker.
gh issue list --search "github.com/cosmos/iavl v1.0.0-beta.1.0.20240813194616-eb5078efcf9e in:title"
x/slashing/go.mod (2)

57-57: Updated dependency version for github.com/cosmos/cosmos-db.

As with the previous file, the update from v1.0.2 to v1.0.3-0.20240829004618-717cba019b33 is noted. Consistency across modules in updating this dependency is good practice. Ensure that this version is thoroughly tested across all modules to prevent integration issues.

#!/bin/bash
# Description: Verify the integration of the new cosmos-db version across all modules.
gh issue list --search "github.com/cosmos/cosmos-db v1.0.3-0.20240829004618-717cba019b33 in:title"

176-176: New replace directive for github.com/cosmos/iavl.

This replace directive is consistent with the one added in the x/authz module. It's important to maintain consistency in dependency management across modules to ensure smooth operation and compatibility. Verify that this specific version of iavl is stable and does not introduce any regressions.

#!/bin/bash
# Description: Check stability and compatibility of the specific iavl version across modules.
gh issue list --search "github.com/cosmos/iavl v1.0.0-beta.1.0.20240813194616-eb5078efcf9e in:title"
x/distribution/go.mod (2)

64-64: Updated dependency version for github.com/cosmos/cosmos-db.

This update is consistent across all reviewed modules, which is crucial for maintaining compatibility and stability throughout the project. As with other modules, ensure that this version of cosmos-db is compatible with the module's requirements and does not introduce any unforeseen issues.

#!/bin/bash
# Description: Ensure that the updated cosmos-db version is compatible with the distribution module.
gh issue list --search "github.com/cosmos/cosmos-db v1.0.3-0.20240829004618-717cba019b33 in:title"

179-179: New replace directive for github.com/cosmos/iavl.

Adding this replace directive across multiple modules helps ensure that all parts of the project are using a tested and stable version of iavl. It's important to verify that this version does not conflict with other dependencies and is suitable for production use.

#!/bin/bash
# Description: Confirm the stability and suitability of the iavl version for production use.
gh issue list --search "github.com/cosmos/iavl v1.0.0-beta.1.0.20240813194616-eb5078efcf9e in:title"
x/feegrant/go.mod (2)

60-60: Approve the update to github.com/cosmos/cosmos-db but verify specific changes.

The update to github.com/cosmos/cosmos-db to a specific commit suggests that it includes necessary fixes or features. However, it's crucial to verify the specific changes in this version to ensure they align with the project's requirements and do not introduce instability.

Run the following script to verify the specific changes included in the updated version:

#!/bin/bash
# Description: Verify the specific changes in the updated version of `github.com/cosmos/cosmos-db`.

# Test: Fetch the commit log for the specific version. Expect: Relevant changes that align with the PR's objectives.
git log --oneline v1.0.2..v1.0.3-0.20240829004618-717cba019b33

179-179: Caution advised for the replace directive of github.com/cosmos/iavl.

The replace directive points to a beta version of github.com/cosmos/iavl. While this may be necessary for specific features or fixes, using a beta version can introduce risks related to stability and compatibility. It's important to verify that this version supports the PR's objectives and does not compromise other project dependencies.

Run the following script to verify the impact of using this beta version:

#!/bin/bash
# Description: Verify the impact of using the beta version of `github.com/cosmos/iavl`.

# Test: Check for open issues or breaking changes related to this version. Expect: No critical issues that could affect the project's stability.
gh issue list --repo github.com/cosmos/iavl --search "v1.0.0-beta.1.0.20240813194616-eb5078efcf9e in:title"

x/circuit/go.mod
@@ -172,11 +172,14 @@ require (

replace github.com/cosmos/cosmos-sdk => ../../.

replace github.com/cosmos/iavl => github.com/cosmos/iavl v1.0.0-beta.1.0.20240813194616-eb5078efcf9e
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution: Replacement directive for github.com/cosmos/iavl.

The replacement with beta version v1.0.0-beta.1.0.20240813194616-eb5078efcf9e should be approached with caution. Beta versions can introduce instability. Ensure comprehensive testing to confirm that the features and fixes in this specific build integrate well without issues.

kocubinski
kocubinski reviewed Aug 30, 2024
View reviewed changes
baseapp/baseapp.go
@@ -194,7 +194,7 @@ type BaseApp struct {
// variadic number of option functions, which act on the BaseApp to set
// configuration choices.
func NewBaseApp(
name string, logger log.Logger, db dbm.DB, txDecoder sdk.TxDecoder, options ...func(*BaseApp),
name string, logger log.Logger, db corestore.KVStoreWithBatch, txDecoder sdk.TxDecoder, options ...func(*BaseApp),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does baseapp use the BatchCreator interface?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RootStore requires it

kocubinski
kocubinski reviewed Aug 30, 2024
View reviewed changes
go.mod
@@ -23,7 +23,7 @@ require (
github.com/cometbft/cometbft v1.0.0-rc1
github.com/cometbft/cometbft/api v1.0.0-rc.1
github.com/cosmos/btcutil v1.0.5
github.com/cosmos/cosmos-db v1.0.2
github.com/cosmos/cosmos-db v1.0.3-0.20240829004618-717cba019b33
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the update to cosmos-db?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is needed temporarily since it only updates the interface , there were some conflicts in test.

kocubinski
kocubinski reviewed Aug 30, 2024
View reviewed changes
simapp/v2/go.mod
@@ -280,6 +280,7 @@ replace (
github.com/99designs/keyring => github.com/cosmos/keyring v1.2.0
// Simapp always use the latest version of the cosmos-sdk
github.com/cosmos/cosmos-sdk => ../../.
github.com/cosmos/iavl => github.com/cosmos/iavl v1.0.0-beta.1.0.20240813194616-eb5078efcf9e
Copy link
Member

@kocubinski kocubinski Aug 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a git hash ref right? can a release version of iavl be used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will update it at the last PR of removing cosmos-db

@github-actions GitHub Actions
Copy link
Contributor

@cool-develope your pull request is missing a changelog!

@github-actions github-actions bot removed the C:Cosmovisor Issues and PR related to Cosmovisor label Aug 30, 2024
coderabbitai[bot]
coderabbitai bot reviewed Aug 30, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

Outside diff range, codebase verification and nitpick comments (1)
x/params/go.mod (1)

182-182: Incorrect replacement path in go.mod file.

The replacement path for cosmossdk.io/store in the go.mod file is incorrect. The specified path ../../store does not exist. Instead, there is a store/ directory at the root level of the repository. Please update the path to point to the correct directory to ensure proper functionality.

  • Update the path in go.mod to store/.
Analysis chain

Approve the replacement path update but verify functionality.

The update of the replacement path for cosmossdk.io/store to ../../store is approved, aligning with the PR's objectives to enhance internal dependency management. It is important to verify that the new path is correctly set up and functional within the project's structure.

Run the following script to verify the path correctness and functionality:

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the correctness and functionality of the new store path.

# Test: Check if the directory exists and contains expected files.
ls -l ../../store

Length of output: 78

Script:

#!/bin/bash
# Search for the 'store' directory within the repository to check if it exists elsewhere.
fd -t d -i store

Length of output: 340

Review details

Configuration used: .coderabbit.yml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 9f1b36b and 0b3411f.

Files ignored due to path filters (35)
  • client/v2/go.sum is excluded by !**/*.sum
  • go.sum is excluded by !**/*.sum
  • orm/go.sum is excluded by !**/*.sum
  • runtime/v2/go.sum is excluded by !**/*.sum
  • server/v2/cometbft/go.sum is excluded by !**/*.sum
  • server/v2/go.sum is excluded by !**/*.sum
  • simapp/go.sum is excluded by !**/*.sum
  • simapp/v2/go.sum is excluded by !**/*.sum
  • store/go.sum is excluded by !**/*.sum
  • store/v2/go.sum is excluded by !**/*.sum
  • tests/go.sum is excluded by !**/*.sum
  • tests/systemtests/go.sum is excluded by !**/*.sum
  • tools/confix/go.sum is excluded by !**/*.sum
  • tools/hubl/go.sum is excluded by !**/*.sum
  • x/accounts/defaults/lockup/go.sum is excluded by !**/*.sum
  • x/accounts/defaults/multisig/go.sum is excluded by !**/*.sum
  • x/accounts/go.sum is excluded by !**/*.sum
  • x/auth/go.sum is excluded by !**/*.sum
  • x/authz/go.sum is excluded by !**/*.sum
  • x/bank/go.sum is excluded by !**/*.sum
  • x/circuit/go.sum is excluded by !**/*.sum
  • x/consensus/go.sum is excluded by !**/*.sum
  • x/distribution/go.sum is excluded by !**/*.sum
  • x/epochs/go.sum is excluded by !**/*.sum
  • x/evidence/go.sum is excluded by !**/*.sum
  • x/feegrant/go.sum is excluded by !**/*.sum
  • x/gov/go.sum is excluded by !**/*.sum
  • x/group/go.sum is excluded by !**/*.sum
  • x/mint/go.sum is excluded by !**/*.sum
  • x/nft/go.sum is excluded by !**/*.sum
  • x/params/go.sum is excluded by !**/*.sum
  • x/protocolpool/go.sum is excluded by !**/*.sum
  • x/slashing/go.sum is excluded by !**/*.sum
  • x/staking/go.sum is excluded by !**/*.sum
  • x/upgrade/go.sum is excluded by !**/*.sum
Files selected for processing (45)
  • baseapp/baseapp.go (3 hunks)
  • client/v2/go.mod (2 hunks)
  • go.mod (2 hunks)
  • orm/go.mod (1 hunks)
  • runtime/store.go (2 hunks)
  • runtime/v2/go.mod (1 hunks)
  • server/start.go (3 hunks)
  • server/v2/cometbft/go.mod (1 hunks)
  • server/v2/go.mod (1 hunks)
  • simapp/app.go (2 hunks)
  • simapp/app_di.go (2 hunks)
  • simapp/go.mod (2 hunks)
  • simapp/gomod2nix.toml (16 hunks)
  • simapp/sim_test.go (3 hunks)
  • simapp/simd/cmd/commands.go (3 hunks)
  • simapp/v2/go.mod (2 hunks)
  • store/go.mod (1 hunks)
  • store/types/store.go (3 hunks)
  • store/v2/go.mod (3 hunks)
  • tests/e2e/genutil/export_test.go (2 hunks)
  • tests/go.mod (2 hunks)
  • tests/systemtests/go.mod (1 hunks)
  • tools/confix/go.mod (1 hunks)
  • tools/hubl/go.mod (1 hunks)
  • x/accounts/defaults/lockup/go.mod (2 hunks)
  • x/accounts/defaults/multisig/go.mod (2 hunks)
  • x/accounts/go.mod (2 hunks)
  • x/auth/go.mod (2 hunks)
  • x/authz/go.mod (2 hunks)
  • x/bank/go.mod (2 hunks)
  • x/circuit/go.mod (2 hunks)
  • x/consensus/go.mod (2 hunks)
  • x/distribution/go.mod (2 hunks)
  • x/epochs/go.mod (2 hunks)
  • x/evidence/go.mod (2 hunks)
  • x/feegrant/go.mod (2 hunks)
  • x/gov/go.mod (2 hunks)
  • x/group/go.mod (2 hunks)
  • x/mint/go.mod (2 hunks)
  • x/nft/go.mod (2 hunks)
  • x/params/go.mod (2 hunks)
  • x/protocolpool/go.mod (2 hunks)
  • x/slashing/go.mod (2 hunks)
  • x/staking/go.mod (2 hunks)
  • x/upgrade/go.mod (2 hunks)
Files skipped from review due to trivial changes (11)
  • orm/go.mod
  • simapp/go.mod
  • tests/go.mod
  • tests/systemtests/go.mod
  • tools/confix/go.mod
  • tools/hubl/go.mod
  • x/accounts/defaults/multisig/go.mod
  • x/auth/go.mod
  • x/epochs/go.mod
  • x/gov/go.mod
  • x/slashing/go.mod
Files skipped from review as they are similar to previous changes (22)
  • baseapp/baseapp.go
  • client/v2/go.mod
  • runtime/v2/go.mod
  • server/v2/cometbft/go.mod
  • server/v2/go.mod
  • simapp/app.go
  • simapp/app_di.go
  • simapp/sim_test.go
  • store/go.mod
  • store/types/store.go
  • store/v2/go.mod
  • tests/e2e/genutil/export_test.go
  • x/accounts/go.mod
  • x/authz/go.mod
  • x/bank/go.mod
  • x/circuit/go.mod
  • x/consensus/go.mod
  • x/evidence/go.mod
  • x/feegrant/go.mod
  • x/mint/go.mod
  • x/nft/go.mod
  • x/staking/go.mod
Additional context used
Path-based instructions (3)
simapp/simd/cmd/commands.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

runtime/store.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

server/start.go (1)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.

Additional comments not posted (37)
simapp/simd/cmd/commands.go (3)

11-11: Approved import statement for corestore.

The addition of the corestore import is necessary for the new KVStoreWithBatch interface and aligns with the PR objectives.

134-134: Approved function signature change in appExport.

The change to use corestore.KVStoreWithBatch is in line with the PR objectives. Ensure that the integration of the new interface is thoroughly tested.

Verification successful

Integration of corestore.KVStoreWithBatch in appExport verified.

The appExport function has been updated to use corestore.KVStoreWithBatch in its signature, aligning with the PR objectives. The function is utilized in various command definitions, indicating its role in CLI operations. Ensure that these integrations are thoroughly tested to confirm correct functionality across all contexts.

  • File: simapp/simd/cmd/commands.go
  • Function: appExport
Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the integration of `corestore.KVStoreWithBatch` in `appExport`.

# Test: Search for the function usage. Expect: Only occurrences of the new signature.
rg --type go -A 5 $'appExport'

Length of output: 7819

119-119: Approved function signature change in newApp.

The change to use corestore.KVStoreWithBatch is in line with the PR objectives. Ensure that the integration of the new interface is thoroughly tested.

Verification successful

Integration of corestore.KVStoreWithBatch in newApp is verified.

The usage of corestore.KVStoreWithBatch in the newApp function is consistent and correctly integrated across the codebase. No issues were found with this change.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the integration of `corestore.KVStoreWithBatch` in `newApp`.

# Test: Search for the function usage. Expect: Only occurrences of the new signature.
rg --type go -A 5 $'newApp'

Length of output: 9171

Script:

#!/bin/bash
# Description: Search for the usage of `corestore.KVStoreWithBatch` within the `newApp` function.

# Test: Search for the specific usage of `corestore.KVStoreWithBatch` in the `newApp` function.
rg --type go 'corestore\.KVStoreWithBatch' -A 10

Length of output: 63611

x/protocolpool/go.mod (2)

56-56: Approved: Dependency update for github.com/cosmos/cosmos-db.

The update from v1.0.2 to v1.0.3-0.20240829004618-717cba019b33 is noted and approved. Ensure that this update aligns with the overall dependency management strategy and does not introduce any breaking changes.

175-175: Verify: Replace directive for github.com/cosmos/iavl.

The addition of a replace directive pointing to a beta version of iavl (v1.0.0-beta.1.0.20240813194616-eb5078efcf9e) is noted. Please verify the necessity and stability of this beta version in the project's context, especially since it's a significant dependency.

go.mod (1)

26-26: Dependency Update Acknowledged: github.com/cosmos/cosmos-db

The update to github.com/cosmos/cosmos-db from v1.0.2 to v1.0.3-0.20240829004618-717cba019b33 is noted. This change appears to be in line with the PR's objectives to update interfaces. Ensure to verify that this new version does not introduce any breaking changes or unexpected behaviors, especially since it's a pre-release version.

x/group/go.mod (1)

24-24: Dependency Update Acknowledged: github.com/cosmos/cosmos-db

The update to github.com/cosmos/cosmos-db from v1.0.2 to v1.0.3-0.20240829004618-717cba019b33 is noted. This change appears to be in line with the PR's objectives to update interfaces. Ensure to verify that this new version does not introduce any breaking changes or unexpected behaviors, especially since it's a pre-release version.

x/upgrade/go.mod (1)

18-18: Dependency Update Acknowledged: github.com/cosmos/cosmos-db

The update to github.com/cosmos/cosmos-db from v1.0.2 to v1.0.3-0.20240829004618-717cba019b33 is noted. This change appears to be in line with the PR's objectives to update interfaces. Ensure to verify that this new version does not introduce any breaking changes or unexpected behaviors, especially since it's a pre-release version.

simapp/v2/go.mod (1)

36-36: Dependency Version Updated Appropriately

The update of github.com/cosmos/cosmos-db from v1.0.2 to v1.0.3-0.20240829004618-717cba019b33 is noted. This change aligns with the PR's objectives to streamline dependencies. However, it's generally best practice to use stable release versions rather than specific commit hashes unless necessary for specific fixes or features.

simapp/gomod2nix.toml (20)

5-6: Approved: Dependency version and hash updated for buf.build/gen/go/cometbft/cometbft/protocolbuffers/go.

The version update from v1.34.1-20240312114316-c0d3497e35d6.1 to v1.34.2-20240701160653-fedbb9acfd2f.2 and the corresponding hash update are noted. Please ensure to verify the integrity and compatibility of the new version.

8-9: Approved: Dependency version and hash updated for buf.build/gen/go/cosmos/gogo-proto/protocolbuffers/go.

The version update from v1.34.1-20240130113600-88ef6483f90f.1 to v1.34.2-20240130113600-88ef6483f90f.2 and the corresponding hash update are noted. Please ensure to verify the integrity and compatibility of the new version.

11-12: Approved: Dependency version and hash updated for cloud.google.com/go.

The version update from v0.112.2 to v0.115.1 and the corresponding hash update are noted. Please ensure to verify the integrity and compatibility of the new version.

14-15: Approved: Dependency version and hash updated for cloud.google.com/go/auth.

The version update from v0.2.2 to v0.8.1 and the corresponding hash update are noted. Please ensure to verify the integrity and compatibility of the new version.

17-18: Approved: Dependency version and hash updated for cloud.google.com/go/auth/oauth2adapt.

The version update from v0.2.1 to v0.2.4 and the corresponding hash update are noted. Please ensure to verify the integrity and compatibility of the new version.

20-21: Approved: Dependency version and hash updated for cloud.google.com/go/compute/metadata.

The version update from v0.3.0 to v0.5.0 and the corresponding hash update are noted. Please ensure to verify the integrity and compatibility of the new version.

23-24: Approved: Dependency version and hash updated for cloud.google.com/go/iam.

The version update from v1.1.7 to v1.1.13 and the corresponding hash update are noted. Please ensure to verify the integrity and compatibility of the new version.

26-27: Approved: Dependency version and hash updated for cloud.google.com/go/storage.

The version update from v1.40.0 to v1.43.0 and the corresponding hash update are noted. Please ensure to verify the integrity and compatibility of the new version.

29-30: Approved: New dependency cosmossdk.io/depinject added.

The addition of cosmossdk.io/depinject with version v1.0.0 and the corresponding hash is noted. Please ensure to verify the integrity and compatibility of the new version.

35-36: Approved: New dependency cosmossdk.io/log added.

The addition of cosmossdk.io/log with version v1.4.1 and the corresponding hash is noted. Please ensure to verify the integrity and compatibility of the new version.

41-42: Approved: New dependency cosmossdk.io/schema added.

The addition of cosmossdk.io/schema with version v0.2.0 and the corresponding hash is noted. Please ensure to verify the integrity and compatibility of the new version.

63-64: Approved: Dependency version and hash updated for github.com/aws/aws-sdk-go.

The version update from v1.51.25 to v1.55.5 and the corresponding hash update are noted. Please ensure to verify the integrity and compatibility of the new version.

75-75: Approved: Dependency version and hash updated for github.com/bgentry/speakeasy.

The version update from v0.1.1-0.20220910012023-760eaf8b6816 to v0.2.0 and the corresponding hash update are noted. Please ensure to verify the integrity and compatibility of the new version.

108-109: Approved: Dependency version and hash updated for github.com/cometbft/cometbft.

The version update to v1.0.0-rc1 and the corresponding hash update are noted. Please ensure to verify the integrity and compatibility of the new version.

120-121: Approved: Dependency version and hash updated for github.com/cosmos/cosmos-db.

The version update from v1.0.2 to v1.0.3-0.20240829004618-717cba019b33 and the corresponding hash update are noted. Please ensure to verify the integrity and compatibility of the new version.

126-127: Approved: Dependency version and hash updated for github.com/cosmos/crypto.

The version update from v0.0.0-20240309083813-82ed2537802e to v0.1.2 and the corresponding hash update are noted. Please ensure to verify the integrity and compatibility of the new version.

135-136: Approved: Dependency version and hash updated for github.com/cosmos/gogoproto.

The version update from v1.5.0 to v1.7.0 and the corresponding hash update are noted. Please ensure to verify the integrity and compatibility of the new version.

138-140: Approved: Dependency version and hash updated for github.com/cosmos/iavl.

The version update to v1.0.0-beta.1.0.20240813194616-eb5078efcf9e and the corresponding hash update are noted. Please ensure to verify the integrity and compatibility of the new version.

142-143: Approved: Dependency version and hash updated for github.com/cosmos/ics23/go.

The version update to v0.11.0 and the corresponding hash update are noted. Please ensure to verify the integrity and compatibility of the new version.

148-149: Approved: Dependency version and hash updated for github.com/creachadair/atomicfile.

The version update from v0.3.4 to v0.3.5 and the corresponding hash update are noted. Please ensure to verify the integrity and compatibility of the new version.

server/start.go (2)

121-121: Approved: Update to DBOpener function signature.

The change in the DBOpener function signature from returning dbm.DB to corestore.KVStoreWithBatch aligns with the PR's objectives. Ensure that all references and usages of DBOpener across the codebase have been updated to handle the new return type correctly.

Verification successful

Verification Successful: DBOpener Usage Updated Correctly

The DBOpener function's new return type is correctly integrated within the server/start.go file. The function is used consistently with the updated signature, and there are no other usages across the codebase that require modification.

  • The function is assigned a default implementation if not provided.
  • The invocation of DBOpener is consistent with the new return type.
Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify all usages of `DBOpener` handle the new return type correctly.

# Test: Search for the function usage. Expect: Only occurrences of the new signature.
rg --type go -A 5 $'DBOpener'

Length of output: 1679

754-754: Approved: Update to testnetify function signature.

The update in the testnetify function to accept corestore.KVStoreWithBatch instead of dbm.DB is consistent with the PR's goal of integrating the corestore package. Ensure that the function's implementation properly handles the new interface, especially error scenarios and batch operations.

x/params/go.mod (2)

175-175: Approve the replacement but suggest caution.

The replacement of github.com/cosmos/iavl with a specific beta version (v1.0.0-beta.1.0.20240813194616-eb5078efcf9e) is approved. However, it is crucial to exercise caution with beta versions due to potential instability. Ensure thorough testing is conducted to confirm its reliability in your environment.

Run the following script to verify the stability and compatibility:

15-15: Approve the dependency version update but verify stability.

The update to github.com/cosmos/cosmos-db from v1.0.2 to v1.0.3-0.20240829004618-717cba019b33 is noted. While this update likely includes necessary changes, it is important to verify the stability and compatibility of this pre-release version in the project's context.

Run the following script to verify the stability and compatibility:

x/accounts/defaults/lockup/go.mod (2)

48-48: Approve the dependency update but verify compatibility and stability.

The update to github.com/cosmos/cosmos-db to a newer version is noted. It's crucial to ensure that this update integrates well with the rest of the project and does not introduce any breaking changes.

Run the following script to verify the compatibility and stability of the new version:

153-153: Approve the replace directive but verify stability and compatibility.

The replace directive for github.com/cosmos/iavl to a specific beta version is noted. While this may be necessary for accessing new features or fixes, it's important to verify that this version does not introduce instability or compatibility issues with other parts of the project.

Run the following script to verify the stability and compatibility of the iavl beta version:

x/distribution/go.mod (2)

64-64: Approve the dependency update but verify compatibility and stability.

The update to github.com/cosmos/cosmos-db to a newer version is noted. It's crucial to ensure that this update integrates well with the rest of the project and does not introduce any breaking changes.

Run the following script to verify the compatibility and stability of the new version:

179-179: Approve the replace directive but verify stability and compatibility.

The replace directive for github.com/cosmos/iavl to a specific beta version is noted. While this may be necessary for accessing new features or fixes, it's important to verify that this version does not introduce instability or compatibility issues with other parts of the project.

Run the following script to verify the stability and compatibility of the iavl beta version:

runtime/store.go
it, err := s.store.Iterator(start, end)
if err != nil {
panic(err)
}
return it
}

func (s kvStoreAdapter) ReverseIterator(start, end []byte) dbm.Iterator {
func (s kvStoreAdapter) ReverseIterator(start, end []byte) store.Iterator {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improve error handling in the ReverseIterator method.

Similar to the Iterator method, consider enhancing error handling by returning the error instead of using panic.

Propose a refactor to improve error handling:

-func (s kvStoreAdapter) ReverseIterator(start, end []byte) store.Iterator {
-	it, err := s.store.ReverseIterator(start, end)
-	if err != nil {
-		panic(err)
-	}
-	return it
+func (s kvStoreAdapter) ReverseIterator(start, end []byte) (store.Iterator, error) {
+	return s.store.ReverseIterator(start, end)
}

Committable suggestion was skipped due to low confidence.

runtime/store.go
@@ -162,15 +160,15 @@
}
}

func (s kvStoreAdapter) Iterator(start, end []byte) dbm.Iterator {
func (s kvStoreAdapter) Iterator(start, end []byte) store.Iterator {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improve error handling in the Iterator method.

The method currently uses panic to handle errors, which can lead to system crashes. Consider returning the error to the caller instead, allowing for more graceful error handling and recovery.

Propose a refactor to improve error handling:

-func (s kvStoreAdapter) Iterator(start, end []byte) store.Iterator {
-	it, err := s.store.Iterator(start, end)
-	if err != nil {
-		panic(err)
-	}
-	return it
+func (s kvStoreAdapter) Iterator(start, end []byte) (store.Iterator, error) {
+	return s.store.Iterator(start, end)
}

Committable suggestion was skipped due to low confidence.

@cool-develope cool-develope added this pull request to the merge queue Aug 30, 2024
Merged via the queue into main with commit ce4fb98 Aug 30, 2024
99 of 100 checks passed
@cool-develope cool-develope deleted the decouple/cosmos-db branch August 30, 2024 21:29
mergify bot pushed a commit that referenced this pull request Aug 30, 2024
@cool-develope @mergify
feat: replace the cosmos-db.DB interface with core/store interface (
e3c0400 
#21450)

(cherry picked from commit ce4fb98)

# Conflicts:
#	orm/go.mod
#	orm/go.sum
#	orm/internal/testkv/db.go
#	orm/model/ormdb/module_test.go
#	runtime/v2/go.mod
#	runtime/v2/go.sum
#	server/v2/go.mod
#	server/v2/go.sum
#	store/cache/cache_test.go
#	store/cachekv/store_test.go
#	store/cachemulti/store.go
#	store/dbadapter/store.go
#	store/go.mod
#	store/go.sum
#	store/iavl/store.go
#	store/iavl/store_test.go
#	store/iavl/tree.go
#	store/iavl/tree_test.go
#	store/prefix/store_test.go
#	store/pruning/manager.go
#	store/pruning/manager_test.go
#	store/rootmulti/dbadapter.go
#	store/rootmulti/snapshot_test.go
#	store/rootmulti/store.go
#	store/rootmulti/store_test.go
#	store/store.go
#	store/types/store.go
#	store/v2/commitment/iavl/tree.go
#	store/v2/go.mod
#	store/v2/go.sum
#	tools/hubl/go.mod
#	tools/hubl/go.sum
#	x/accounts/defaults/lockup/go.mod
#	x/accounts/defaults/lockup/go.sum
#	x/accounts/defaults/multisig/go.mod
#	x/accounts/defaults/multisig/go.sum
#	x/accounts/go.mod
#	x/accounts/go.sum
#	x/auth/go.mod
#	x/auth/go.sum
#	x/bank/go.mod
#	x/bank/go.sum
#	x/circuit/go.mod
#	x/circuit/go.sum
#	x/consensus/go.mod
#	x/consensus/go.sum
#	x/distribution/go.mod
#	x/distribution/go.sum
#	x/epochs/go.mod
#	x/epochs/go.sum
#	x/evidence/go.mod
#	x/evidence/go.sum
#	x/feegrant/go.mod
#	x/feegrant/go.sum
#	x/gov/go.mod
#	x/gov/go.sum
#	x/group/go.mod
#	x/group/go.sum
#	x/mint/go.mod
#	x/mint/go.sum
#	x/nft/go.mod
#	x/nft/go.sum
#	x/params/go.mod
#	x/params/go.sum
#	x/protocolpool/go.mod
#	x/protocolpool/go.sum
#	x/slashing/go.mod
#	x/slashing/go.sum
#	x/staking/go.mod
#	x/staking/go.sum
@mergify mergify bot mentioned this pull request Aug 30, 2024
Merged
12 tasks
julienrbrt added a commit that referenced this pull request Sep 6, 2024
@julienrbrt
feat: replace the cosmos-db.DB interface with core/store interface (b…
dbb3d04 
…ackport #21450)
julienrbrt added a commit that referenced this pull request Sep 6, 2024
@mergify @julienrbrt
feat: replace the cosmos-db.DB interface with core/store interfac…
889becd 
…e (backport #21450) (#21490)

Co-authored-by: Julien Robert <julien@rbrt.fr>
github-merge-queue bot pushed a commit that referenced this pull request Sep 6, 2024
@julienrbrt
chore: cleanups after #21450 (#21573)
e9d72f5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kocubinski kocubinski kocubinski left review comments

@coderabbitai coderabbitai coderabbitai left review comments

@tac0turtle tac0turtle tac0turtle approved these changes

@julienrbrt julienrbrt julienrbrt approved these changes

@facundomedica facundomedica Awaiting requested review from facundomedica facundomedica is a code owner

@akhilkumarpilli akhilkumarpilli Awaiting requested review from akhilkumarpilli akhilkumarpilli is a code owner

@lucaslopezf lucaslopezf Awaiting requested review from lucaslopezf lucaslopezf is a code owner

@testinginprod testinginprod Awaiting requested review from testinginprod testinginprod is a code owner

@JulianToledano JulianToledano Awaiting requested review from JulianToledano JulianToledano is a code owner

@ziscky ziscky Awaiting requested review from ziscky

@raynaudoe raynaudoe Awaiting requested review from raynaudoe

@hieuvubk hieuvubk Awaiting requested review from hieuvubk hieuvubk is a code owner

@alpe alpe Awaiting requested review from alpe

@sontrinh16 sontrinh16 Awaiting requested review from sontrinh16

@aaronc aaronc Awaiting requested review from aaronc aaronc is a code owner

Assignees
No one assigned
Labels
backport/v0.52.x PR scheduled for inclusion in the v0.52's next stable release C:CLI C:Confix Issues and PR related to Confix C:Hubl Tool: Hubl C:orm C:server/v2 cometbft C:server/v2 Issues related to server/v2 C:Store C:x/accounts/lockup C:x/accounts/multisig C:x/accounts C:x/auth C:x/authz C:x/bank C:x/circuit C:x/consensus C:x/distribution distribution module related C:x/epochs C:x/evidence C:x/feegrant C:x/genutil genutil module issues C:x/gov C:x/group C:x/mint C:x/nft C:x/params C:x/protocolpool C:x/slashing C:x/staking C:x/upgrade Type: ADR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cool-develope @tac0turtle @kocubinski @julienrbrt