Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(mempool)!: match server/v2/cometbft and sdk mempool interface #21744

Merged
merged 13 commits into from
Sep 18, 2024
Merged

refactor(mempool)!: match server/v2/cometbft and sdk mempool interface #21744

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
741842f
feat(server/v2/cometbft): wire mempool config
julienrbrt Sep 16, 2024
55edf6c
lint
julienrbrt Sep 16, 2024
6c1ca6d
wording
julienrbrt Sep 16, 2024
f2eb295
refactor(mempool)!: match server/v2/cometbft and sdk mempool interface
julienrbrt Sep 16, 2024
c355618
updates
julienrbrt Sep 16, 2024
94c6858
feedback
julienrbrt Sep 16, 2024
99ff2a4
typo
julienrbrt Sep 16, 2024
d3ccd44
build
julienrbrt Sep 16, 2024
efd4be2
Merge branch 'main' into julien/mempool-interface
julienrbrt Sep 16, 2024
572ec03
cl
julienrbrt Sep 16, 2024
1990634
Merge branch 'main' into julien/mempool-interface
julienrbrt Sep 16, 2024
c3ed1fa
Merge branch 'main' into julien/mempool-interface
julienrbrt Sep 17, 2024
ee627c9
fix test
julienrbrt Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
updates
  • Loading branch information
@julienrbrt
julienrbrt committed Sep 16, 2024
commit c3556189830573dce12e17d1caf520a65442afcd
3 changes: 3 additions & 0 deletions server/v2/cometbft/mempool/noop.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,11 @@ import (
"context"

"cosmossdk.io/core/transaction"

sdk "github.com/cosmos/cosmos-sdk/types"
)

var _ Mempool[sdk.Tx] = (*NoOpMempool[sdk.Tx])(nil) // verify interface at compile time
var _ Mempool[transaction.Tx] = (*NoOpMempool[transaction.Tx])(nil)

// NoOpMempool defines a no-op mempool. Transactions are completely discarded and
Expand Down
Loading