Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update go #3169

Merged
merged 1 commit into from
Dec 19, 2018
Merged

update go #3169

merged 1 commit into from
Dec 19, 2018

Conversation

zramsay
Copy link
Contributor

@zramsay zramsay commented Dec 19, 2018

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Dec 19, 2018

Codecov Report

Merging #3169 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #3169   +/-   ##
========================================
  Coverage    54.88%   54.88%           
========================================
  Files          132      132           
  Lines         9446     9446           
========================================
  Hits          5184     5184           
  Misses        3943     3943           
  Partials       319      319

@jackzampolin jackzampolin merged commit 5241c3c into develop Dec 19, 2018
@jackzampolin jackzampolin deleted the latest-go branch December 19, 2018 19:43
@mircea-c
Copy link

Guys, you broke the macos build... That GO_VERSION variable was there for a reason...

@jackzampolin
Copy link
Member

That $GO_VERSION was causing the localnet CI to fail!

@zramsay
Copy link
Contributor Author

zramsay commented Dec 19, 2018

no that's my bad, i removed the wrong one when fixing ^ that

@zramsay zramsay mentioned this pull request Dec 19, 2018
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants