Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Removed complexity from docs deployment job #3832

Merged
merged 1 commit into from
Mar 8, 2019

Conversation

mircea-c
Copy link

@mircea-c mircea-c commented Mar 8, 2019

Closes https://github.com/tendermint/devops/issues/198
Successful test here

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@mircea-c mircea-c added T: CI Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. labels Mar 8, 2019
@mircea-c mircea-c self-assigned this Mar 8, 2019
@codecov
Copy link

codecov bot commented Mar 8, 2019

Codecov Report

Merging #3832 into develop will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #3832      +/-   ##
===========================================
- Coverage    60.95%   60.92%   -0.03%     
===========================================
  Files          192      192              
  Lines        14323    14323              
===========================================
- Hits          8731     8727       -4     
- Misses        5023     5027       +4     
  Partials       569      569

@@ -280,7 +280,22 @@ jobs:
- run:
name: Trigger website build
command: |
chamber exec cosmos-sdk -- start_website_build
curl --silent \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

http://gph.is/Zfh9X7

curl ❤️ jq

@jackzampolin
Copy link
Member

Nice @mircea-c !

@jackzampolin jackzampolin merged commit 6142f90 into develop Mar 8, 2019
@jackzampolin jackzampolin deleted the mircea/devops198 branch March 8, 2019 17:03
@alessio
Copy link
Contributor

alessio commented Mar 10, 2019

This should not be mentioned in changelog. It's not a user facing change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: CI Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants