Fix docker_image ci job #4004
Merged
Fix docker_image ci job #4004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alessio
force-pushed
the
alessio/fix-docker-image
branch
from
909304d
to
dcbc009
Compare
Codecov Report
@@ Coverage Diff @@
## develop #4004 +/- ##
==========================================
+ Coverage 59.76% 59.8% +0.04%
==========================================
Files 211 199 -12
Lines 15055 14727 -328
==========================================
- Hits 8998 8808 -190
+ Misses 5435 5326 -109
+ Partials 622 593 -29 |
alessio
force-pushed
the
alessio/fix-docker-image
branch
2 times, most recently
from
21fb42c
to
e34a766
Compare
alessio
requested review from
cwgoes,
ebuchman and
rigelrozanski
as code owners
sabau
approved these changes
Mar 29, 2019
| docker login -u $DOCKER_USER -p $DOCKER_PASS | ||
| docker push tendermint/gaia:$GAIAD_VERSION | ||
| if [ -z "${GAIAD_VERSION}" ]; then | ||
| docker build . |
There was a problem hiding this comment.
👍 seems healthy to fail always
alexanderbez
approved these changes
Mar 29, 2019
|
We should add a pending log entry for a bugfix. |
- Always build regardless of the branch; push only from develop and master. - Add curl to packages dependencies in Dockerfile to allow golangci-lint to be downloaded. Closes: #3977
alessio
force-pushed
the
alessio/fix-docker-image
branch
from
e34a766
to
887e98c
Compare
|
Done @alexanderbez |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
push only from develop and master.
to allow golangci-lint to be downloaded.
Closes: #3977
docs/)sdkch add [section] [stanza] [message]Files changedin the github PR explorerFor Admin Use: