Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Remove dep and vendor from doc and version. #4064

Merged
merged 11 commits into from
Apr 8, 2019
Merged

R4R: Remove dep and vendor from doc and version. #4064

merged 11 commits into from
Apr 8, 2019

Conversation

yangyanqing
Copy link
Contributor

@yangyanqing yangyanqing commented Apr 6, 2019

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: sdkch add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Apr 6, 2019

Codecov Report

Merging #4064 into develop will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #4064      +/-   ##
===========================================
- Coverage    60.01%   59.99%   -0.02%     
===========================================
  Files          212      212              
  Lines        15107    15107              
===========================================
- Hits          9066     9064       -2     
- Misses        5420     5422       +2     
  Partials       621      621

@codecov
Copy link

codecov bot commented Apr 6, 2019

Codecov Report

Merging #4064 into develop will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #4064      +/-   ##
===========================================
+ Coverage    60.01%   60.02%   +0.01%     
===========================================
  Files          212      212              
  Lines        15107    15107              
===========================================
+ Hits          9066     9068       +2     
+ Misses        5420     5418       -2     
  Partials       621      621

Copy link
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go.sum hashsum is no-go - at least until we introduce reproducible builds.

Makefile Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
version/version.go Show resolved Hide resolved
version/version.go Show resolved Hide resolved
version/version.go Show resolved Hide resolved
@yangyanqing
Copy link
Contributor Author

Thank you for your careful review! @alessio

Copy link
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GoModHash should be GoSumHash

Makefile Outdated Show resolved Hide resolved
docs/gaia/installation.md Outdated Show resolved Hide resolved
docs/translations/cn/gaia/installation.md Outdated Show resolved Hide resolved
version/version.go Outdated Show resolved Hide resolved
version/version.go Outdated Show resolved Hide resolved
version/version.go Outdated Show resolved Hide resolved
version/version.go Outdated Show resolved Hide resolved
version/version.go Outdated Show resolved Hide resolved
alessio and others added 8 commits April 7, 2019 10:19
Co-Authored-By: yangyanqing <f.yang@hashgard.com>
Co-Authored-By: yangyanqing <f.yang@hashgard.com>
Co-Authored-By: yangyanqing <f.yang@hashgard.com>
Co-Authored-By: yangyanqing <f.yang@hashgard.com>
Co-Authored-By: yangyanqing <f.yang@hashgard.com>
Co-Authored-By: yangyanqing <f.yang@hashgard.com>
Co-Authored-By: yangyanqing <f.yang@hashgard.com>
Co-Authored-By: yangyanqing <f.yang@hashgard.com>
Copy link
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACKed

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TestedACK.

@alexanderbez alexanderbez merged commit 9e7440a into cosmos:develop Apr 8, 2019
@yangyanqing yangyanqing deleted the frank/remove-vendorDirHash branch April 15, 2019 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants