Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move tools to contrib #4073

Merged
merged 4 commits into from
Apr 9, 2019
Merged

Move tools to contrib #4073

merged 4 commits into from
Apr 9, 2019

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Apr 9, 2019 •
edited
Loading

Rename sdkch to clog.

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added a relevant changelog entry: sdkch add [section] [stanza] [message]
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Apr 9, 2019 •
edited
Loading

Codecov Report

Merging #4073 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #4073   +/-   ##
========================================
  Coverage    59.94%   59.94%           
========================================
  Files          212      212           
  Lines        15104    15104           
========================================
  Hits          9054     9054           
  Misses        5428     5428           
  Partials       622      622

fedekunze
fedekunze approved these changes Apr 9, 2019
View reviewed changes
Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@alessio
Copy link
Contributor Author

alessio commented Apr 9, 2019

This is just tooling, one ACK is possibly sufficient.

@alessio alessio merged commit 1505c2b into develop Apr 9, 2019
@alessio alessio deleted the alessio/tools-to-contrib branch April 9, 2019 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedekunze fedekunze fedekunze approved these changes

@cwgoes cwgoes Awaiting requested review from cwgoes

@ebuchman ebuchman Awaiting requested review from ebuchman

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alessio @fedekunze