Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow user to pass a custom BUILDDIR to test_cli #4127

Merged
merged 4 commits into from
Apr 16, 2019
Merged

Allow user to pass a custom BUILDDIR to test_cli #4127

merged 4 commits into from
Apr 16, 2019

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Apr 16, 2019

Preparation work for cli tests further parallelisation.

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added a relevant changelog entry: sdkch add [section] [stanza] [message]
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alessio
Allow user to pass a custom BUILDDIR
46a5b02 
Preparation work for cli tests further parallelisation.
@alessio alessio requested a review from sabau April 16, 2019 02:15
@codecov
Copy link

codecov bot commented Apr 16, 2019 •
edited
Loading

Codecov Report

Merging #4127 into develop will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           develop   #4127      +/-   ##
==========================================
+ Coverage    60.09%   60.1%   +0.01%     
==========================================
  Files          211     211              
  Lines        15134   15134              
==========================================
+ Hits          9095    9097       +2     
+ Misses        5417    5415       -2     
  Partials       622     622

rigelrozanski
rigelrozanski approved these changes Apr 16, 2019
View reviewed changes
Copy link
Contributor

@rigelrozanski rigelrozanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

fedekunze
fedekunze reviewed Apr 16, 2019
View reviewed changes
Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change for readability

cmd/gaia/cli_test/test_helpers.go Outdated Show resolved Hide resolved
fedekunze
fedekunze approved these changes Apr 16, 2019
View reviewed changes
Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool ! thanks @alessio

@alessio alessio merged commit 9cdd1d3 into develop Apr 16, 2019
@alessio alessio deleted the integration-test-custom-build-dir branch April 16, 2019 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rigelrozanski rigelrozanski rigelrozanski approved these changes

@fedekunze fedekunze fedekunze approved these changes

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

@sabau sabau Awaiting requested review from sabau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alessio @rigelrozanski @fedekunze