Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove client/utils dep on gaia #4246

Merged
merged 1 commit into from
May 1, 2019

Conversation

alessio
Copy link
Contributor

@alessio alessio commented May 1, 2019

Prep work for moving gaia out of the sdk repository.

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented May 1, 2019

Codecov Report

Merging #4246 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4246      +/-   ##
==========================================
+ Coverage   60.42%   60.43%   +0.01%     
==========================================
  Files         218      218              
  Lines       15421    15421              
==========================================
+ Hits         9318     9320       +2     
+ Misses       5452     5450       -2     
  Partials      651      651

1 similar comment
@codecov
Copy link

codecov bot commented May 1, 2019

Codecov Report

Merging #4246 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4246      +/-   ##
==========================================
+ Coverage   60.42%   60.43%   +0.01%     
==========================================
  Files         218      218              
  Lines       15421    15421              
==========================================
+ Hits         9318     9320       +2     
+ Misses       5452     5450       -2     
  Partials      651      651

Copy link
Member

@jackzampolin jackzampolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Common sense change

@alessio alessio merged commit 466e46b into master May 1, 2019
@alessio alessio deleted the alessio/gaia-split-prep-decouple-client-utils-gaia branch May 1, 2019 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants