Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow generate-only to fully operate offline #4306

Merged
merged 10 commits into from
May 8, 2019

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented May 8, 2019

#4234 did not fully prohibit --generate-only from working offline. This PR forces --generate-only to work offline and removes a lot of cruft from the tx generation process all-together.

closes: #4305


  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: clog add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alexanderbez alexanderbez marked this pull request as ready for review May 8, 2019 13:49
@codecov
Copy link

codecov bot commented May 8, 2019

Codecov Report

Merging #4306 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #4306      +/-   ##
==========================================
- Coverage   59.12%   59.11%   -0.01%     
==========================================
  Files         217      217              
  Lines       14605    14589      -16     
==========================================
- Hits         8635     8625      -10     
+ Misses       5332     5326       -6     
  Partials      638      638

Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@alexanderbez alexanderbez merged commit 85ffce5 into master May 8, 2019
@alexanderbez alexanderbez deleted the bez/4305-gen-only-offline branch May 8, 2019 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

generate-only still requires node access
3 participants