R4R: Community pool spend proposal #4329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4329 +/- ##
=========================================
- Coverage 58.08% 57.2% -0.88%
=========================================
Files 235 241 +6
Lines 14881 15125 +244
=========================================
+ Hits 8643 8653 +10
- Misses 5608 5842 +234
Partials 630 630 |
cwgoes
requested review from
alessio,
alexanderbez,
jackzampolin and
rigelrozanski
as code owners
cwgoes
changed the title
alexanderbez
suggested changes
May 20, 2019
There was a problem hiding this comment.
Great job @cwgoes, looks very clean. I left a few minor bits of feedback 👌
Co-Authored-By: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
alexanderbez
approved these changes
May 20, 2019
There was a problem hiding this comment.
ACK. Thanks @cwgoes. Can you create a corresponding PR in Gaia, which just points to this branch for now?
5 tasks
|
rigelrozanski
approved these changes
May 20, 2019
alessio
suggested changes
May 20, 2019
alessio
approved these changes
May 21, 2019
alessio
pushed a commit
to cosmos/gaia
that referenced
this pull request
May 21, 2019
Closed
4 tasks
bchainexpt
pushed a commit
to bchainexpt/Blockchain-wallet-andorid-app
that referenced
this pull request
Apr 4, 2022
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
Implement the "CommunityPoolSpendProposal" as described in Cosmos Hub proposal 7. Also a useful test of Git flow for merging features passed in governance proposals.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the "CommunityPoolSpendProposal" as described in Cosmos Hub proposal 7.
Blocked on passage of proposal 7 - edit: passed.
Probably blocked on #4159 - edit: merged.
Also a useful test of Git flow for merging features passed in governance proposals.
docs/)clog add [section] [stanza] [message]Files changedin the github PR explorerFor Admin Use: