Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOCS: Consolidate Intro Material #4376

Merged
merged 3 commits into from
May 23, 2019
Merged

DOCS: Consolidate Intro Material #4376

merged 3 commits into from
May 23, 2019

Conversation

gamarin2
Copy link
Contributor

@gamarin2 gamarin2 commented May 20, 2019 •
edited
Loading

Consolidate intro material + add app-specific blockchain section

Closes #4358

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: clog add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@gamarin2 gamarin2 added the T:Docs Changes and features related to documentation. label May 20, 2019
@codecov
Copy link

codecov bot commented May 20, 2019 •
edited
Loading

Codecov Report

Merging #4376 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4376   +/-   ##
=======================================
  Coverage   58.09%   58.09%           
=======================================
  Files         235      235           
  Lines       14879    14879           
=======================================
  Hits         8644     8644           
  Misses       5607     5607           
  Partials      628      628

@alexanderbez alexanderbez requested a review from sabau May 20, 2019 15:47
hschoenburg
hschoenburg reviewed May 20, 2019
View reviewed changes
Copy link
Contributor

@hschoenburg hschoenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff. Had a few minor suggestions, spelling, etc.

docs/intro/README.md Outdated Show resolved Hide resolved
docs/intro/sdk-app-architecture.md Outdated Show resolved Hide resolved
docs/intro/why-app-specific.md Outdated Show resolved Hide resolved
docs/intro/why-app-specific.md Outdated Show resolved Hide resolved
docs/intro/why-app-specific.md Outdated Show resolved Hide resolved
docs/intro/why-app-specific.md Outdated Show resolved Hide resolved
@jackzampolin jackzampolin merged commit e53d233 into master May 23, 2019
@jackzampolin jackzampolin deleted the gamarin/docs-update branch May 23, 2019 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hschoenburg hschoenburg hschoenburg left review comments

@alexanderbez alexanderbez alexanderbez approved these changes

@jackzampolin jackzampolin jackzampolin approved these changes

@alessio alessio Awaiting requested review from alessio

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

@sabau sabau Awaiting requested review from sabau

Assignees
No one assigned
Labels
T:Docs Changes and features related to documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve intro docs and add app-specific blockchain section
4 participants
@gamarin2 @hschoenburg @alexanderbez @jackzampolin