Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reproducible_builds and macos_ci jobs from circleci config #4386

Merged
merged 1 commit into from
May 21, 2019

Conversation

alessio
Copy link
Contributor

@alessio alessio commented May 21, 2019

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented May 21, 2019

Codecov Report

Merging #4386 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #4386      +/-   ##
=========================================
- Coverage   57.22%   57.2%   -0.02%     
=========================================
  Files         241     241              
  Lines       15125   15125              
=========================================
- Hits         8655    8653       -2     
- Misses       5840    5842       +2     
  Partials      630     630

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. This should now live in gaia, right?

@alessio
Copy link
Contributor Author

alessio commented May 21, 2019

Yep correct @alexanderbez

@alessio alessio merged commit 3a2423d into master May 21, 2019
@alessio alessio deleted the alessio/clean-circleci-config branch May 21, 2019 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants