Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Negative height paramter's value leads to undefined behaviour #4510

Merged
merged 1 commit into from
Jun 7, 2019

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Jun 7, 2019

Follow-up of #4505
Issue: #4501

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@alexanderbez alexanderbez merged commit 97d1021 into master Jun 7, 2019
@alexanderbez alexanderbez deleted the alessio/height-strict-parsing branch June 7, 2019 18:11
@codecov
Copy link

codecov bot commented Jun 7, 2019

Codecov Report

Merging #4510 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4510      +/-   ##
==========================================
- Coverage   53.23%   53.22%   -0.01%     
==========================================
  Files         259      259              
  Lines       16203    16206       +3     
==========================================
+ Hits         8625     8626       +1     
- Misses       6932     6934       +2     
  Partials      646      646

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants