Coinswap module #4644
Closed
Coinswap module #4644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lin/4443-uniswap
…lin/4443-uniswap
golangcibot
reviewed
Jun 28, 2019
golangcibot
reviewed
Jun 29, 2019
4 tasks
|
For anyone following, development is blocked on #4657 as trading pairs will become a module sub-account |
colin-axner
commented
Jul 30, 2019
|
|
||
| // queryParameters returns coinswap module parameter queried for upon success | ||
| // or an error if the query fails | ||
| func queryParameters(ctx sdk.Context, path []string, req abci.RequestQuery, k Keeper) ([]byte, sdk.Error) { |
There was a problem hiding this comment.
return marshalled param struct instead
Fix GetInputAmount formula
* Added query.go that includes the cli commands for querying. * Added transaction subcommands such as add and remove liquidity. * Added tx command for swap order message type. * Added REST API commands for transaction sub commands specific to the coinswap module. * Added REST API commands for the query sub commands. Also added a struct type for query params in querier.go. Incorporated review comment of querying liquidity with a param. Fixed some code problems in tx.go.. * Removed some lines of code that were commented. * Update x/coinswap/client/cli/tx.go Co-Authored-By: colin axner <colinaxner@berkeley.edu> * Update x/coinswap/client/cli/tx.go Co-Authored-By: colin axner <colinaxner@berkeley.edu> * Update x/coinswap/internal/types/querier.go Co-Authored-By: colin axner <colinaxner@berkeley.edu> * Incorporating Colin's and Fede's review comments. * Update x/coinswap/client/rest/query.go Co-Authored-By: colin axner <colinaxner@berkeley.edu> * Update x/coinswap/client/rest/query.go Co-Authored-By: colin axner <colinaxner@berkeley.edu> * Incorporating Fede and Colin's review comments. * Address Colin's comments. * Addressing comments on handling time.parse errors. * Addressed review comments about flags and splitting swap order into buy and sell order. * Addressed Colin's comments. * Addressing comment of removing req.Sender.
|
As a team, we decided to pause this work as we don't have capacity to maintain this module atm. If someone is interested in resuming work here please get in touch. cc: @sunnya97 |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
this pr has been moved here: cosmos/modules#10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4443
To do:
Client, Events, unit tests (keeper, querier, handler), simulation
CLI/Rest being tackled in #4719
I still am in favor of using
sdk.Decfor the fee parameter, but the swap calculations would need to be rewritten and verified. Using the Uniswap equations until further notice.Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry:
clog add [section] [stanza] [message]rereviewed
Files changedin the github PR explorerFor Admin Use: