R4R: runsim pushes logs to S3 bucket #4677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mircea-c
requested review from
alexanderbez,
jackzampolin and
rigelrozanski
as code owners
alexanderbez
reviewed
Jul 3, 2019
fedekunze
reviewed
Jul 3, 2019
| ) | ||
|
|
||
| func awsErrHandler(err error) { | ||
| func awsErrHandler(err error) error { | ||
| if awsErr, ok := err.(awserr.Error); ok { | ||
| switch awsErr.Code() { |
There was a problem hiding this comment.
do we need this switch statement?
There was a problem hiding this comment.
Not right now, but I want it in there for later when I'll get around to handling some of these error codes better.
There was a problem hiding this comment.
I'd delete it and re-add later it if necessary
|
@alexanderbez I'm not sure what the plan is for the simulator. There's also a As for the logs, any failed seeds will generate a message in the slack channel. The message will have the links to the log file and anyone can download them. |
Codecov Report
@@ Coverage Diff @@
## master #4677 +/- ##
==========================================
+ Coverage 54.88% 54.89% +0.01%
==========================================
Files 271 271
Lines 16975 16975
==========================================
+ Hits 9316 9318 +2
+ Misses 6974 6972 -2
Partials 685 685 |
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
alessio
approved these changes
Jul 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry:
clog add [section] [stanza] [message]rereviewed
Files changedin the github PR explorerFor Admin Use: