update x/slashing to match module spec #4717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4717 +/- ##
========================================
- Coverage 53.9% 53.7% -0.2%
========================================
Files 273 273
Lines 17367 17277 -90
========================================
- Hits 9362 9279 -83
+ Misses 7321 7314 -7
Partials 684 684 |
fedekunze
requested review from
alessio,
alexanderbez,
jackzampolin and
rigelrozanski
as code owners
|
Looks like this could use some 👁 from @alexanderbez and @rigelrozanski |
…dekunze/slashing-internal
alessio
approved these changes
Jul 18, 2019
alexanderbez
suggested changes
Jul 18, 2019
| @@ -9,22 +9,23 @@ import ( | |||
| abci "github.com/tendermint/tendermint/abci/types" | |||
|
|
|||
| sdk "github.com/cosmos/cosmos-sdk/types" | |||
| slashingkeeper "github.com/cosmos/cosmos-sdk/x/slashing/internal/keeper" | |||
There was a problem hiding this comment.
no need for an import alias here.
There was a problem hiding this comment.
this is mostly for util test funcs that imho shouldn't be aliased
|
Reviewed + merge conflicts need to be addressed @fedekunze. |
colin-axner
approved these changes
Jul 18, 2019
Co-Authored-By: Alexander Bezobchuk <alexanderbez@users.noreply.github.com> Co-Authored-By: colin axner <colinaxner@berkeley.edu>
…dekunze/slashing-internal
…os/cosmos-sdk into fedekunze/slashing-internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry:
clog add [section] [stanza] [message]rereviewed
Files changedin the github PR explorerFor Admin Use: